Received-SPF: pass (google.com: domain of linux-kernel+bounces-178813-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: dthaler1968@googlemail.com
To: "'Puranjay Mohan'" <puranjay@kernel.org>,
	"'David Vernet'" <void@manifault.com>,
	"'Alexei Starovoitov'" <ast@kernel.org>,
	"'Daniel Borkmann'" <daniel@iogearbox.net>,
	"'Andrii Nakryiko'" <andrii@kernel.org>,
	"'Martin KaFai Lau'" <martin.lau@linux.dev>,
	"'Eduard Zingerman'" <eddyz87@gmail.com>,
	"'Song Liu'" <song@kernel.org>,
	"'Yonghong Song'" <yonghong.song@linux.dev>,
	"'John Fastabend'" <john.fastabend@gmail.com>,
	"'KP Singh'" <kpsingh@kernel.org>,
	"'Stanislav Fomichev'" <sdf@google.com>,
	"'Hao Luo'" <haoluo@google.com>,
	"'Jiri Olsa'" <jolsa@kernel.org>,
	"'Jonathan Corbet'" <corbet@lwn.net>,
	"'Dave Thaler'" <dthaler1968@googlemail.com>,
	"'Will Hawkins'" <hawkinsw@obs.cr>,
	<bpf@vger.kernel.org>,
	<bpf@ietf.org>,
	<linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: <puranjay12@gmail.com>
References: <20240514130303.113607-1-puranjay@kernel.org>
In-Reply-To: <20240514130303.113607-1-puranjay@kernel.org>
Subject: RE: [PATCH bpf] bpf, docs: Fix the description of 'src' in ALU instructions
Date: Tue, 14 May 2024 08:33:55 -0600
Message-ID: <019c01daa60b$c08873b0$41995b10$@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: AQMgS3ITkG+5x2/Y13ejOoDX0Q3k4K8LgGnA
Content-Language: en-us

Puranjay Mohan <puranjay@kernel.org> wrote: 
> An ALU instruction's source operand can be the value in the source
register or the
> 32-bit immediate value encoded in the instruction. This is controlled by
the 's' bit of
> the 'opcode'.
> 
> The current description explicitly uses the phrase 'value of the source
register'
> when defining the meaning of 'src'.
> 
> Change the description to use 'source operand' in place of 'value of the
source
> register'.
> 
> Signed-off-by: Puranjay Mohan <puranjay@kernel.org>

Acked-by: Dave Thaler <dthaler1968@gmail.com>

> ---
>  Documentation/bpf/standardization/instruction-set.rst | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/bpf/standardization/instruction-set.rst
> b/Documentation/bpf/standardization/instruction-set.rst
> index a5ab00ac0b14..2e17b365388e 100644
> --- a/Documentation/bpf/standardization/instruction-set.rst
> +++ b/Documentation/bpf/standardization/instruction-set.rst
> @@ -292,8 +292,9 @@ Arithmetic instructions  ``ALU`` uses 32-bit wide
> operands while ``ALU64`` uses 64-bit wide operands for  otherwise
identical
> operations. ``ALU64`` instructions belong to the
>  base64 conformance group unless noted otherwise.
> -The 'code' field encodes the operation as below, where 'src' and 'dst'
refer -to the
> values of the source and destination registers, respectively.
> +The 'code' field encodes the operation as below, where 'src' refers to
> +the the source operand and 'dst' refers to the value of the destination
> +register.
> 
>  =====  =====  =======
> ==========================================================
>  name   code   offset   description
> --
> 2.40.1