Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp2760033lqo; Tue, 14 May 2024 08:21:35 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUVm1hizzRoZfMW1BMjhOIWEnjqRrQzafia/LcO2vc3PS9YZQcGISXqd1Ufa0FWDsKn2b2jEl2j3pxFHY8JjXkSaL2VBNHsLMT/ctVpAA== X-Google-Smtp-Source: AGHT+IEaLaDBdJznFf6h+HkehGAulD9huBbBjTgNED5uaVDxNpK+EOQDkijot8lsVubKN/eBjfhM X-Received: by 2002:a17:907:7fa4:b0:a59:9fc8:38c2 with SMTP id a640c23a62f3a-a5a2d58550dmr1046583166b.31.1715700095363; Tue, 14 May 2024 08:21:35 -0700 (PDT) Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a5a1797bf56si633456966b.229.2024.05.14.08.21.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 08:21:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-178849-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=hn2yuupi; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-178849-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-178849-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 16BC01F22813 for ; Tue, 14 May 2024 15:21:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6642517F36B; Tue, 14 May 2024 15:21:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel.com header.i=@intel.com header.b="hn2yuupi" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04FA36D1A7; Tue, 14 May 2024 15:21:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715700080; cv=none; b=iJ3+rPvZOCFDG/dxSbkwDn9Gv3TU1UdOWmJv5U2w3DP6duueVxugsGzDnhK0jTJL2vuW7V+ayW5aBQFFzEGKCZjpNF8i8L2hVi8/QTY4j1DTflmUaqxjLfPemE7EvcIplUwdblicT1O5udLmr2pU+uyjinuhsxDhbDrGbYdSPRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715700080; c=relaxed/simple; bh=AvI5hbrvPA4iuIG9qxPDacNYxMQQhFyv9cCcqxA3glY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c8OwG4QtDuwswFuCqLn2ZyMeDwR4dFgVLmMYNRgaz4E9YAJz9yxrMbbuSGsaqjqctTjEa375TDLQDc3+sWHWVWfLYUxWU3eagU3emdSqrZ99sBF1k+UDunAKlFrgFH+ZpG9XtPAZT/8v7FqW/mpCLAEGK/8dAHcbomGYuv0VGdQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=hn2yuupi; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715700079; x=1747236079; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=AvI5hbrvPA4iuIG9qxPDacNYxMQQhFyv9cCcqxA3glY=; b=hn2yuupiByIsU8zjqy5cSgrAZmfznU6BkNPCt+aa5A5hdKulpRFIJIW6 EWBQhoqTxWMi9CegM9wLdMZInPmJN3AALmfPF6IkIIiQBEfF/3D6jD6VY kBzAUsm2f3mlp7xIfdauEmtwMkMkyvJjw1lPqrjm46FDAIfO4hszb/Scb EwzhWJPw3pINMUtSTJSlyhemWOSH9o+hCuuIS6O47/Unvuy1UBEhOlprw KZaJlghhdn97bgcsoi7eVw3FViKnPDdfl9c3dm0sl7LOFw8gwCP0Re1f8 riq39hlMOLUvxAN8zc4KLsIwtaFULjhc4gzRummGmkET8MqsY/JwOTEA/ g==; X-CSE-ConnectionGUID: JudtloilTP6o5GGo6RkjRw== X-CSE-MsgGUID: tZ5vDcpzTRWgtncY/d9hqg== X-IronPort-AV: E=McAfee;i="6600,9927,11073"; a="11858340" X-IronPort-AV: E=Sophos;i="6.08,159,1712646000"; d="scan'208";a="11858340" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2024 08:21:18 -0700 X-CSE-ConnectionGUID: aU9mjho7QRWjI4OzxI/h2g== X-CSE-MsgGUID: EH+yz+mZR8mcu1GxZnVK6w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,159,1712646000"; d="scan'208";a="31264554" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2024 08:21:16 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1s6txp-00000007ThE-1tgY; Tue, 14 May 2024 18:21:13 +0300 Date: Tue, 14 May 2024 18:21:13 +0300 From: Andy Shevchenko To: Sakari Ailus Cc: Dan Carpenter , Bingbu Cao , Mauro Carvalho Chehab , Hans de Goede , Daniel Scally , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2] media: ipu-bridge: fix error code in ipu_bridge_init() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, May 14, 2024 at 02:33:31PM +0000, Sakari Ailus wrote: > On Fri, May 10, 2024 at 06:43:31PM +0300, Dan Carpenter wrote: .. > Neither IPU3-CIO2 or IPU6 ISYS drivers should be of any functional use > without sensors. But the power states of the devices could be affected by > this: the drivers should power off these devices but without drivers they > maybe left powered on. I haven't made any measurements though. FWIW, Hans mentioned AtomISPv2 case with somewhat 7W consumption on top of the idling machine. That's why we have a stub driver in PDx86 exactly for the purpose of turning it off when not used. Hans may correct me if I'm wrong in numbers or elsewhere. -- With Best Regards, Andy Shevchenko