Received-SPF: pass (google.com: domain of linux-kernel+bounces-178863-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH] cpufreq: amd-pstate: fix the memory to free after epp
 exist
From: mazhida <zhida312@outlook.com>
In-Reply-To: <CYYPR12MB8655C82734A252F7983A9EF49CE32@CYYPR12MB8655.namprd12.prod.outlook.com>
Date: Tue, 14 May 2024 14:27:07 +0800
Cc: "rafael@kernel.org" <rafael@kernel.org>,
 "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
 "Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
 Peng Ma <andypma@tencent.com>,
 "Huang, Ray" <Ray.Huang@amd.com>,
 "Limonciello, Mario" <Mario.Limonciello@amd.com>,
 "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-ID:
 <TYZPR01MB5101C760CD59A20D411F31E992E32@TYZPR01MB5101.apcprd01.prod.exchangelabs.com>
References: <PUZPR01MB51206E9B32294882EC34B09592E32@PUZPR01MB5120.apcprd01.prod.exchangelabs.com>
 <CYYPR12MB8655C82734A252F7983A9EF49CE32@CYYPR12MB8655.namprd12.prod.outlook.com>
To: "Yuan, Perry" <Perry.Yuan@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: TYZPR01MB5101:EE_|PUZPR01MB4644:EE_
X-MS-Office365-Filtering-Correlation-Id: fb00d0a9-b84b-43c8-a441-08dc742b28af
X-Microsoft-Antispam:
	BCL:0;ARA:14566002|461199019|3430499023|3420499023|440099019|3412199016;
X-Microsoft-Antispam-Message-Info:
	bXFpyO7TmHA3xlOgbAV8VEk9PUGOVWDj0ThKTtV7zej3gIqP+iSx3wZCjQY9S2OgL1rRhOYBaS6chQwrlF6Szk/+FAS8aVDcoabrxzeho0OQ2Sar8gPYTjeH0yYwXmVotVDXmmVGCW0H/6Ge5nJf9j+UYQkKj3mcuUqW2v1OfbfKxfKeeJrZcpHt2m5c+bRfGnZBnNZ/efLdz22iXArCwCR6VUNtaq7/y7FdM4nAH5bkQHYoEbYhpq+70plpb1seLoU5mxeOjY9Rw0N0TzteG4nzNGqP+KaaGZHufNZ0TMbtIcFRRR2vkHLAOXet8U9jYgRN3FfyZ5rkrLGKE/9g76LnmFbOVFwxfdgInjJ+oRlk6kornTasnaxEZPzCyCIomhWl/ixdZMFdpVQdNXeVPmxbjdqPU0WzqaAbN6G7Sz3kQBzyb9SpRmrelhTNMtwgBc65F5PbmUtMV5U9RVPu7pKkCteGKeSg5ti1PHhZZtQrrCXYlY63IWw+cfYfYe0ig5bsQMKlKBFyYBq6K723aIuUGYUqlJSBhc1Ne6NVRaxFE3hXfb8EhpS2V6/3GSrI
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dStpQkdVMHQ2UmRJSGhXMUxkbWxnRTZ5UlNHUlorOEZQZFdGNVZnMFhld2Qw?=
 =?utf-8?B?b2FwL2tHWWtIZTRFeU1lS1dlZmdqSDByZElOLzRmc3UxUWhKRGkraXZDUEdr?=
 =?utf-8?B?WmRKRC8xZnZTdEhVSjNWWUZBNnJtYmFVVlQ5U29NVFZPVXBXWkFHcUx0U1N5?=
 =?utf-8?B?RVRVM25NOHMrUTFCZ2l0TGhQc1RRbTA0RzJXaitjZGh6MVVZNUl4Ymw0Y2tX?=
 =?utf-8?B?c0ZTNXU3VVlTd055Y2NuWUZxMk9YTVF5L1dsTkVNMzFWL3ZkYXFVVm9SSm9M?=
 =?utf-8?B?VlpHMjErelFWSG0zWm55Wm9VTDA4U0xTb092ckg1ZGJUTVpFTVNNWEtZSjZq?=
 =?utf-8?B?aVFEK01zMWhEaUZkY1c1UEpMRE8reTljY2t1bkdQT0pBcWlPdEhPWWc1NmJl?=
 =?utf-8?B?UGU0QkJ1bGlmblFvL2FwdjIzc0RKTEFxdksrRGJzT1FYTE1IdVlKSWs5eEFm?=
 =?utf-8?B?aGVnZEtVUDZGam4yenNCcEVYOCs5dUEzU0Y4UUxzWmtNNkNnVk52ZFQwLzFC?=
 =?utf-8?B?QWt1MHc4MnMreExhV0V3WDBNaS9xdkw1bUpkY0p1cTdBeW0wcTJ0WVhLYlV5?=
 =?utf-8?B?TnFYb1BQMEhVcGNZUjBNdEhXY3A5ejdrUThnYWwydlJ0ZjhQZGw3SkYvaVVR?=
 =?utf-8?B?amw3alNpUkF1VzBLQS9FenowTCs4N0VqOFFOaEtSU1NVR21TUkZSQnlMOENQ?=
 =?utf-8?B?cFljWVp5ZTE4UDJlSU0vaklNN2ZRd3ZsK2I4WXVGa0Z3VzBkUmRpSDNYdWVz?=
 =?utf-8?B?cTVSSkhqREF6MXljZ1JRQXVvS3hwNlNhZjhzS3dPcEphNEVDcnhSeXhKbUI4?=
 =?utf-8?B?Zk9mOUFkQUJLN0lWOGFrL0FMaGdKRHZmNlowbG5zNEE1Rm1qakRLeEJqRmZ4?=
 =?utf-8?B?TWlKUEJZSEEzM04raVZLd20xbHYzVmJZS3Z3T3FzekdWdm9KQ1dYdzFQM1pN?=
 =?utf-8?B?NXdTRFFWREtIVy9WODEwUTdNMFE5M1pBc2VsK0JWTmhjRnFWUjM5Um1uVXdD?=
 =?utf-8?B?cE1ua0VtM0lOMEphTVluS24zYU1CRktCQVU4ZGZjaUhYVW56WDkrLy9DUGFs?=
 =?utf-8?B?S3RYeTFsUFdvUWVWdDBVZUd3NmptZ25Sa1Q4VFhIK0l5YkZ3ZzFIR3pXVjE5?=
 =?utf-8?B?YWZQUHRsMEovTkxhSWo2MHBOS2dyZXA4K0l2VnZVTXNETTAvN0tFb1UvdXNZ?=
 =?utf-8?B?cE9RTk9vL2xWOWVEblpIcFltTWplWWlKcmxWeWt6ZjFJeUhmaFBOR3ZoRDVB?=
 =?utf-8?B?eEplbm51WWFXOVQwQTZZTHZSeWdEWXg1N2JqN1JoZkgxWlcvS2RPY3BxcG9t?=
 =?utf-8?B?WEpxV1phcTBxWHZyc0I0Y3A1aXBUTnpaaVhOdVRubmRaWFZUejlhWFZWRHpH?=
 =?utf-8?B?TXBZK2lXb2JYNys1S0hWdTNkbkpJeUQxcGJiQUxnVG9KdUV2UXYvd29sUS9r?=
 =?utf-8?B?MGFkbmt0TXBoeU1XNjJvdENFY1lFSzhBTFovNnIzR1pCK1pwU2hwZk1YSENI?=
 =?utf-8?B?cXE5R1dhcWVuck90YU43d1NUM1ZYT081dWp3ZFBTbkNIeUlJclNuWDJHUFBG?=
 =?utf-8?B?K0N6M2F2cVIwVTBMRTdYVXJqQ0R1TERlQjh0OW9BTnhDbnk3MlhuREdjWTVp?=
 =?utf-8?Q?nIebrE+blOhTvaAkBdO/s/qLy3CDC4778LjwzFyaEC7w=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb00d0a9-b84b-43c8-a441-08dc742b28af
X-MS-Exchange-CrossTenant-AuthSource: TYZPR01MB5101.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2024 15:33:09.7977
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR01MB4644

Hi Perry,

	Yes=EF=BC=8COf course.

BR,
Peng

> 2024=E5=B9=B45=E6=9C=8814=E6=97=A5 12:51=EF=BC=8CYuan, Perry <Perry.Yuan@=
amd.com> =E5=86=99=E9=81=93=EF=BC=9A
>=20
> [AMD Official Use Only - AMD Internal Distribution Only]
>=20
> Hi Peng,
>=20
>> -----Original Message-----
>> From: zhida312@outlook.com <zhida312@outlook.com>
>> Sent: Tuesday, May 14, 2024 11:17 AM
>> To: rafael@kernel.org; viresh.kumar@linaro.org
>> Cc: Peng Ma <andypma@tencent.com>; Huang, Ray <Ray.Huang@amd.com>;
>> Shenoy, Gautham Ranjal <gautham.shenoy@amd.com>; Limonciello, Mario
>> <Mario.Limonciello@amd.com>; Yuan, Perry <Perry.Yuan@amd.com>; linux-
>> pm@vger.kernel.org; linux-kernel@vger.kernel.org
>> Subject: [PATCH] cpufreq: amd-pstate: fix the memory to free after epp e=
xist
>>=20
>> From: andypma <andypma.tencent.com>
>>=20
>> the cpudata memory from kzmalloc in epp init function is not free after =
epp exist,
>> so we should free it.
>>=20
>> Signed-off-by: Peng Ma <andypma@tencent.com>
>> ---
>> drivers/cpufreq/amd-pstate.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>=20
>> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c=
 index
>> 2db095867d03..96a323f59a93 100644
>> --- a/drivers/cpufreq/amd-pstate.c
>> +++ b/drivers/cpufreq/amd-pstate.c
>> @@ -1425,6 +1425,9 @@ static int amd_pstate_epp_cpu_init(struct
>> cpufreq_policy *policy)
>>=20
>> static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy)  {
>> +     struct amd_cpudata *cpudata =3D policy->driver_data;
>> +
>> +     kfree(cpudata);
>>   pr_debug("CPU %d exiting\n", policy->cpu);
>>   return 0;
>> }
>> --
>> 2.33.0
>=20
> Thanks for the patch, how about change to be like below?
>=20
> if (cpudata) {
>     kfree(cpudata);
>     policy->driver_data =3D NULL;
> }
>=20
> Perry.
>=20