Received-SPF: pass (google.com: domain of linux-kernel+bounces-178869-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <85cd8e12-261f-4fa0-aa83-75c7f692d8f3@intel.com>
Date: Tue, 14 May 2024 08:38:16 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] dmaengine: ioatdma: Fix missing kmem_cache_destroy()
To: n.shubin@yadro.com, Vinod Koul <vkoul@kernel.org>,
 Dan Williams <dan.j.williams@intel.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
 Nikita Shubin <nikita.shubin@maquefel.me>
References: <20240514-ioatdma_fixes-v1-1-2776a0913254@yadro.com>
Content-Language: en-US
From: Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20240514-ioatdma_fixes-v1-1-2776a0913254@yadro.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 5/14/24 3:52 AM, Nikita Shubin via B4 Relay wrote:
> From: Nikita Shubin <n.shubin@yadro.com>
> 
> Fix missing kmem_cache_destroy() for ioat_sed_cache in
> ioat_exit_module().
> 
> Noticed via:
> 
> ```
> modprobe ioatdma
> rmmod ioatdma
> modprobe ioatdma
> debugfs: Directory 'ioat_sed_ent' with parent 'slab' already present!
> ```
> 
> Fixes: c0f28ce66ecf ("dmaengine: ioatdma: move all the init routines")
> Signed-off-by: Nikita Shubin <n.shubin@yadro.com>

Thanks!

Acked-by: Dave Jiang <dave.jiang@intel.com>

> ---
>  drivers/dma/ioat/init.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
> index 9c364e92cb82..61329c279040 100644
> --- a/drivers/dma/ioat/init.c
> +++ b/drivers/dma/ioat/init.c
> @@ -1445,6 +1445,7 @@ module_init(ioat_init_module);
>  static void __exit ioat_exit_module(void)
>  {
>  	pci_unregister_driver(&ioat_pci_driver);
> +	kmem_cache_destroy(ioat_sed_cache);
>  	kmem_cache_destroy(ioat_cache);
>  }
>  module_exit(ioat_exit_module);
> 
> ---
> base-commit: a38297e3fb012ddfa7ce0321a7e5a8daeb1872b6
> change-id: 20240514-ioatdma_fixes-7460f4fd7d51
> 
> Best regards,