Received-SPF: pass (google.com: domain of linux-kernel+bounces-178874-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240514052402.3031871-1-irogers@google.com>
In-Reply-To: <20240514052402.3031871-1-irogers@google.com>
From: Ian Rogers <irogers@google.com>
Date: Tue, 14 May 2024 08:39:20 -0700
Message-ID: <CAP-5=fUc8zFup-87JjDfX38GoRpPdPwTdtfsxPqKmqJr1aHWGw@mail.gmail.com>
Subject: Re: [PATCH v1] perf arm-spe: Unaligned pointer work around
To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, 
	Arnaldo Carvalho de Melo <acme@kernel.org>, Namhyung Kim <namhyung@kernel.org>, 
	Mark Rutland <mark.rutland@arm.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Ian Rogers <irogers@google.com>, Adrian Hunter <adrian.hunter@intel.com>, 
	Kan Liang <kan.liang@linux.intel.com>, linux-perf-users@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Leo Yan <leo.yan@linux.dev>, 
	James Clark <james.clark@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, May 13, 2024 at 10:24=E2=80=AFPM Ian Rogers <irogers@google.com> wr=
ote:
>
> Use get_unaligned_leXX instead of leXX_to_cpu to handle unaligned
> pointers. Such pointers occur with libFuzzer testing.
>
> A similar change for intel-pt was done in:
> https://lore.kernel.org/r/20231005190451.175568-6-adrian.hunter@intel.com
>
> Signed-off-by: Ian Rogers <irogers@google.com>

+Leo Yan +James Clark surprisingly missed by get_maintainer.pl.

Thanks,
Ian

> ---
>  .../arm-spe-decoder/arm-spe-pkt-decoder.c     | 23 ++++---------------
>  1 file changed, 5 insertions(+), 18 deletions(-)
>
> diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c b/tool=
s/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
> index a454c6737563..7bf607d0f6d8 100644
> --- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
> +++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
> @@ -10,24 +10,11 @@
>  #include <byteswap.h>
>  #include <linux/bitops.h>
>  #include <stdarg.h>
> +#include <linux/kernel.h>
> +#include <asm-generic/unaligned.h>
>
>  #include "arm-spe-pkt-decoder.h"
>
> -#if __BYTE_ORDER__ =3D=3D __ORDER_BIG_ENDIAN__
> -#define le16_to_cpu bswap_16
> -#define le32_to_cpu bswap_32
> -#define le64_to_cpu bswap_64
> -#define memcpy_le64(d, s, n) do { \
> -       memcpy((d), (s), (n));    \
> -       *(d) =3D le64_to_cpu(*(d)); \
> -} while (0)
> -#else
> -#define le16_to_cpu
> -#define le32_to_cpu
> -#define le64_to_cpu
> -#define memcpy_le64 memcpy
> -#endif
> -
>  static const char * const arm_spe_packet_name[] =3D {
>         [ARM_SPE_PAD]           =3D "PAD",
>         [ARM_SPE_END]           =3D "END",
> @@ -70,9 +57,9 @@ static int arm_spe_get_payload(const unsigned char *buf=
, size_t len,
>
>         switch (payload_len) {
>         case 1: packet->payload =3D *(uint8_t *)buf; break;
> -       case 2: packet->payload =3D le16_to_cpu(*(uint16_t *)buf); break;
> -       case 4: packet->payload =3D le32_to_cpu(*(uint32_t *)buf); break;
> -       case 8: packet->payload =3D le64_to_cpu(*(uint64_t *)buf); break;
> +       case 2: packet->payload =3D get_unaligned_le16(buf); break;
> +       case 4: packet->payload =3D get_unaligned_le32(buf); break;
> +       case 8: packet->payload =3D get_unaligned_le64(buf); break;
>         default: return ARM_SPE_BAD_PACKET;
>         }
>
> --
> 2.45.0.rc1.225.g2a3ae87e7f-goog
>