Received-SPF: pass (google.com: domain of linux-kernel+bounces-178937-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240513220146.1461457-1-yury.norov@gmail.com>
 <20240513220146.1461457-5-yury.norov@gmail.com> <e0bc19d6-4a15-faa4-c8e1-163904276d5b@huawei.com>
In-Reply-To: <e0bc19d6-4a15-faa4-c8e1-163904276d5b@huawei.com>
From: Yury Norov <yury.norov@gmail.com>
Date: Tue, 14 May 2024 09:16:04 -0700
Message-ID: <CAAH8bW99V5dRLxH9MYR1jnphVkp0ojPSjHx1zmKBxEcosgOcDw@mail.gmail.com>
Subject: Re: [PATCH 4/6] genirq: optimize irq_do_set_affinity()
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: linux-kernel@vger.kernel.org, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Paul E. McKenney" <paulmck@kernel.org>, 
	"Rafael J. Wysocki" <rafael@kernel.org>, Anna-Maria Behnsen <anna-maria@linutronix.de>, 
	Ben Segall <bsegall@google.com>, Daniel Bristot de Oliveira <bristot@redhat.com>, 
	Dietmar Eggemann <dietmar.eggemann@arm.com>, Frederic Weisbecker <frederic@kernel.org>, 
	Imran Khan <imran.f.khan@oracle.com>, Ingo Molnar <mingo@redhat.com>, 
	Johannes Weiner <hannes@cmpxchg.org>, Juri Lelli <juri.lelli@redhat.com>, 
	Leonardo Bras <leobras@redhat.com>, Mel Gorman <mgorman@suse.de>, 
	Peter Zijlstra <peterz@infradead.org>, Rik van Riel <riel@surriel.com>, 
	Steven Rostedt <rostedt@goodmis.org>, Tejun Heo <tj@kernel.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Valentin Schneider <vschneid@redhat.com>, 
	Vincent Guittot <vincent.guittot@linaro.org>, Waiman Long <longman@redhat.com>, 
	Zefan Li <lizefan.x@bytedance.com>, cgroups@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, May 14, 2024 at 5:51=E2=80=AFAM Jinjie Ruan <ruanjinjie@huawei.com>=
 wrote:
>
>
>
> On 2024/5/14 6:01, Yury Norov wrote:
> > If mask =3D=3D desc->irq_common_data.affinity, copying one to another i=
s
> > useless, and we can just skip it.
> >
> > Signed-off-by: Yury Norov <yury.norov@gmail.com>
> > ---
> >  kernel/irq/manage.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> > index bf9ae8a8686f..ad9ed9fdf919 100644
> > --- a/kernel/irq/manage.c
> > +++ b/kernel/irq/manage.c
> > @@ -285,7 +285,8 @@ int irq_do_set_affinity(struct irq_data *data, cons=
t struct cpumask *mask,
> >       switch (ret) {
> >       case IRQ_SET_MASK_OK:
> >       case IRQ_SET_MASK_OK_DONE:
> > -             cpumask_copy(desc->irq_common_data.affinity, mask);
> > +             if (desc->irq_common_data.affinity !=3D mask)
> > +                     cpumask_copy(desc->irq_common_data.affinity, mask=
);
>
> It seems that mask is a pointer, shouldn't use "cpumask_equal"=EF=BC=9F

cpumask_equal() is O(N), just as cpumask_copy(), so we'll have no
benefit if the masks are equal, and will double slow it if they aren't
in the worst case.

On the other hand, pointers comparison is O(1), a very quick tasks,
even more the pointers are already in registers.

> >               fallthrough;
> >       case IRQ_SET_MASK_OK_NOCOPY:
> >               irq_validate_effective_affinity(data);