Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp2833841lqo; Tue, 14 May 2024 10:26:21 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXfZ0ihP//ILz9M0eLx7yw1maASvZBT2JE8ilVnWGHa92t1DRr3S+tfaobOHPjRywaqEwLS3MZ4Qoo/dyCY0TvTffCAD8/1uEqS8+lalQ== X-Google-Smtp-Source: AGHT+IGGBQK4HVXtyfpuB0lXSH4JY7WTHjk97z1PrXFPzUoAXZAG9zKU5kkXgYCqOnx4qjOBfhca X-Received: by 2002:a17:90a:bd0f:b0:2b2:c73a:7acc with SMTP id 98e67ed59e1d1-2b6ccedd33cmr12111439a91.37.1715707581215; Tue, 14 May 2024 10:26:21 -0700 (PDT) Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2b628869476si13568614a91.15.2024.05.14.10.26.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 10:26:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-179001-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@chromium.org header.s=google header.b=czPPBXJ+; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-179001-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-179001-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A5029B227BD for ; Tue, 14 May 2024 17:23:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 73448181BA9; Tue, 14 May 2024 17:22:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="czPPBXJ+" Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A187181322 for ; Tue, 14 May 2024 17:22:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715707335; cv=none; b=P3XDI/fZcYSQeCKCYDvLPBFckCJ4+tf9cHYHXgDn2GjPJeqMolxISuRBUvcNfoXGyfFnzuTAiiYR58s7h4Bhs42UvFT99boN9JRwtRq8T9B4bKvou5gJP/iSxQSV3BB6jGU5oFfMRv03IGQd0T1JPJERzXSk3w8ly3Xck0ZDXl0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715707335; c=relaxed/simple; bh=tsa6AYuf40jHiTJukh+6TV9aFnwKy1NsbiB5LC+CvyE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QUytp537GfzPgUEylGxZKOI7/0MARadLdmViA3INNTxN84cACD9owGMVZhXbnCSd9EjtxwmQ01F+fujDYP+2pQayCh1yBaPhaxKsMaEUwRBWYVdhQ6M9SsFZpukPN7GeaHUmb8KkNVfFIWeS5aq1BgsB7EGeWHw0vI0ZkzHGMoA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=czPPBXJ+; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1edfc57ac0cso47823295ad.3 for ; Tue, 14 May 2024 10:22:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715707330; x=1716312130; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vLidwqUpHr187hGFcEiCCAyDeHC6n0W/LwS7hTKYWys=; b=czPPBXJ+pgUazucq07tNYWOzeVw2KfhdLUxsGqS9iUrW9RRotEnnBtFrwBE/Sfdzm0 u50eYI1hF3RPN6YnaPFNcEgChznb9jN2HL/PBTTFHnLg+AbmAp9w5wf4CypVT3xNAvrM vsyL9/pCWCb1OUip7WBh2V4gHTrWoMVWeyEh0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715707330; x=1716312130; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vLidwqUpHr187hGFcEiCCAyDeHC6n0W/LwS7hTKYWys=; b=vCLnCDmt5sH7cWdzFLzZhzVVlYUf/Cd4YawB+YbVBwpyg1JutGHVlKY4Y7B5fPI4QI 2102p1g8GRcWbcnOpl0bqk3hXqzSpEGApv1WAjDNl4LtCPsam5c8KqsC570/ofgaJEp3 wKPV9USjqzxpQhpn5m5i+PjRG5OfdBUAcqAlzUn9GhVIclJb2x1GwjVkXOB0KmCFCHux eQvU6+hIkbPSE/rEuhZjbG9jnYMtqV1+y4lP+Ba3xGFfhex9l1AP8SbatTJqaf50dr/7 u1oVQxsJ26YQYcmXI5QLtUZ1xSXE9qRYQjoKql2QUxXMWPt0ZOvhU3X0ZDiNGiU9+FqS vEbg== X-Forwarded-Encrypted: i=1; AJvYcCXu7N2ndY9orl9Odtn9MtEL5N/cZjQsEhLKNhp96r7Cfs2wMLa12M+ke/ZdArrTZAQc5eAvOLqkbgkSYSNYbVXSxd0Sd9tV6hOwSmC6 X-Gm-Message-State: AOJu0Yxn9DqKF+ST1HoeUVRfF8i/aTc5UpF7UBZEFdZip8LGOVhZv9G9 gfH6ixvwUNFnQh2TGkNhHAwgHSGhAZgy/mALtGbdvguggd5mwdGwrXaQ9XuuAg== X-Received: by 2002:a17:902:e5d0:b0:1ee:1912:a9fc with SMTP id d9443c01a7336-1ef43f4d30amr162009955ad.53.1715707329188; Tue, 14 May 2024 10:22:09 -0700 (PDT) Received: from dianders.sjc.corp.google.com ([2620:15c:9d:2:ef10:6fdf:5041:421f]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf3101csm100147575ad.121.2024.05.14.10.22.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 10:22:08 -0700 (PDT) From: Douglas Anderson To: dri-devel@lists.freedesktop.org Cc: Javier Martinez Canillas , lvzhaoxiong@huaqin.corp-partner.google.com, Jani Nikula , Neil Armstrong , Brian Norris , Sam Ravnborg , Dmitry Baryshkov , Maxime Ripard , Joel Selvaraj , Hsin-Yi Wang , Cong Yang , Linus Walleij , Douglas Anderson , Daniel Vetter , David Airlie , Jessica Zhang , Maarten Lankhorst , Thomas Zimmermann , linux-kernel@vger.kernel.org Subject: [PATCH v5 7/9] drm/panel: boe-tv101wum-nl6: Don't use a table for initting panels Date: Tue, 14 May 2024 10:20:57 -0700 Message-ID: <20240514102056.v5.7.Ib5030ab5cd41b4e08b1958bd7e51571725723008@changeid> X-Mailer: git-send-email 2.45.0.rc1.225.g2a3ae87e7f-goog In-Reply-To: <20240514172136.1578498-1-dianders@chromium.org> References: <20240514172136.1578498-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Consensus on the mailing lists is that panels shouldn't use a table of init commands but should instead use init functions. With the recently introduced mipi_dsi_dcs_write_seq_multi() this is not only clean/easy but also saves space. Measuring before/after this change: $ scripts/bloat-o-meter \ .../before/panel-boe-tv101wum-nl6.ko \ .../after/panel-boe-tv101wum-nl6.ko add/remove: 14/8 grow/shrink: 0/1 up/down: 27062/-31433 (-4371) Function old new delta inx_hj110iz_init - 7040 +7040 boe_tv110c9m_init - 6440 +6440 boe_init - 5916 +5916 starry_qfh032011_53g_init - 1944 +1944 starry_himax83102_j02_init - 1228 +1228 inx_hj110iz_init.d - 1040 +1040 boe_tv110c9m_init.d - 982 +982 auo_b101uan08_3_init - 944 +944 boe_init.d - 580 +580 starry_himax83102_j02_init.d - 512 +512 starry_qfh032011_53g_init.d - 180 +180 auo_kd101n80_45na_init - 172 +172 auo_b101uan08_3_init.d - 82 +82 auo_kd101n80_45na_init.d - 2 +2 auo_kd101n80_45na_init_cmd 144 - -144 boe_panel_prepare 592 440 -152 auo_b101uan08_3_init_cmd 1056 - -1056 starry_himax83102_j02_init_cmd 1392 - -1392 starry_qfh032011_53g_init_cmd 2256 - -2256 compoundliteral 3393 - -3393 boe_init_cmd 7008 - -7008 boe_tv110c9m_init_cmd 7656 - -7656 inx_hj110iz_init_cmd 8376 - -8376 Total: Before=37297, After=32926, chg -11.72% Let's do the conversion. Since we're touching all the tables, let's also convert hex numbers to lower case as per kernel conventions. Reviewed-by: Linus Walleij Signed-off-by: Douglas Anderson --- (no changes since v3) Changes in v3: - Fix spacing of init function. - Remove an unneeded error print. - Squash boe-tv101wum-nl6 lowercase patch into main patch Changes in v2: - New .../gpu/drm/panel/panel-boe-tv101wum-nl6.c | 2792 +++++++++-------- 1 file changed, 1442 insertions(+), 1350 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c index 0ffe8f8c01de..aab60cec0603 100644 --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c @@ -17,6 +17,8 @@ #include