Received-SPF: pass (google.com: domain of linux-kernel+bounces-179086-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 14 May 2024 12:02:40 -0700
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Andrea Parri <parri.andrea@gmail.com>
Cc: Puranjay Mohan <puranjay@kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Will Deacon <will@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	David Howells <dhowells@redhat.com>,
	Jade Alglave <j.alglave@ucl.ac.uk>,
	Luc Maranget <luc.maranget@inria.fr>,
	Akira Yokosawa <akiyks@gmail.com>,
	Daniel Lustig <dlustig@nvidia.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	puranjay12@gmail.com
Subject: Re: [PATCH] tools/memory-model: Add atomic_andnot() with its variants
Message-ID: <aeba034f-142b-4d8f-9ea8-475f4dbaaf1c@paulmck-laptop>
Reply-To: paulmck@kernel.org
References: <20240514094633.48067-1-puranjay@kernel.org>
 <ZkNG2uZEiF1S6M7z@andrea>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZkNG2uZEiF1S6M7z@andrea>

On Tue, May 14, 2024 at 01:11:22PM +0200, Andrea Parri wrote:
> > C andnot
> > 
> > {
> > atomic_t u = ATOMIC_INIT(7);
> > }
> > 
> > P0(atomic_t *u)
> > {
> > 
> >         r0 = atomic_fetch_andnot(3, u);
> >         r1 = READ_ONCE(*u);
> > }
> > 
> > exists (0:r0=7 /\ 0:r1=4)
> 
> Fair enough for the changelog.  If/when submitting proper tests, please
> check their format using klitmus7 (besides herd7); say,
> 
>   $ mkdir mymodule
>   $ klitmus7 -o mymodule <.litmus file>
>   $ cd mymodule ; make
>   $ sudo sh run.sh
> 
> Documentation/litmus-tests/ provides some examples litmus tests.
> 
> 
> > Signed-off-by: Puranjay Mohan <puranjay@kernel.org>
> 
> Acked-by: Andrea Parri <parri.andrea@gmail.com>

Queued and pushed, thank you both!

Again, I will hold off pushing this until herd7 releases a version
supporting this.

							Thanx, Paul