Received-SPF: pass (google.com: domain of linux-kernel+bounces-179098-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 14 May 2024 15:25:11 -0400
From: Dan Schatzberg <schatzberg.dan@gmail.com>
To: Waiman Long <longman@redhat.com>, Tejun Heo <tj@kernel.org>
Cc: linux-block@vger.kernel.org, cgroups@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: cgroup io.stat propagation regression
Message-ID: <ZkO6l/ODzadSgdhC@dschatzberg-fedora-PF3DHTBV>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi Waiman,

I've noticed that on recent kernels io.stat metrics don't propagate
all the way up the hierarchy. Specifically, io.stat metrics of some
leaf cgroup will be propagated to the parent, but not its grandparent.

For a simple repro, run the following:

systemd-run --slice test-test dd if=/dev/urandom of=/tmp/test bs=4096 count=1

Then:

cat /sys/fs/cgroup/test.slice/test-test.slice/io.stat

Shows the parent cgroup stats and I see wbytes=4096 but the grandparent cgroup:

cat /sys/fs/cgroup/test.slice/io.stat

shows no writes.

I believe this was caused by the change in "blk-cgroup: Optimize
blkcg_rstat_flush()". When blkcg_rstat_flush is called on the parent
cgroup, it exits early because the lockless list is empty since the
parent cgroup never issued writes itself (e.g. in
blk_cgroup_bio_start). However, in doing so it never propagated stats
to its parent.

Can you confirm if my understanding of the logic here is correct and
advise on a fix?