Received-SPF: pass (google.com: domain of linux-kernel+bounces-179183-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <9fb7adfc-701b-427c-a08e-a007e3159601@wanadoo.fr>
Date: Tue, 14 May 2024 22:53:00 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/6] sched/topology: optimize topology_span_sane()
To: Yury Norov <yury.norov@gmail.com>
References: <20240513220146.1461457-1-yury.norov@gmail.com>
 <20240513220146.1461457-3-yury.norov@gmail.com>
Content-Language: en-MW
Cc: anna-maria@linutronix.de, bristot@redhat.com, bsegall@google.com,
 cgroups@vger.kernel.org, dietmar.eggemann@arm.com, frederic@kernel.org,
 gregkh@linuxfoundation.org, hannes@cmpxchg.org, imran.f.khan@oracle.com,
 juri.lelli@redhat.com, leobras@redhat.com, linux-kernel@vger.kernel.org,
 lizefan.x@bytedance.com, longman@redhat.com, mgorman@suse.de,
 mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org,
 rafael@kernel.org, riel@surriel.com, rostedt@goodmis.org,
 tglx@linutronix.de, tj@kernel.org, vincent.guittot@linaro.org,
 vschneid@redhat.com
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
In-Reply-To: <20240513220146.1461457-3-yury.norov@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Le 14/05/2024 à 00:01, Yury Norov a écrit :
> The function may call cpumask_equal with tl->mask(cpu) == tl->mask(i),
> even though cpu != i. In such case, cpumask_equal() would always return
> true, and we can proceed to the next CPU immediately.
> 
> Signed-off-by: Yury Norov <yury.norov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>   kernel/sched/topology.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index 99ea5986038c..eb9eb17b0efa 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -2360,7 +2360,7 @@ static bool topology_span_sane(struct sched_domain_topology_level *tl,
>   	 * breaks the linking done for an earlier span.
>   	 */
>   	for_each_cpu(i, cpu_map) {
> -		if (i == cpu)
> +		if (i == cpu || tl->mask(cpu) == tl->mask(i))
>   			continue;
>   		/*
>   		 * We should 'and' all those masks with 'cpu_map' to exactly

Hi,

does it make sense to pre-compute tl->mask(cpu) outside the for_each_cpu()?

CJ