Received-SPF: pass (google.com: domain of linux-kernel+bounces-179222-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 15 May 2024 01:21:49 +0300
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, richardcochran@gmail.com,
	jacob.e.keller@intel.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net] net: lan966x: Remove ptp traps in case the ptp is
 not enabled.
Message-ID: <20240514222149.mhwtp3kduebb4zzs@skbuf>
References: <20240514193500.577403-1-horatiu.vultur@microchip.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240514193500.577403-1-horatiu.vultur@microchip.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ck01MvhtSsm4f5NtWmPR8KYgpti66fz+34NYeeWfIt8DzUXx/XycX7849kHh?=
 =?us-ascii?Q?PsRhC4ICj2qeJ3bhQqzGZ0WvNDC99HtHhhUwNpyYdhPiIvNe7tSMIQ/IMTTz?=
 =?us-ascii?Q?M97cxybrQTgRxm+VcEY8CuHZiY4e71+H2cqQ9bbtplJCMc01XhvGckISZsR2?=
 =?us-ascii?Q?ZaKTqx9hFb1rWmc/Gv1unoB0KonQWT5Q29NVk/KpNEFcY9jrUgV6/lz2b002?=
 =?us-ascii?Q?a1VoiwYKvuOUaLZ+mWfY4SY9Icxf3xwZGV0feOmL5E2eQOuAq8ts0kjUZvIJ?=
 =?us-ascii?Q?D0FzTgeXop1tytPqh8DPfj5QYL2Z3UpWCYZPir7tZhp8/oDhuZF68hQcXg+a?=
 =?us-ascii?Q?m2MeDCN1/w80vi2iyBzuVSeuckFaVbxse58hTU5FgsbkED+CA3wvIkdEyCAU?=
 =?us-ascii?Q?uqi4B3Cl25jNkcMryYOnM0aPyAWarslB2IoiqWX9kY8ocPK6TiuoLvnkq8er?=
 =?us-ascii?Q?gmeLAXmodSS8eogu0em8lFx46m1l3zmbighOEQH1WEFqqhTmJd5Nbt58PZj0?=
 =?us-ascii?Q?SCJr8m7USusYKAYPsd+7FSEwaH5LvgvTGTN1Htjlp70ho51dAz1V9EihP9HU?=
 =?us-ascii?Q?CCc7do3IwH/PeBsnqBXyVKEpqCBVpSCPkRu+2FOU+oh/rbCUv/YOb54L27G+?=
 =?us-ascii?Q?HNxC6YyOt9b+ihN3K+KUdeWnF1ZjPHxA9sYZrONOI4MnoiZzKgVZoQkaYADh?=
 =?us-ascii?Q?X9hx0C48riC90xGrlNg2ZTpisyZJntF9JwDxXm5RtaY8esz0AVpzpgfIvYWY?=
 =?us-ascii?Q?vBXcm+UKXUDonqRW6lq7/UCLa5DSQOibiR+yN+i03CiK5Y6WCgdkh06TRBCK?=
 =?us-ascii?Q?x15WvEduWxFp2dKAXhOCPy8WbRizen4Xepcg6nJJhxbh/SrexGR1QnHpVexm?=
 =?us-ascii?Q?JHXeVG6/re6p7ds3vhWShMa8qmkKkO9BUCqC/V7MWg6oV9gzq+wQbhArBHeX?=
 =?us-ascii?Q?7Y5S8GojF+yqP/OEkwq8250iuNs+dMY88vILx0DKqQASzFLmkvQdpRjvOCiG?=
 =?us-ascii?Q?h8YA/06lPvrEZke1mEueic9HvmphX9uDWd52w1fE24ZXv1IFIv6xWzvGrss2?=
 =?us-ascii?Q?8BMDZoiXe2qyAS+NkeN2iZGDnGTSViuxyHUoIEcaiaOeAQEhcSS9C9+i+ms8?=
 =?us-ascii?Q?GrNQ3/5nfgKRFmSjOykODUA4eVH/3GmX/ngg2CgMqfQ8I/f1yyKUjsHQDYlh?=
 =?us-ascii?Q?BFCx1B4M5VOxgoEZa4SP1BXU0in/OqVxWZSE8QhIepE0SRNT+gPVOY+6skf4?=
 =?us-ascii?Q?iyqJwCqEmtu31oxMz/JovTiCyO94nYXH45yt1pUUeWtPzbXwPh0z6fsxl2Jp?=
 =?us-ascii?Q?wnYlqkUdFpEn5ZKcE7vshvWQemFgpmboA/jDzY+Q/7+nxp1RyxwjPpCVGZHg?=
 =?us-ascii?Q?g8zaDU/E1Lf7kAY2YFuy6Zxopux8UUBKOZ/NyFC1J7xec2FUchRcNRl+gVya?=
 =?us-ascii?Q?sRViVf7IS3TsdK6rv40DRT97GtNU9xb7+d5UCcZW9vKDcm7w3pT7nTQ1ENCM?=
 =?us-ascii?Q?UOzvohFn/f+9Ng/I1ifES+ELINgKcuJaMSaLfoG3ZKDUGhJeN+uJC9eUUSOv?=
 =?us-ascii?Q?MhvCNsU7uWtFXKoh6X+AlgYVjX5yszcJpdEOZf6qGbv4TEyz/3k72h2d5ud1?=
 =?us-ascii?Q?Mg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 515d8c91-7be1-472a-2f2e-08dc746441b3
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB7374.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2024 22:21:52.8569
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DQ/XngKwUQ8vgEYHiu4D0K780Jcfy2A7S+o6FeNGdtPkCAkHjIXmn/ErqBfKszPXY8mjApnD3S6tpwqk8hO/ig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB10202

On Tue, May 14, 2024 at 09:35:00PM +0200, Horatiu Vultur wrote:
> Lan966x is adding ptp traps to redirect the ptp frames to the CPU such
> that the HW will not forward these frames anywhere. The issue is that in
> case ptp is not enabled and the timestamping source is et to
> HWTSTAMP_SOURCE_NETDEV then these traps would not be removed on the
> error path.
> Fix this by removing the traps in this case as they are not needed.
> 
> Fixes: 54e1ed69c40a ("net: lan966x: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
>  drivers/net/ethernet/microchip/lan966x/lan966x_main.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
> index 2635ef8958c80..318676e42bb62 100644
> --- a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
> +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
> @@ -479,8 +479,10 @@ static int lan966x_port_hwtstamp_set(struct net_device *dev,
>  		return err;
>  
>  	if (cfg->source == HWTSTAMP_SOURCE_NETDEV) {
> -		if (!port->lan966x->ptp)
> +		if (!port->lan966x->ptp) {
> +			lan966x_ptp_del_traps(port);
>  			return -EOPNOTSUPP;
> +		}
>  
>  		err = lan966x_ptp_hwtstamp_set(port, cfg, extack);
>  		if (err) {
> -- 
> 2.34.1
>

Alternatively, the -EOPNOTSUPP check could be moved before programming
the traps in the first place.

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>