Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp2973061lqo; Tue, 14 May 2024 15:49:18 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVVbG4IWhowCWPkyxZdYWAxP2xSN1RUbpeRukQd+9yxAmWE93XJmqIkkrzKtJzAtLsqDyFZwC94N2s5qTod2KpVpxNm+XA8qo8lIUmPgg== X-Google-Smtp-Source: AGHT+IFGATcOW4JgtL8BpGPcRgjX17A3pKyF0GK+qtCALGZdJKV+/5C6dJjg6mXLVBb4VQ0kdHIw X-Received: by 2002:a17:902:704c:b0:1ec:71f0:4009 with SMTP id d9443c01a7336-1ef43f4e355mr175947735ad.53.1715726958213; Tue, 14 May 2024 15:49:18 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715726958; cv=pass; d=google.com; s=arc-20160816; b=VmqZ1uw6P1l03+P0qp4mzlNaj5awb/ACr389K4NqP6ZLluYajwFPjEVOjzHLxP6Fpn V/OS7RAR3nnhqLDv2qqcrzF/M2Py62EosBNlIku/obA7uQlu3wWGWo3kWjWBlim2zJgU D7dTL4dDF2hVEhZEFQI573XNWxiy9PmXi8nA29yDhwpVg+Hn5tRcagdIe62W+qKubyY+ iF+a+7K8hEy9ihM53jIgBqMHJRF5/IuzFWRM4x3P23jylrLh0UXWu97U4/L2BsmNELay 93Ifov2wU83WX36k6QehTviU39bEB3oZbSP0+k+KfFwesH0E7qiHITCV+0kRTvfp8AC8 TfMg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=GUJPFVJdz44IFmC7tap3c4+RPSoDFQyAX7g5ibPkXFE=; fh=kPSnuO1ZSD+1qWvhXTw75BA0z2UhMfNYZnG0hfnABks=; b=oCWdjhUajnQi5GDN8r10mKX3Zbf/9ixHQk4Xpb1SFNCoE1/SwRVjnuFpt9sq4RHs/7 AFPZC6EFDQLW7iJz+F7Cb3RuYvLo7AdqFA/n1aqCroHRJjsWEekRlBRHnWX3+SrCydO6 0AZsHhldl/zE0mcjHtXmqPqKcQicRawWOJbuYFXj7j11J4XjGHwzKCjeplZ78N7pk3ZU OtLxmBhwlkRoU6m//ehernfhg1TgsuXpxfEBa8yRs/XN12ntxuIei3FnDYX665dnqH9g r4aHkDAJqH5A6yHh3fGUMr1Fs4JbDwTMOKu8qFa+cDtd+/tbxAkDMCLRyD4aEAgzBNRn AwKQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="EU402y/J"; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-179240-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-179240-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id d9443c01a7336-1ef0bad8457si119006985ad.177.2024.05.14.15.49.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 15:49:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-179240-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="EU402y/J"; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-179240-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-179240-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 365DCB20DD6 for ; Tue, 14 May 2024 22:49:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 95AC4182C8F; Tue, 14 May 2024 22:48:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="EU402y/J" Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A11A181D1F for ; Tue, 14 May 2024 22:48:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715726935; cv=none; b=hStN4n9m0U8s6CPEy1bgZQFJaVmKATyhLwYwykJ8n7fiw5KU+MM5hoXC2uKhFKgCCLyKy4T2dvqOAxSROzY9TpQ98HHN831/KHViazMbR7/hFpTErg+e4Ddy9BWzuK69km9t7ypxA3MI0VMbq9sbrRIyRb+8OI7vKTqhFedpsGw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715726935; c=relaxed/simple; bh=0nhAafwxI5HWL8JnwaWyPULuU+OENNhkR2+xS32Iz2E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e9E/FwyI/LVeoWTHgIW6NjSS15+SR8z9zT5q1QUzN8ztaUEX47lxpAap3Kd+5fo0IWv08CoeUB/dFtV2OGk1n8pmnj/pkm/ZxP/GF648UoyrMA0sQ+pk6/jQAgwnxJGOH9/rJ4d5LPEf3spvwPlGTD1R8ldwCdt7kK6aWU1WNMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=EU402y/J; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6f4472561f1so5620839b3a.0 for ; Tue, 14 May 2024 15:48:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715726933; x=1716331733; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GUJPFVJdz44IFmC7tap3c4+RPSoDFQyAX7g5ibPkXFE=; b=EU402y/JKIyMJuAB2SE8tcVmdT2F5hPBKtJyOcXjOKjuC0bi1A+jvE3BTYF8SihD33 bOUs8cLbHJSVey7GGLQdKIevzMcEEmYsXn4AHOZiahg7p5gbWoEcA54SWJCXn2s/4NPK 0VwFCmJ2fNMkhgpbb9l81RK2iAZ2l7dgAPs0Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715726933; x=1716331733; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GUJPFVJdz44IFmC7tap3c4+RPSoDFQyAX7g5ibPkXFE=; b=daM0I3h/2lOygqDUlTmNzut2qSuvGWeKUA7cawZZc0tCPFe99YhIhc1wIi+8fyvQyb SyJq+fZssQEOuY15MAPDoOa1HCV/aKqLdn6nqkddnSN7FaZWnE2BwhRRkrDBrHG+mFGo pXypRj6bF0EPOxF9Hnf6nbhlW9A6dyWCQH/jMmQThF+Uc+CKHMvUThXN0MQ/wgaiOEKz /erjRFS25vhMymJk9AzGfyw88dL7Xmm3o0I1mPAIEB3LSNqO3IiWcVuU9vCleEB992lH R4UFfhgdjazal/JCzJlx3B/HMsLLieewPeIM1fU01PGX2HuK7p3Dls0GB00tYu/qOFLx Ugzg== X-Forwarded-Encrypted: i=1; AJvYcCUVOAGmk9w+OaNr8Y/XN6ayA0m52HPB2G22O91MLCZuvCoPtDTLQRBOjBwqb3j6nbBoTV6nthCB/jbfEliLDAHF3YDAEJRojf01Or+w X-Gm-Message-State: AOJu0Yw6am1aa42KuI9ehG16oRBSDac55iu8ZCFxBSLLwZnoN8oJaaJL Tn0gXVg6Q9sL7K0UmNv2XC8WTOuffIUlwkrTzzkTVuAcVuCVNZYqWo5aY0WsCA== X-Received: by 2002:a05:6a20:244b:b0:1af:dd56:76f0 with SMTP id adf61e73a8af0-1afde0b7407mr22397136637.22.1715726932891; Tue, 14 May 2024 15:48:52 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6340a6327besm8838766a12.6.2024.05.14.15.48.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 15:48:52 -0700 (PDT) Date: Tue, 14 May 2024 15:48:51 -0700 From: Kees Cook To: Carlos Llamas Cc: Mark Rutland , Peter Zijlstra , "Paul E. McKenney" , Ingo Molnar , Uros Bizjak , linux-kernel@vger.kernel.org, kernel-team@android.com, stable@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH] locking/atomic: fix trivial typo in comment Message-ID: <202405141548.E76E681@keescook> References: <20240514224625.3280818-1-cmllamas@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240514224625.3280818-1-cmllamas@google.com> On Tue, May 14, 2024 at 10:46:03PM +0000, Carlos Llamas wrote: > For atomic_sub_and_test() the @i parameter is the value to subtract, not > add. Fix the kerneldoc comment accordingly. > > Fixes: ad8110706f38 ("locking/atomic: scripts: generate kerneldoc comments") > Cc: Mark Rutland > Cc: stable@vger.kernel.org > Signed-off-by: Carlos Llamas Thanks! Reviewed-by: Kees Cook -- Kees Cook