Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp2974030lqo; Tue, 14 May 2024 15:52:31 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVRYtFOYUd4eYYNtxGow817ExnZY81C7Zjy8SpcEdI3SnFmMAwGr3tEEyH0dFR4bx0godrWjo9UNL9OGHd7l+fxD2L4s3H8NFm2oo4/mQ== X-Google-Smtp-Source: AGHT+IGjgQwy6I2/xURje0IKtWVCEEdK9VsZe4Y2i4bQ9HHlx04YayeOpMV8WuAu03sJpVe/PtSa X-Received: by 2002:a05:622a:1b19:b0:43a:712a:bb97 with SMTP id d75a77b69052e-43dfda8cf19mr208994841cf.7.1715727151691; Tue, 14 May 2024 15:52:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715727151; cv=pass; d=google.com; s=arc-20160816; b=sMxTMP9YP2KobxJ6IoMq+w6zrzIizDnUiAKAPSFJohOaF/IM0g8nMr75v4PpcDidmX 7QXzXKFKqOZT4O7KzgzteNYFvlPXhAy+n+aUgm1NDYEpIfov+8grOEMTa9lUYBYIxzDI hjycXOPfWzsHTn/gAYewMBWWSsPm+NSEnCX1YyGxsBrILQ0CO5LH8H/XANEMz3XvXJ4j QutWXdJLHArwxr5a0tU+aze1yOaf1jXgmBzSDPhOQrTO19nIaa4Y5yUUvmJ0eNjxbimC 1qc7l6ncH3INUIXPsxnBZInawfQpefwJYNFollKqnb7mQXi0EDeF/qsbOaJe/0EhkeAh RCqg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=doHLoOzkV1dAkjUvPPZHC9iFmwa5zDfo9zpyMOeSinc=; fh=kzsv1aiH3Uu9vxxaWxX7SVWYFWNERxYA2BR46GnJEWY=; b=hOkIQvAqbhNY0rAP9au9cVEXB1NqbGHLt4hZK5j3nkn4YICm8sK9X9nemCkuN5p/Ly vNqlDA6jM2PZbQrgAtlA9AxeDQXFfPUxy9cfoky1xKWuX9Zk0FpBSCT/aAjx4Ea5FHxQ rSAGfIrlQGv8KeAx7J3aY6Gs19Iyeh/FWqNnwtg0iOzd7AwtWu/tbZWahUtW18jsJpGH FW2fGpQ7xha7PqiuvQXdWMV9OrkG4NHnyV/zw1W6mCpot8XgFwYnMTngu+1lOlZiHief 50DMWbIf58UqCNiqZxIlnQOFL+q3JiWz1xdf54qBVePlWTPXBdj2wJcWQSxRvcx/k/IC 99rw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=cehaMXCZ; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-179243-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-179243-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d75a77b69052e-43df549f67csi128431031cf.37.2024.05.14.15.52.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 15:52:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-179243-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=cehaMXCZ; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-179243-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-179243-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 833AE1C210F6 for ; Tue, 14 May 2024 22:52:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AA230182C8F; Tue, 14 May 2024 22:52:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="cehaMXCZ" Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94CE61DDEE for ; Tue, 14 May 2024 22:52:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715727138; cv=none; b=l13RtKEBmPGKh3/xx7jfnPFnnTLNTd4cS+t3C18ZKCCo9jelHwJhQ3xefH54KzOJekDikS1mB2A8leQujV/PLRd7HI0L7hSdjN+YdWIKjt0UZUwQUUt4LaOn/2WiRCj9/bLXDoOWqCGkyqEAlEkKuEuOlI97E3TBuKw2v43j5wI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715727138; c=relaxed/simple; bh=0qQ/sc8ONfKMIFEbDmEeKbk7hGENEC1CjPvuVVbodHY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=RDVL+KEhkZDK8QYPbwQzqP1faqReSO6nlfe/jV3lcU+QH6y60zR3LBNLNSq36Z/ljARnL24asx+DT/s/fYRIJsd2hZoMPJr81Ild5Pw4TGEe2mX1WOWsw8fDnIIwa04yyuRmWC5t63smsPV6NxNq2JW09/nBIl+r51LH5DSEfbA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=cehaMXCZ; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1f05b669b6cso34172975ad.3 for ; Tue, 14 May 2024 15:52:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715727137; x=1716331937; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=doHLoOzkV1dAkjUvPPZHC9iFmwa5zDfo9zpyMOeSinc=; b=cehaMXCZsoHjkoCKuFRGlwA8Pol2JIcmEEQ5QYIN5sX133TQ7eYmIa4kxehoHZniWG /2F7Vdo77mOz666RMRHPSyfwGmyC/mb2qdoGmyo7R7+xdHnANd1Ke8h3h+JOwvZtlyBm N7lOz+uxMjMaMTOIQ6e72M5J9Eor8nCs2ec/4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715727137; x=1716331937; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=doHLoOzkV1dAkjUvPPZHC9iFmwa5zDfo9zpyMOeSinc=; b=HfaygOH4q6ImkEk9ixvum6oSm046MCyxqizOLrAnb64nG8gVRDxPV2SsTc3EcVYOuF geic3sENOjUo9ZtwLXhsXEavF1Wx0kY7ALQXgJL/kpwNuiitV0OZanRpfMqHJbbwZdNa v7S0/maFP+TSEv86qxpL1mwLBL3SqIGYGDt83SUDmdvrm63GDPKtHulIqOu5sYDdqKVE AVGY22D5oBI/zR4CbfIdxkJiwCxEiwW7laxkfvYGrpvP2bhxKGZK58NSBmiecLQjkX6P OeNWB7YHp4eyuNeVj1JjoJ2X56ozkPqJXzG11SP3O7sovi0abMaMvx4RyIV4Sedo1dsi f+BQ== X-Forwarded-Encrypted: i=1; AJvYcCVCcGtvM1tc3C1M2OS3u+D209DDAVazs4n98Qc8JZmfqaYSJpMo9Qdt1GsrxM/CD4dJzLtkwqgWTGCmotRtpy+ywG+NOApJClD+wrxx X-Gm-Message-State: AOJu0YwoTp68o02vOHy+CMTdIpkc7y3tNS0lPY1jGcn9OL0jfkfM8zqy /oeVsFrbKGMu91PCakaE5OqbfCJcghnbXzvPI2szI9wmwMIyyrDVNvic3Vivag== X-Received: by 2002:a17:902:8f94:b0:1e3:c610:597d with SMTP id d9443c01a7336-1ef44057ca0mr125104875ad.60.1715727136930; Tue, 14 May 2024 15:52:16 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bad886csm103974935ad.70.2024.05.14.15.52.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 15:52:16 -0700 (PDT) From: Kees Cook To: Paul Moore , James Morris , "Serge E . Hallyn" , Stephen Boyd Cc: Kees Cook , linux-kernel@vger.kernel.org, patches@lists.linux.dev, linux-security-module@vger.kernel.org, Dmitry Torokhov , Douglas Anderson Subject: Re: [PATCH] loadpin: Prevent SECURITY_LOADPIN_ENFORCE=y without module decompression Date: Tue, 14 May 2024 15:52:13 -0700 Message-Id: <171572713190.2793228.3146950773342970247.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240514224839.2526112-1-swboyd@chromium.org> References: <20240514224839.2526112-1-swboyd@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Tue, 14 May 2024 15:48:38 -0700, Stephen Boyd wrote: > If modules are built compressed, and LoadPin is enforcing by default, we > must have in-kernel module decompression enabled (MODULE_DECOMPRESS). > Modules will fail to load without decompression built into the kernel > because they'll be blocked by LoadPin. Add a depends on clause to > prevent this combination. > > > [...] Applied to for-next/hardening, thanks! [1/1] loadpin: Prevent SECURITY_LOADPIN_ENFORCE=y without module decompression https://git.kernel.org/kees/c/bc9316c14441 Take care, -- Kees Cook