Received-SPF: pass (google.com: domain of linux-kernel+bounces-179255-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <87seyk2dmh.wl-kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH RFC] ASoC: amlogic: do not use dpcm_playback/capture flags
In-Reply-To: <46daae9b-10dc-4f49-8a25-c387d03ae87a@sirena.org.uk>
References: <87o79azh65.wl-kuninori.morimoto.gx@renesas.com>
	<20240514143116.3824376-1-jbrunet@baylibre.com>
	<46daae9b-10dc-4f49-8a25-c387d03ae87a@sirena.org.uk>
User-Agent: Wanderlust/2.15.9 Emacs/27.1 Mule/6.0
Content-Type: text/plain; charset=US-ASCII
Date: Tue, 14 May 2024 23:11:03 +0000
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?eAkVOj3jLv8VZfNn7i4vSYxU0OIZSJ8mg08aMHBNkEe8LxsyNuHwqsvRcdko?=
 =?us-ascii?Q?xApnNGyunsqsBujezydXF5ppAD4J7PQdFBvYzeRNX+kOxH80yBPPb93OIFTH?=
 =?us-ascii?Q?XV0JUHPTKcEk/tBWXRbUG+fBJBO3kfBvnimo87nxqBokaCe4K1SxxGwlOLvl?=
 =?us-ascii?Q?xyJHvkTuIxwMAPNjhQAWaH/x8r4GsIscVHW0xZMV5W/LcmvuEdlKeG/Mmtu5?=
 =?us-ascii?Q?o2TNrQ95/q54FHMhmU7M+ToR/pqaX/DYLGDnD81yuTnS0RCblrBv8OiiakhC?=
 =?us-ascii?Q?NjtvHpOppU3r/oi4tcZasXNYBB2CKsW1kFNX6ohLsG3ACuWk9uvB27+/IZBR?=
 =?us-ascii?Q?WO0eC2Oqu5e81UH2rAT8yi5Vgxm1sYXFxiksB37kp3MSIUr6zGwF7Zqbcr8x?=
 =?us-ascii?Q?78TvfeDqBBwyrxX/yArdxDFplZOBEBZlOpUU21dhMtflRKg9N0vJ6k2JtX8E?=
 =?us-ascii?Q?xwpBWY4/UanVVxhlhOeOCRU6rMm3jsfpdnNrnEKB26du+sAoNY7cYgtJ05+y?=
 =?us-ascii?Q?cy8zJvd3QLP5c2wsuAuLDRn+W2Hjc0Ev/REQnzV+LYVqCBbRqo0brxu/Dgpv?=
 =?us-ascii?Q?90gnTuer6vgch6EvK6Xn3rYzQqGTLd/Rj2jTLZe3IocQH/dAmbGCOQdZgT77?=
 =?us-ascii?Q?PxCgXhNvt4Sg9rOD8GluKYH48FhHSPrUUMdM5UAU6N72ddWxSzn9ICxFj5eU?=
 =?us-ascii?Q?2ycLv3F6DEukbZ9Bs/7JDkTRK/fm+vJ1Gv+Y43+WR9lt/VborOgJ94QbBacf?=
 =?us-ascii?Q?4YJQik2Ao5YTDcX7NQXM1bZmLFBV9LkKDyvJXq1b55HGqiNnyh+pXcXLeR4b?=
 =?us-ascii?Q?v7xL0iNYPpwKrmsOO1lx0rt9OSEg8ASnUHQc/MlYAOT17VmOktj6vEUr2EA8?=
 =?us-ascii?Q?/iS8dFhTNW6oM/9RI0tcoUZlDBaYBcj8Jx7C2mFXjgdbJvIttG58hzRiNZYK?=
 =?us-ascii?Q?Ohuqugm5jOJhYt9j5sCyh/jMG6t6kSpbaq/gl7lDGb+lblFQVyjbJd3qfB63?=
 =?us-ascii?Q?QtvGwYZRgwTwOe35xhawHKTecbYb1WC3p7RPdUpwAuwuxBQusRMeEi6tTwlP?=
 =?us-ascii?Q?QVwSEvo4pMB0xwd5FFj3ZYL3xljlyKU0Xh/M4OtgNkP9EY7aye/pyLd1EjC2?=
 =?us-ascii?Q?VShKrSGmweplsTPfr39pq561JLLATFGE/BHSLJ2oHpmIafhqWK8oEuZy0tV+?=
 =?us-ascii?Q?UiL8t4l/R/zzKcYiM20+XTFhTxsuWGYBHvM8p9CVumbH/LG8tBeAo9/KHJrD?=
 =?us-ascii?Q?Zmia6Td1BBWyzivDyrSL6ANWQD6qxa+eogP0Lg0+Z4cBFSOva4Ne9rh//7xP?=
 =?us-ascii?Q?Si2Iv5DXF9ZIVUizzi2e3TtUHngeGaBDpNob4DWjFqDnK5QHJGfXub2qy/vf?=
 =?us-ascii?Q?h/QRndABIK8/WpSYKHdooxv7ZhO9kSjUHBfM+4c7065P6cVXf9Bx8a5mt+/Z?=
 =?us-ascii?Q?tceYulEdi4Esf9ubcjyDJwrnAYcs+UzfHobnERazmS6TutZaSPg7Iz92R57E?=
 =?us-ascii?Q?rv0/kh23K8tJWiA4YpMMDi6WqRxi/0mrDNgtGp/ioawvzr7czalFIGEpY0x6?=
 =?us-ascii?Q?VsKG7kmu9j4cTl6NPufUn9sP3lm9VFe7yQDF0yU0XPAPemZUDdvf49QMlZvm?=
 =?us-ascii?Q?GFuxj17iPYTaGfNTp2Qb6Ec=3D?=
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 952dffdb-697e-463e-7b65-08dc746b2043
X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10914.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2024 23:11:03.3040
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Guv4CSvwZgKIO6sRHDEs+hL1CyH0OR3P4OzzCitwUaN9K+vsBZidVTV/rBKA62yQdfwuN63hTxSccp+YR0c5urZlF2UgAx2ba3rAsbT9C17BgK1ZaHSnssy+nA0PZ3sR
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYYPR01MB7024


Hi

> > dpcm_playback/capture flags are being deprecated in ASoC.
> > Use playback/capture_only flags instead
> > 
> > Suggested-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> > ---
> > 
> > Following Kuninori's series, dpcm_playback/capture will be ignored.
> > However, properly disabling stream direction is important for Amlogic
> > audio drivers.
> > 
> > I'm not too sure how this should be applied to avoid breaking bisect,
> > before or after Kuninori's series. Maybe it should be merged into it ?
> 
> Probably better to integrate it I think?

ASoC needs dpcm_xxx flag *before* my patch.
Your patch is replacing it to xxx_only flag, so it should be applied
*after* my patch. So integrate/merge is good idea, I think.

Thank you for your help !!

Best regards
---
Renesas Electronics
Ph.D. Kuninori Morimoto