Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp2991935lqo; Tue, 14 May 2024 16:38:06 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWjms9V7KYyfeFhLYoGAnB2vLW8B4zOymwzle5BMBEUasCS76P7wkIIi9Wu5cAIpGT5vkNrSdvEiEbhUzMcj3IYcSHIaJi80KrD7b3XSg== X-Google-Smtp-Source: AGHT+IHxPoLZRFs6id9MKEFGrmyBmKxO+gIRTn/oUbHiwK+tgoJ2/yuXCH2PFqtdYDscOsvqRTuL X-Received: by 2002:a05:6e02:12ce:b0:36d:b36e:3c6d with SMTP id e9e14a558f8ab-36db36e4345mr21500715ab.10.1715729886296; Tue, 14 May 2024 16:38:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715729886; cv=pass; d=google.com; s=arc-20160816; b=GDH8zJEz/7EHxsYa8nJX80O97W3cavbuGWrAlEz8UGm7IornyHBijXgAUbj4AQjGYm nfwYas5e0CplhndNb0Ovyu7lvUYyvk3AxMZ1Fmi/gvduGjx3bZ7Ia2K5KVn0W1ZSEAr6 DQrqB0PQgzrVMXUmgP2q0mhp9gAZk0MTrh6rQt2O+8sjOczfQWfTq6QEZOKXnPzBUiDi duskGw2i4Xa8f8IGypMy5jEgTQuLpBG0wDHT09t3Y1nkBjl1y76qEFJPmI9dW01NhEEQ 09m0VpnWVDLCwKRNaSrmwFT2v37wkT2AAFUkIdD7pTrwgM2P+6YN3xMkLVPMYePWXlVI sYMQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=U/46gzPRjfsjywIh4JZDG9x4PubRXzjsJhZrxZRHzS8=; fh=6St2DPioluV8GpcPAoXs1zyI8ban0eMZoTt/KqOe8VM=; b=yJtCNn/Hw4mn64tt4OCIybISGW5gLAJQEISnUluRFAL/v7TSWCxVZDC/YaIuENpa1B OdRKdi6pWEekfVHmLpjPIkZPGB2JJnYVM2umCembnsLv5zQZWDjkLjeVe9le8xmmn75I a0v2CjcvOeeof8Tor5y1ZVvpalfSS0pe1TWzle3SKfx3937SDo9lZ2TC+X2pX2gbDjK7 x24ajs8CWcWjiuY1eJEJV8LPFTqp3OY4/z/WYMLRnjWk06ezhQL4cUyr93z7EmfrQ+Js uLmU/r8pFe5fqbzdTb38V4T8K1JkF68//XSR2+SLgvPJvcsXTqRtSy67b2XuSb3gfTk4 8qgA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=XMRYHZwv; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-179261-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-179261-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-63409e82365si12293852a12.69.2024.05.14.16.38.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 16:38:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-179261-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=XMRYHZwv; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-179261-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-179261-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D376C2823F0 for ; Tue, 14 May 2024 23:38:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F0BBC182CA4; Tue, 14 May 2024 23:38:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="XMRYHZwv" Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFA0F13D619 for ; Tue, 14 May 2024 23:37:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715729880; cv=none; b=k/mAfWAsUmwVGEPCYtw4jPIW2uA7JF1YW6uCrf71FKcqOF7NkLOxWWtrdDhs3TUjM7ARrzPrtNDBw4rcsJOzr1RDbFxqlZCeYiq7uHyYN3VNmYaQcTCoJY5zEvVd2i3dSByonj5Gz7yzY9Lb33bCXLAIbganQDSnb8wxxCGaBRo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715729880; c=relaxed/simple; bh=M0ojsRsGu00hlS+3D/N7mtRoW2fXDtGb0dL7Dj9nSEI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=BbGgiNcyQTBMX0kDA46Q9BNqQOBiRpVdYXKMSXC3ul4VfmvRHeNNO8brQSydqHwDElGgY/1vBSYsPyE7RFOELRwZKg3Snb2wjiHwkHMMRAqNB3NumoFJxxICeOXidOXKC1fKottEQRh9WZ6FaG7Bcent1rsDd+Gfht7kuDAOYX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=XMRYHZwv; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6f44dd41a5cso6157156b3a.0 for ; Tue, 14 May 2024 16:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715729878; x=1716334678; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=U/46gzPRjfsjywIh4JZDG9x4PubRXzjsJhZrxZRHzS8=; b=XMRYHZwv1mBGvBcx6lSEfGBbDW4MMi40t3slgMuu4Pp7Wt3luR+mizh03LmcSf85ak 0dVF6s7MQ6VoRzzYEJCkcKS45zOkai1q9OCU4pp+2FqaeaW18bI+ZN9TjjuODgCtMWIy U28Z+B7RIOrtCDbP1zF1L5ovEGmzzBPApfGLA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715729878; x=1716334678; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U/46gzPRjfsjywIh4JZDG9x4PubRXzjsJhZrxZRHzS8=; b=gAJjVrbiAMvMeRsFDyP27KDgL/gvkRBaTAiqSEInRnOadutEZgX/ZpMriYDGQHPV9l SIkOFt/M/Ts2JxmJQ7+ZJJA/u41VP6YKN/N83FGl22UZPWiWHQa6Idqt1EaYdlp/Q7MA QBiLBYSDHFr0VjRkrTGalPybgNV2XlrL9B07hKZLF91JkAyDBllqH7gC3cN7bGeY6YyR yo1IKZFiBK+xZZrJdT8hCqekidwOwz6atvNAS9nVIvK4emvPou9/Tcxra9AFAgTHWXWH V6kZU2I/VYB/iiRWfH1XdQJNWP+tE8MQkjWFJd5a+qutkle91UixN0JKSWrmbBL5AjAO AXgw== X-Forwarded-Encrypted: i=1; AJvYcCW+xH50DoFAJnMxtKo0ZfMtoKBpEe0W/sSfuj93J7VAChq1wESmeZN101ac/VVAWaK5wgEBGuoIDBspdPnEI4hTyca9GQMKUEkifO8f X-Gm-Message-State: AOJu0YxHyrI7rKzZlCYhjoFyFhr1aQl8d7dX9IkuhojIkblnYjTCBuUh RconAe59NI80woayGn8qUCz0wsWHdMMOzfBrr5uSjDhNjCwcDKcjVh7X42GaHA== X-Received: by 2002:a05:6a20:9782:b0:1af:ab0b:1c08 with SMTP id adf61e73a8af0-1afde1b6f80mr14140701637.46.1715729878103; Tue, 14 May 2024 16:37:58 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6340b76e262sm8858679a12.35.2024.05.14.16.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 16:37:57 -0700 (PDT) From: Kees Cook To: Masahiro Yamada Cc: Kees Cook , Marco Elver , Andrey Konovalov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ubsan: Restore dependency on ARCH_HAS_UBSAN Date: Tue, 14 May 2024 16:37:48 -0700 Message-Id: <20240514233747.work.441-kees@kernel.org> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1157; i=keescook@chromium.org; h=from:subject:message-id; bh=M0ojsRsGu00hlS+3D/N7mtRoW2fXDtGb0dL7Dj9nSEI=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBmQ/XL0cMiBAzkKwdeLzy9N0TrgLVfExeGQZ0JN BHF7seFPsyJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCZkP1ywAKCRCJcvTf3G3A JgcVD/wOawyFjlRnf29/qod98RqXmvKGYR/z9gCakCBi8CxR4/Svp5cc0T+1pQzJxoBBpejCMg0 pxH/ab2G44oXnSULaNGapGZ9ntp42d7DnWiaGdghDJs4jq3mBvhU0185EFH6k8FjNeio8qOlkzv LB+qmxeol6rTzNUICQEJtpC7MjGXDrI/JUqDk1fZv6ff4wyQo98trBnhME4QDzoTGzodcr85+MK seSwVJg6ecBebIIFhz3DVVzIJnNxeMxEnZpTEssJLlImhYpeycEbBFSR2zDyTvse/FGdwy0pUFK QM4cI+mh8yFa/+zN3C68no7tg2X4sBU9dMnRmQbj9mASW8Sb0QSnWVxY3v+5RlMTtESHi/17hNW rrv7je0gK4u7WSLM2ayMhcVuGBo6QNx23Jl4PnB/3ONTkgDdcPszSp0ZPMC+ZxifMJF1myji/kE JhrrIhEKljsD6Di1P0ATy6w3ZgKnqu0lFKIGkOetXWIFTOYefwC1q4MH7b3xDklAqAlIsBvEaR7 1aQCDkbTy/0YQCvK0n2IUMBrFXZR3VYLlbk9MzllZAeApJm3Hv9Kw1O7MDrj9bViSqrlzXNA2H7 OBDGcCh6D4DMvDBgFJO4rmlnrgsvq0AgWoOTzGdS8A0pH9fGFC06u3z1Jj9A2K/lntAbCWi1qKp 9P8N+ld MNH39rig== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit While removing CONFIG_UBSAN_SANITIZE_ALL, ARCH_HAS_UBSAN wasn't correctly depended on. Restore this, as we do not want to attempt UBSAN builds unless it's actually been tested on a given architecture. Reported-by: Masahiro Yamada Closes: https://lore.kernel.org/all/20240514095427.541201-1-masahiroy@kernel.org Fixes: 918327e9b7ff ("ubsan: Remove CONFIG_UBSAN_SANITIZE_ALL") Signed-off-by: Kees Cook --- Cc: Marco Elver Cc: Andrey Konovalov Cc: Andrey Ryabinin Cc: kasan-dev@googlegroups.com Cc: linux-hardening@vger.kernel.org --- lib/Kconfig.ubsan | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/Kconfig.ubsan b/lib/Kconfig.ubsan index e81e1ac4a919..bdda600f8dfb 100644 --- a/lib/Kconfig.ubsan +++ b/lib/Kconfig.ubsan @@ -4,6 +4,7 @@ config ARCH_HAS_UBSAN menuconfig UBSAN bool "Undefined behaviour sanity checker" + depends on ARCH_HAS_UBSAN help This option enables the Undefined Behaviour sanity checker. Compile-time instrumentation is used to detect various undefined -- 2.34.1