Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932710AbYAaKSi (ORCPT ); Thu, 31 Jan 2008 05:18:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752815AbYAaKS3 (ORCPT ); Thu, 31 Jan 2008 05:18:29 -0500 Received: from ecfrec.frec.bull.fr ([129.183.4.8]:53466 "EHLO ecfrec.frec.bull.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751934AbYAaKS2 (ORCPT ); Thu, 31 Jan 2008 05:18:28 -0500 Message-ID: <47A1A076.4060108@bull.net> Date: Thu, 31 Jan 2008 11:18:30 +0100 From: Pierre Peiffer User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Nadia Derbey Cc: linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org Subject: Re: [PATCH 2.6.24-rc8-mm1 05/15] IPC/semaphores: remove one unused parameter from semctl_down() References: <20080129160229.612172683@bull.net> <20080129161758.154775218@bull.net> <47A187AE.1000809@bull.net> In-Reply-To: <47A187AE.1000809@bull.net> X-MIMETrack: Itemize by SMTP Server on ECN002/FR/BULL(Release 5.0.12 |February 13, 2003) at 31/01/2008 11:27:08, Serialize by Router on ECN002/FR/BULL(Release 5.0.12 |February 13, 2003) at 31/01/2008 11:27:09, Serialize complete at 31/01/2008 11:27:09 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1874 Lines: 56 Nadia Derbey wrote: > pierre.peiffer@bull.net wrote: >> From: Pierre Peiffer >> >> semctl_down() takes one unused parameter: semnum. >> This patch proposes to get rid of it. >> >> Signed-off-by: Pierre Peiffer >> Acked-by: Serge Hallyn >> --- >> ipc/sem.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> Index: b/ipc/sem.c >> =================================================================== >> --- a/ipc/sem.c >> +++ b/ipc/sem.c >> @@ -882,8 +882,8 @@ static inline unsigned long copy_semid_f >> * to be held in write mode. >> * NOTE: no locks must be held, the rw_mutex is taken inside this >> function. >> */ >> -static int semctl_down(struct ipc_namespace *ns, int semid, int semnum, >> - int cmd, int version, union semun arg) >> +static int semctl_down(struct ipc_namespace *ns, int semid, >> + int cmd, int version, union semun arg) >> { >> struct sem_array *sma; >> int err; >> @@ -974,7 +974,7 @@ asmlinkage long sys_semctl (int semid, i >> return err; >> case IPC_RMID: >> case IPC_SET: >> - err = semctl_down(ns,semid,semnum,cmd,version,arg); >> + err = semctl_down(ns, semid, cmd, version, arg); >> return err; >> default: >> return -EINVAL; >> > > Looks like semnum is only used in semctl_main(). Why not removing it > from semctl_nolock() too? Indeed. In fact, I already fixed that in a previous patch, included in -mm since kernel 2.6.24.rc3-mm2 (patch named ipc-semaphores-consolidate-sem_stat-and.patch) -- Pierre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/