Received-SPF: pass (google.com: domain of linux-kernel+bounces-179349-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <768c3e38-724a-42d7-a51d-16044bc69ed5@gmail.com>
Date: Tue, 14 May 2024 23:29:19 -0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] nvmem: meson-efuse: Replacing the use of of_node_put to
 __free
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
 Neil Armstrong <neil.armstrong@linaro.org>,
 Kevin Hilman <khilman@baylibre.com>, Jerome Brunet <jbrunet@baylibre.com>,
 Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
 Julia Lawall <julia.lawall@inria.fr>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
 Javier Carrasco <javier.carrasco.cruz@gmail.com>,
 linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org,
 linux-kernel@vger.kernel.org
References: <20240416011751.93016-1-marilene.agarcia@gmail.com>
Content-Language: en-US
From: Marilene Andrade Garcia <marilene.agarcia@gmail.com>
In-Reply-To: <20240416011751.93016-1-marilene.agarcia@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 15/04/2024 22:17, MarileneGarcia wrote:
> Use __free for device_node values, and thus drop calls to
> of_node_put.
> 
> The goal is to reduce memory management issues by using this
> scope-based of_node_put() cleanup to simplify function exit
> handling. When using __free a resource is allocated within a
> block, it is automatically freed at the end of the block.
> 
> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> Signed-off-by: MarileneGarcia <marilene.agarcia@gmail.com>
> ---
>   drivers/nvmem/meson-efuse.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/nvmem/meson-efuse.c b/drivers/nvmem/meson-efuse.c
> index 33678d0af2c2..400a9a075e53 100644
> --- a/drivers/nvmem/meson-efuse.c
> +++ b/drivers/nvmem/meson-efuse.c
> @@ -42,20 +42,19 @@ static int meson_efuse_probe(struct platform_device *pdev)
>   {
>   	struct device *dev = &pdev->dev;
>   	struct meson_sm_firmware *fw;
> -	struct device_node *sm_np;
>   	struct nvmem_device *nvmem;
>   	struct nvmem_config *econfig;
>   	struct clk *clk;
>   	unsigned int size;
> +	struct device_node *sm_np __free(device_node) =
> +		of_parse_phandle(pdev->dev.of_node, "secure-monitor", 0);
>   
> -	sm_np = of_parse_phandle(pdev->dev.of_node, "secure-monitor", 0);
>   	if (!sm_np) {
>   		dev_err(&pdev->dev, "no secure-monitor node\n");
>   		return -ENODEV;
>   	}
>   
>   	fw = meson_sm_get(sm_np);
> -	of_node_put(sm_np);
>   	if (!fw)
>   		return -EPROBE_DEFER;
>   

Hello everyone,
Did you have a chance to look at the patch? Any questions or suggestions 
about it?

Thank you,
Marilene