Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp3084526lqo; Tue, 14 May 2024 21:33:05 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVpAo/27TqJCMi7pSrIhWLqABTOTGe/y7yUnC9O1fimGzL5okVmpT5hQvxihi9xjV4iiHO5+IvIISNi5lwvKf5W7DIyRFoqHI3yH3xdOQ== X-Google-Smtp-Source: AGHT+IFhSywmhSKTyqDqmZHxXfcqLYwtPUgheh6pbQyeEX5IR9IH5OrjhN+ELDk7cYRixVWiSQy/ X-Received: by 2002:a17:906:da8d:b0:a5a:7a1:5da3 with SMTP id a640c23a62f3a-a5a2d09e4b4mr1442401766b.0.1715747585768; Tue, 14 May 2024 21:33:05 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715747585; cv=pass; d=google.com; s=arc-20160816; b=PbgvOzeIR6QpE/25FE0q3SZrA2lvYMI1+IXPA8IdY3edazk4V9jsq1L1pSU/Q/2gkf F2FZJ+en82kfoqo5itTuznjISxy1lKzvHkdBF1KTJLqCKTVayi0BdItzsoBLOvGTq4bb XWA81z9y1ubT2c3yE/pD0q4g8m66r1ezxAnEMLlM4uNj+51ECrbMK5OR5v6L9qXzpnIG ofJTUNApUUs5XZ/xgbCwxHHpeprrh3hg2DyWReHs7sTc6ib3ZNTcpSmZCCnb6We923lZ O9slnvEuCE+mLhIrmPrPAaT5VU7X4iw9pZ3PdEVh1e9oBgc49Bk9GTKeWRXKA8KNwW+k tQHg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=Yo39EB6jrUbAacBHPv9rywt0Ai871FVruWXcOiDl+4E=; fh=WtnaTto4ZRvKl5Cz3jmCsxDotbDWwDn4RKYe643dhis=; b=zr3iMdWeM677JIyIu5piybeeJEVRW8WvxQQ38/F/qc1ZIOnq9mLdaFwZ67jt6kB8gZ gg0k+q4YWpDaylNOdpGMnG/gdPXoT5sGl6Z2Q5AlXtLzU2PK62oJFSTCxqITARQRe1YU CJISWZ2EhVyNufc8i18Q4OBnzdkngtypqsWEa8qMeyVOuhhBuWaMXjY2YcP3irdeKm/6 tpK3cE7c9uqHqmXLTuC47mLgbqCbMQU0WWxPahRvqKzJMbAmzJ+vSwK4NYbstpMEwguv ojCGSihzfpqWClrCFAeWuDR0pdTZvbhcA4ljdi1d2f+yUZO6fH0btPKtpAYN0aO2U3mn iTQA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@acm.org header.s=mr01 header.b=kBXOlXgZ; arc=pass (i=1 spf=pass spfdomain=acm.org dkim=pass dkdomain=acm.org dmarc=pass fromdomain=acm.org); spf=pass (google.com: domain of linux-kernel+bounces-179399-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-179399-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=acm.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a5a17b4c55bsi670707566b.287.2024.05.14.21.33.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 21:33:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-179399-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@acm.org header.s=mr01 header.b=kBXOlXgZ; arc=pass (i=1 spf=pass spfdomain=acm.org dkim=pass dkdomain=acm.org dmarc=pass fromdomain=acm.org); spf=pass (google.com: domain of linux-kernel+bounces-179399-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-179399-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=acm.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8044D1F223C3 for ; Wed, 15 May 2024 04:33:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 32B6939ADD; Wed, 15 May 2024 04:32:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="kBXOlXgZ" Received: from 009.lax.mailroute.net (009.lax.mailroute.net [199.89.1.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB767EA4; Wed, 15 May 2024 04:32:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715747577; cv=none; b=lo3kMGyl/SEu3CoGTfHtGt9uQ6+ZknvrzqM2s97vpTFdS/9ZTKlnOUjrG4PH3CpEHZlsX9rLkLmv7Sfmy/l6IQIUJtOSQJeLVIPKNcdhAtfXB3q4AevpGO2A1eI0TE8cDhs6Azy++Ul9l+a3A4PQjFGagB76L7avxZRn22wnC1A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715747577; c=relaxed/simple; bh=Yo39EB6jrUbAacBHPv9rywt0Ai871FVruWXcOiDl+4E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gfpHAgDs74aD4TyYDZGC+tkFRu3AWh0bZ4ndJvbEwy9GDg6fGUei+i3Vjga+EJFU7VM4t1yQzB7VEMCOuaPu9WMzXxHz46ksUZ+d3a5Y5PvEHfqpihCotyp2MNUjPPQWQ8iF8Xbz9GPk5RGkKdaxNCF+qaEGqUn60wPfa9ZWc8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=kBXOlXgZ; arc=none smtp.client-ip=199.89.1.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Received: from localhost (localhost [127.0.0.1]) by 009.lax.mailroute.net (Postfix) with ESMTP id 4VfL1Y15CkzlgT1M; Wed, 15 May 2024 04:32:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1715747567; x=1718339568; bh=Yo39EB6jrUbAacBHPv9rywt0 Ai871FVruWXcOiDl+4E=; b=kBXOlXgZJAHps4T8aAmKvg5inNn66MhJTttx2fpa uczaUU3WXnsbOu9B7uCN9K8TizsBQojJB7csXtnRiLSMaFSB6TUzBCiGBjqfOA6V QKfDzGvoA8Bt2407dkjBe5LonGcCHDoFRaJujtB1w2w39abpr0NU4GlwscYsa00w V9L+eI+fbMRS5dPBIPZ2nLP4n+oZf0hVj3wSilTPFRxWrSL/fp084w5mgePvgdzR p6VPU0xboUwszMWhgu1jPJgZ3cwk5+blSP2kZYfBEMbUlS+kY3o4lXZYEh7sLZ0N 5Z/GiscBTqkhmhiGlp6nQiVItqY2PElbvO7afVHBVS5T7A== X-Virus-Scanned: by MailRoute Received: from 009.lax.mailroute.net ([127.0.0.1]) by localhost (009.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id VSczGBCQHKou; Wed, 15 May 2024 04:32:47 +0000 (UTC) Received: from [172.20.0.79] (unknown [8.9.45.205]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 009.lax.mailroute.net (Postfix) with ESMTPSA id 4VfL1V43gMzlgT1K; Wed, 15 May 2024 04:32:46 +0000 (UTC) Message-ID: Date: Tue, 14 May 2024 22:32:40 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] scsi: ufs: Allow RTT negotiation To: Avri Altman , "Martin K . Petersen" Cc: Bean Huo , Peter Wang , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20240514050823.735-1-avri.altman@wdc.com> <34c50f23-82dc-4b53-b8cb-e5c07c6e0106@acm.org> <0300cd4e-46d6-499a-98d5-72360c94ae49@acm.org> Content-Language: en-US From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/14/24 15:07, Avri Altman wrote: > Bart Van Assche wrote: >> My understanding is that the above check won't work as intended if >> ufshcd_rtt_set() does not modify the RTT value. Wouldn't it be better >> to add a boolean in struct ufs_hba that indicates whether or not >> ufshcd_rtt_set() has been called before? > > My intension was to not override RTT should it was written, e.g. from user space. > As this attribute is persistent. How can RTT be written from user space? There is no sysfs attribute for configuring the RTT value. If the above refers to a mechanism that bypasses the UFSHCI kernel driver: I don't think that we should preserve any configuration changes applied this way. As an example, the SCSI core does not care about configuration changes applied via the SG interface. Additionally, what does "persistent" mean in this context? Thanks, Bart.