Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp3093308lqo; Tue, 14 May 2024 22:03:19 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXeRyJbmhLiIauwbG3za2ML2r1B4iZ5ZU8MGY2r/5uu+gLVTmMlH8fIwF4xLNOGG+KCGKMepMGfh3ahUzxLGbiQHhuUXVoow/dif+P9ow== X-Google-Smtp-Source: AGHT+IH0ZT2M9/qO1XdC/4LNY9VGXzA39LDG1NEEpxEDhSf5k8HFdkXZjdHlGAEHihsqpz513FRP X-Received: by 2002:a50:8714:0:b0:56d:f3a7:60e with SMTP id 4fb4d7f45d1cf-5734d5eb63emr10537462a12.22.1715749399208; Tue, 14 May 2024 22:03:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715749399; cv=pass; d=google.com; s=arc-20160816; b=sHOcpcabFiKk9DkL/w1KoF3tY4JptmUcl6n48wV+glkVdKb/p+UaqnyUzUfNbnpqxd /OSfJnoSNgqLrrX5AOGu6TXCX3iWirrEHwbjQWeWd3gn0Y+dTg6HFqxzz2YUHcbBzRx3 AyzBvTGqUTa3/25eef8zkeGocGnb5pUBorBJXsnrujj05In/z/4EcnxQ7iOvu75bI98e ucfPQgKWBlut7Q33r4rl/ex6SI638Dp9fLPW37mRs4ogt6AlI/OWvjHg/VMMoAxlo8Gq prru3rXQ4Nsml20n/V992dffYvWturjPWIf6CnxrqqsKd6snhLJoLFVWAyTrAH6tfJUK +1/g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=hwhb6dTZ3C1pduwi/qMgE4+GQbsrnIG7yr+Npoq7eqo=; fh=mRRwBlKn0nLFBAoexHoYhDLEiqaf8tzf8fYpYdbynO4=; b=y4GQyU8Iaas5hcAvTm6THTmch/5TF2MnPBA1DDG9uoMi/slYzCJkWANLDIgQINSU33 3fQn64RC7L+iXGkFPZ9b3JWR4IH4MM/9XlGeP8VKnxf3I9QaMRl7brNW86s2ntRLG0x7 3V+hNvICX7qkrM4exKNiQe/JFv2ZA6GQvzUMF1wg4pOmqPQPpik9qVjPblvfN9QspgrE ywO4Fdb2tEI20hJ9X78ZlQMFGTIUwWb1QygpW0AEyt7LcNuAeXvMCuYIgf2VcrpX4ZuM 704AkYQrC6vAPS6ELlYe9QzZ4ceC14EBfZgmlOXfX6sycDo8+qxG+Yz5FW2BLADrO7/K KJ+A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@darkphysics.net header.s=google header.b=j2ru2M3X; arc=pass (i=1 spf=pass spfdomain=darkphysics.net dkim=pass dkdomain=darkphysics.net); spf=pass (google.com: domain of linux-kernel+bounces-179427-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-179427-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-5733c32c7bfsi6866599a12.449.2024.05.14.22.03.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 22:03:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-179427-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@darkphysics.net header.s=google header.b=j2ru2M3X; arc=pass (i=1 spf=pass spfdomain=darkphysics.net dkim=pass dkdomain=darkphysics.net); spf=pass (google.com: domain of linux-kernel+bounces-179427-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-179427-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 400371F2549F for ; Wed, 15 May 2024 04:56:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C9D703A1D7; Wed, 15 May 2024 04:52:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="j2ru2M3X" Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BD9E605BA for ; Wed, 15 May 2024 04:52:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715748772; cv=none; b=ZHivbAgjY+ZKartLcjwjucmIYENAQVsnMS6HS+1ThfOI2wX/UIBhEymIYaRFfS5TmLsSovu9CGICIjAy2Dgew2QRlBmA0lScaSwwXNQ7Ls0rL9ZSv0xg2KdGA29skC/T1KWI3EIgBFeYSUZq6fm7AWs7rOhIlLDmyu2bdhxXB98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715748772; c=relaxed/simple; bh=jeHwGwRspY2gSDSiW7bcMqqSAMEpU1ir/AH2Va5Ia+k=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=oDcEV98/e7Up+KLv+nWGkpcPaz52FlhfnzwI2seNtK0VmeeQBQ15QYdmVQEpch1DhgqLUlUgZN0izjZS4ZcHzZuuZi4ksncchHECRLWHTSExHBGI2xvey1AITtno2Dvw8JG7TdCD6tSh4DAsPW6+uQI0ISZXVoT/bgfEepi+GZ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=j2ru2M3X; arc=none smtp.client-ip=209.85.167.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-3c9b74043b1so690156b6e.1 for ; Tue, 14 May 2024 21:52:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1715748770; x=1716353570; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hwhb6dTZ3C1pduwi/qMgE4+GQbsrnIG7yr+Npoq7eqo=; b=j2ru2M3XQ0rOTwWUMbhZ2lSsrye/gA4CZuYK/+IkA6FNG3LwKWu6FY9UtWqRztlaxs q2jFUf509Rrk2vtHc3Mz9rzgsrsIXO1gbCnVDXK20RkPdsZVjGIwIMtfuLMSk5wrYx82 +AqWvAAekqpEIqQ9A2f7Xso0PdfiG6GcChsRxDrMOlNeWFsJvWrgCiA5/8M84z4fv57G YY5NFxoyb2WAEga5CcpdDhIxGDRMTFKkGF4skNkr4z2Op5QL6QlsMW0GLyMn+uqLNtfF RC7qa3Z6Xu7LOP4G9axHtjf0tAeGTlhRqu1etSv9Zgj3aI30b7XjmYmcAOWNnhr2pYSE TnLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715748770; x=1716353570; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hwhb6dTZ3C1pduwi/qMgE4+GQbsrnIG7yr+Npoq7eqo=; b=T9fpIzkL6gz1lowNC7aTo2QSlVjCPHHvBJLejks50WDfGsys6Gg0nUwWQWlk0mK5dN 6Yp5v1SZQgp3owxW673XEHGOt4jwpvJEqqudMGlPgb0LKkCkbcawiZkJH4jzlRgALyCp yESD+b7gWCKDbOLHZJgNqteN6+Vtf8M44vHRVTTunB4zPKzZDNr+cAadBNThlfXr8adT gxVKB9plP1gcR+YV7P1R7bqemQSwgLh/9hVCQvwFn7lAKsSIy5rgCpK0zBUHWrOnhzya 44zUTIPkO0q/BbTAhx+gQAm/xG+UfXeIYVyMhmUv4nLCmus/MaP2fCkBLWoL8WeH+jCb 3ELQ== X-Forwarded-Encrypted: i=1; AJvYcCU8Xrcn3KjtZy228w3LbiqG80jcyNXaYYg0yv6Y7dLdfJubrtE5UmTpRS5TRROqlYTEU29GeXXsT30xflmesFigWr4W3qV9DuSDMOdz X-Gm-Message-State: AOJu0YzXdZ6wr0sxMVmtvCKNGP01+mKg2yEchgKAha76aha/UKZLxW5X hiwT0Eh80HReXIr310gKtyXgOJAnzYxV2auKO2Yanh52kIT7qn5KK1aUcVk4fAU= X-Received: by 2002:a05:6808:1a17:b0:3c9:9fda:37f1 with SMTP id 5614622812f47-3c99fda38cbmr14168972b6e.29.1715748769895; Tue, 14 May 2024 21:52:49 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4d2a827fdsm10135035b3a.60.2024.05.14.21.52.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 21:52:49 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 22/31] Staging: rtl8192e: Rename variable IsDataFrame Date: Tue, 14 May 2024 21:52:19 -0700 Message-Id: <20240515045228.35928-23-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240515045228.35928-1-tdavies@darkphysics.net> References: <20240515045228.35928-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Rename variable IsDataFrame to is_data_frame to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies --- drivers/staging/rtl8192e/rtllib.h | 4 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index f69f4ca39fd5..0914ba37f42f 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -338,8 +338,8 @@ enum rt_op_mode { #define RTLLIB_QCTL_TID 0x000F #define FC_QOS_BIT BIT(7) -#define IsDataFrame(pdu) (((pdu[0] & 0x0C) == 0x08) ? true : false) -#define is_legacy_data_frame(pdu) (IsDataFrame(pdu) && (!(pdu[0]&FC_QOS_BIT))) +#define is_data_frame(pdu) (((pdu[0] & 0x0C) == 0x08) ? true : false) +#define is_legacy_data_frame(pdu) (is_data_frame(pdu) && (!(pdu[0]&FC_QOS_BIT))) #define IsQoSDataFrame(pframe) \ ((*(u16 *)pframe&(IEEE80211_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA)) == \ (IEEE80211_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA)) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c index f276e52aab08..d4714e193df4 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -881,7 +881,7 @@ static int rtllib_rx_check_duplicate(struct rtllib_device *ieee, if (!ieee->ht_info->cur_rx_reorder_enable || !ieee->current_network.qos_data.active || - !IsDataFrame(skb->data) || + !is_data_frame(skb->data) || is_legacy_data_frame(skb->data)) { if (!ieee80211_is_beacon(hdr->frame_control)) { if (is_duplicate_packet(ieee, hdr)) -- 2.30.2