Received-SPF: pass (google.com: domain of linux-kernel+bounces-179450-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <688af2f2-dbff-4941-93ec-405d3431dd01@amd.com>
Date: Wed, 15 May 2024 10:42:17 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [RESEND][PATCH v3 1/1] sched: Report the different kinds of
 imbalances in /proc/schedstat
To: Chen Yu <yu.c.chen@intel.com>, Shrikanth Hegde <sshegde@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, peterz@infradead.org,
 torvalds@linux-foundation.org, juri.lelli@redhat.com,
 dietmar.eggemann@arm.com, rostedt@goodmis.org, mgorman@suse.de,
 bristot@redhat.com, vschneid@redhat.com, vincent.guittot@linaro.org,
 gautham.shenoy@amd.com, kprateek.nayak@amd.com
References: <20240514044445.1409976-1-swapnil.sapkal@amd.com>
 <20240514044445.1409976-2-swapnil.sapkal@amd.com>
 <ZkNHshuGhY6nBGmJ@chenyu5-mobl2>
 <e942abce-97ec-4bf1-8220-55bfed18c265@linux.ibm.com>
 <ZkN/7Wo4qVRmFQBU@chenyu5-mobl2>
Content-Language: en-US
From: Swapnil Sapkal <Swapnil.Sapkal@amd.com>
In-Reply-To: <ZkN/7Wo4qVRmFQBU@chenyu5-mobl2>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eUNPQ1llbDNyY1lhVXd3eTU3d2hvVC83QzFZRzdMRlNBZThoUEtjNGJoOTNM?=
 =?utf-8?B?UDVQNXUyZW1OV2haai9YYno5dUlWOEd4cGpBZGRiUXQrN1c3cC8wUlNCWmVy?=
 =?utf-8?B?MkVCb2pLZ0RPSW9BZDY2NkpiRUpHc3pBU2ZEMERQRENMSG56QjZNUWhubG5t?=
 =?utf-8?B?STIzdUVWNzUxNGwxNGYxYzZ0VlNrWDJvcVpYT3Fla2JNYkViZVNtaCtac2F5?=
 =?utf-8?B?YWE0SXFHZHQwQStQYXZFdndqUVRjS3N6Y2UzbXd5ZjY0OTdtMFRwVFU3eno3?=
 =?utf-8?B?di9lNkNNUDV3aHVZckE5SHF5bDAxZVBiblpQQVBGeG1yUTk1eFhDVWd6NUZE?=
 =?utf-8?B?djN5QlY4aC9BUURuRzcvOUNqRnhjREY4aWUxSEN4T2VhcmNjVGpUY292Nk5U?=
 =?utf-8?B?am1na1MvcFE1R2VFNXRnd2ZTMy9LUGFjdVNzckVlaXdIbkFDVSs2bnBQbHI2?=
 =?utf-8?B?NFVNamVaMTR2T29xZXh6NjFxd295dXFMejRrbVdocWN6dVlpcWtxTUpOaGwx?=
 =?utf-8?B?czNjQ2ZUT0V5MXJ1alpXWXo5ZkluUUZtUGJSWnd1ckFtQklxOXVTNHVXQjJH?=
 =?utf-8?B?eDNiWXg4TmNsWXRDTnBERDdoQ2V3Q2hFbjlWWTdSQi9FQlhMcFlnbzhkRGVJ?=
 =?utf-8?B?VWdHUXYyUzNEU3ZJSy9vYVp3QlZtcGdNT0p3MVF5eStZWGtmN052M1ZNNmp4?=
 =?utf-8?B?UURwREpJRGVQazBWNHZWeVNLRk5MZ1dFWmpjdklNbUJvcStjZmJBempJMXhm?=
 =?utf-8?B?OFE1K3VLckJ6MjRqeTR6MDZPY3loSE4raFAwZFVwVWpDVHpKd0k0cmxLMm5n?=
 =?utf-8?B?M1RHb05NTnVHTmVNZG5oeUhRelVSVDlOSk0vWGxoWE5RNkVBczB3ZSs3UG8y?=
 =?utf-8?B?WDA2OVZHNlF4aWhQbXBrbzYxTDRveU1JNWxwQW9oTHpsRGZKeDNXZDNKRUl1?=
 =?utf-8?B?a2J2M3pvSW91UjMySkNwZnc3blNFREdVMUp1ZEhJQkVFT2RNTmtBQ21FczZE?=
 =?utf-8?B?d1I4cDNzNkJTMGhQVEpCVmlIZlN4ZkY0M04wQS9DUWhOK1VZZGYxdHVISEZN?=
 =?utf-8?B?OXBkUHo5RklYb3ZyZTdJU1YvNkFEaXNydllRQ01TaTUvV0QrWEVVTWc2SnJJ?=
 =?utf-8?B?NkE5bWlmZnRHYm5UUEdvQTE5RG5HMnptOE11ZnVGL3Z5UHZieUJGUm5IbXFk?=
 =?utf-8?B?MThwbVNqSVVlN0ZxbkhxSmhnaEp5aDBRdm54NVV3VFpuY2VxL0VQYysveHNw?=
 =?utf-8?B?czhDd1A3ZG1lTDgwd0FRekY5ZFU0aWsxUklpcE1sYjA0bk5GZE5GWjRrQkEy?=
 =?utf-8?B?WlYzN1VEL2lzN0ZhQWlydldHM2RwT1BDVzhSSFpJZDQrQ1RRWnZtbDdqanp1?=
 =?utf-8?B?TWhuRU9wVURjUExyZXlGbzJoU3N0M3pJM2tKdTNXdVVGT3BYNXFxMTV6bXlS?=
 =?utf-8?B?akVQMFgvdEVDdEpDZ1F0WkkrdVprK3dhc1hidkFxVEhwN09HNEVrRHJVNC8x?=
 =?utf-8?B?cE9ZQlo1Mlp3TFcwbmY2YUp2a2ZOZlNnYnNGdDMrVXRPRVRGWnBWL0QyUGt3?=
 =?utf-8?B?SGdQQzZGbGhLd1JaM2pTa2dlS3lJWnlGZG9BaGI1clNTcXJNMFRoL1RZQlFX?=
 =?utf-8?B?MnFLc1UrNzlXWVhNUXRqMi9MZlRYZlM0S2VnZjlCYVh0WVhXdUMxa0pmYVJh?=
 =?utf-8?B?dmVsOWRNaHFCWlRzTDN2U0RPVTRaZFM2T3BZOXJQOWNzUCt2SFdldVNrUkFu?=
 =?utf-8?B?Z0licWZGNUJsWDJpeVVqUXJRQjBFcXF5cnpWbGpoZUhrTEpRMk8zb2kwQVd5?=
 =?utf-8?B?VGVZS1ZkZ2w4bXlDaXZNY0tlQkpXN2NuR2Frb3YzRFd3ams2eEFzWUxRZzZQ?=
 =?utf-8?B?bWRqL0ZxNDVBZUp1NHYrQjJrdnJ1dllxSkU3UUhhSkJJUzZnb3lXa053ZFJ4?=
 =?utf-8?B?akIwZWpEWG56eDhKdXZ5UUNFQXFOWnM4cks4Wkhia0Y1VHVDalMvaG9DK2F2?=
 =?utf-8?B?TnE3TnZoM2dPODJJWHMwa1NXbGd4YW9TSnlXQ1d2a3RzanZyblk5SGcrYWlO?=
 =?utf-8?B?bGZlRVhWa2lxT0JrcStnWU9XQjB0UWVWUmZwS1l4UWxXYlRjS1NldlN1MkRT?=
 =?utf-8?Q?8GWdi2VXhU6FzXpfEaazU9HAe?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d256b45f-c521-4fa5-77c3-08dc749d9e3f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6165.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2024 05:12:29.8254
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T2CEsiT6HYehakSo12C6I6iMik9YUFZJUz62OtYkWkUserUPbPaGRmd0/fOKqFj22hhWjcr5vQkI78qEqg00MA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8065

Hi Chenyu,

Thank you for taking look at this patch.

On 5/14/2024 8:44 PM, Chen Yu wrote:
> On 2024-05-14 at 19:53:58 +0530, Shrikanth Hegde wrote:
>>
>>
>> On 5/14/24 4:44 PM, Chen Yu wrote:
>>> On 2024-05-14 at 04:44:45 +0000, Swapnil Sapkal wrote:
>>
>> It's been increased already as part of below commit
>>
>> commit 11b0bfa5d463b17cac5bf6b94fea4921713530c3
>> Author: Ingo Molnar <mingo@kernel.org>
>> Date:   Fri Mar 8 11:58:55 2024 +0100
>>
>>      sched/debug: Increase SCHEDSTAT_VERSION to 16
>>      
>>      We changed the order of definitions within 'enum cpu_idle_type',
>>      which changed the order of [CPU_MAX_IDLE_TYPES] columns in
>>      show_schedstat().
>>
>>
> 
> I see, so it has been increased due to commit 38d707c54df4, and current patch
> is accomany with that.

Yes, this patch accompanies commit 38d707c54df4. It updates the documentation
because of change in order of [CPU_MAX_IDLE_TYPES] columns and adds the imbalance
fields which will be used by Perf schedstat tool[1].

[1] https://lore.kernel.org/all/20240508060427.417-1-ravi.bangoria@amd.com/

> 
> thanks,
> Chenyu

--
Thanks and Regards,
Swapnil