Received-SPF: pass (google.com: domain of linux-kernel+bounces-179452-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 15 May 2024 07:14:54 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Elizabeth Figura <zfigura@codeweavers.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: ntsync: mark driver as "broken" to prevent from
 building
Message-ID: <2024051521-mankind-borough-f773@gregkh>
References: <2024051450-abrasion-swizzle-550b@gregkh>
 <12433821.O9o76ZdvQC@watership>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <12433821.O9o76ZdvQC@watership>

On Tue, May 14, 2024 at 04:45:13PM -0500, Elizabeth Figura wrote:
> On Tuesday, May 14, 2024 2:16:51 AM CDT Greg Kroah-Hartman wrote:
> > The ntsync code is only partially enabled in the kernel at this point in
> > time, creating the device node and that's about it.  Don't confuse
> > systems that expect to see a working ntsync interface by teasing it with
> > this basic structure at this point in time, so mark the code as "broken"
> > so that it is not built and enabled just yet.
> > 
> > Once the rest of the code is accepted, this will be reverted so that the
> > driver can be correctly built and used, but for now, this is the safest
> > way forward.
> 
> Reviewed-by: Elizabeth Figura <zfigura@codeweavers.com>
> 
> --
> 
> I was even thinking of suggesting something like this myself. Sorry for
> taking so long to get the rest of the patches into acceptable shape...

No worries at all, I'll go queue this up today.  Thanks for the review!

greg k-h