Received-SPF: pass (google.com: domain of linux-kernel+bounces-179485-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Daniel Gomez <da.gomez@samsung.com>
To: "hughd@google.com" <hughd@google.com>, "akpm@linux-foundation.org"
	<akpm@linux-foundation.org>, "willy@infradead.org" <willy@infradead.org>,
	"jack@suse.cz" <jack@suse.cz>, "mcgrof@kernel.org" <mcgrof@kernel.org>
CC: "linux-mm@kvack.org" <linux-mm@kvack.org>, "linux-xfs@vger.kernel.org"
	<linux-xfs@vger.kernel.org>, "djwong@kernel.org" <djwong@kernel.org>,
	"Pankaj Raghav" <p.raghav@samsung.com>, "dagmcr@gmail.com"
	<dagmcr@gmail.com>, "yosryahmed@google.com" <yosryahmed@google.com>,
	"baolin.wang@linux.alibaba.com" <baolin.wang@linux.alibaba.com>,
	"ritesh.list@gmail.com" <ritesh.list@gmail.com>,
	"lsf-pc@lists.linux-foundation.org" <lsf-pc@lists.linux-foundation.org>,
	"david@redhat.com" <david@redhat.com>, "chandan.babu@oracle.com"
	<chandan.babu@oracle.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "brauner@kernel.org" <brauner@kernel.org>,
	Daniel Gomez <da.gomez@samsung.com>
Subject: [PATCH 01/12] splice: don't check for uptodate if partially
 uptodate is impl
Thread-Topic: [PATCH 01/12] splice: don't check for uptodate if partially
	uptodate is impl
Thread-Index: AQHapozBbWbHWLdhTE2QsNHTwXO1jw==
Date: Wed, 15 May 2024 05:57:23 +0000
Message-ID: <20240515055719.32577-2-da.gomez@samsung.com>
In-Reply-To: <20240515055719.32577-1-da.gomez@samsung.com>
Accept-Language: en-US, en-GB
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA02SfUxTZxTGfe+9vfdS1nmp3XgDQ0wNfwha1JntRYm6TJObaSYmJsavaCMX
	JAOUWytM50JkIasiY3VDbZkFKxQKhtiCQIUqDEE+NESmI4AkLO0yymJLEfzoFWZ7ceG/35Pz
	nPOckxwal7+QRNEZ2Sc5PludqSSlxO2u14/WdH69LW3t8MuVqKy+jkTzbV0ATf7uB+jx/eXo
	YXGARDP1b3A06PoQuf3FBDJeLsDQoKOMRGN18xLkEJop5Jxsw9FQiRug9t4fKRR49a7a5Ni3
	NYJtMTyj2HKblrVXx7M2q45kbX49xT64EiDYlvEk9tKQBbBT7mGC9TqfkGx/eSfFTtuWp3yw
	X5qcymVmnOL4xM1HpMf6TBXYiaeyvEaDlcgHI9LzIIyGzAZonJigzgMpLWeqAbzYdYUUxQsA
	C2vnMVFMA3jj70r8fUvA5wViwQKgebQB/99lLnu1MKwfQNMjHyGKGgA9/1aF+klmFXT22EIu
	BTMCoLu3PyRwpkcCBXsLEXQtY/ZCvfAPFmQFcxCW1tbhIqvgjZtuSZAJJg56Al4qyDImCfqa
	PCFPGLMRPjPNkEEGTAz8q+ZNyIMzkXDYZcLEKyLgdWPrwkUfwznHOCnyavjwTxcQeS1srHQS
	Iq+E9c8LMXGOCg79+gspcgKsqpjExR0iYM9VV+hkyLRL4c/FryVi8zb4eGRiIWwZ9HQ3UCJ/
	AvsuFRElIMGwaD/DogzDogzDooxyQFhBJKfVZKVzmnXZXK5Ko87SaLPTVUePZ9nAu8fsm+v2
	N4PfPFOqDoDRoANAGlcqZIq0L9PkslT1t6c5/vhhXpvJaTpANE0oI2VxqbGcnElXn+S+4bgT
	HP++itFhUflYbMrY27ndJZu2nPa9VOT8MXWhtihmcE9O9VmEG5gVquly/QFjzZKleZsHcs9F
	nX3bbL8jfzBeWbBi+5miDZZdLaXAsrUzOXEaPpVYBfOFu6c+N/vWWDP0vFmo6olDR/JdG4sO
	5UlQLxtfKWsdbNSariWjGEfv3YL2Ercj1jPWsD551mvkvhdQ96c5c7guScnUfnZ7fpTy44Wb
	DiXNrPoBfkU7nPe+cDcI58J94+H89oEuFB5Zer8/JgG7E92XezXH5ya9TYm6jy4OGM/wwk+X
	h+Jad7bt0KWYiqvW3xqNT6y4DrbMPrHvmNXqc9mpJUT0d4b9Hc/th3XVFkFJaI6p18XjvEb9
	HxozJSkHBAAA
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHKsWRmVeSWpSXmKPExsVy+t/xu7pH/FzSDNZ+YraYs34Nm8X/vccY
	LV4f/sRocemonMXZvt9sFl/X/2K2uPyEz+Lppz4Wi9nTm5ksLu+aw2Zxb81/Votdf3awW+x7
	vZfZ4saEp4wWB091sFv8/gGU3b4r0kHQY+esu+weCzaVemxeoeWxaVUnm8emT5PYPU7M+M3i
	sfOhpcfkG8sZPT4+vcXi8X7fVTaPMwuOsHt83iQXwBOlZ1OUX1qSqpCRX1xiqxRtaGGkZ2hp
	oWdkYqlnaGwea2VkqqRvZ5OSmpNZllqkb5egl3F6/kKmgmu8FVtnrWJpYLzN1cXIySEhYCLx
	+8N7xi5GLg4hgaWMEpP/bGGDSMhIbPxylRXCFpb4c62LDaLoI6PEse+LWUASQgJnGCW6f2tA
	JFYySjy8cZsRJMEmoCmx7+QmdpCEiMBtRomnp86AOcwCJ1klDpz+zA5SJSwQLnHwz1RmEFtE
	IEZixb117BC2nsSStU/BdrMIqEq8+v0eLM4rYCnxYfsrZojVlhKXXm0H28YpYCVxd/5XsLsZ
	BWQlHq38BVbPLCAucevJfCaIHwQkluw5zwxhi0q8fPwP6jcdibPXnzBC2AYSW5fuY4GwlSXW
	v2tjgpijJ3Fj6hQ2CFtbYtnC18wQ9whKnJz5hGUCo/QsJOtmIWmZhaRlFpKWBYwsqxhFUkuL
	c9Nziw31ihNzi0vz0vWS83M3MQIT3rZjPzfvYJz36qPeIUYmDsZDjBIczEoivCJpzmlCvCmJ
	lVWpRfnxRaU5qcWHGE2BYTSRWUo0OR+YcvNK4g3NDEwNTcwsDUwtzYyVxHk9CzoShQTSE0tS
	s1NTC1KLYPqYODilGpg2yrb7cwj5fbGbxGB7J6p2gv4kXYPW1xlqJ7769l2PluSbqXrhRdVV
	93UlZ1LU9h15sLGWK3B+tW3vncdNCxbuunfjjscP46fZ2i/4FxgeOG+2bPtseQHBV0Ec0v5K
	bvInslnC9j3IyFzbUC9gkH5zvvgTFvevN+vunJst8NxW3/9Qe9q0Ay0rv+ls+nixePI9h9s3
	H1042bX/HPcUwbbbRiUexxbaMO0NO33shYj661K5T1zCPGV3tSqbdL4btf61t/Jf2rfBP/+4
	juT8nx8yAhmZCiYIbTn4fvvWZuZVidK5zhsiHdZOmjh50hcH0a2pWTsMUj+9S04pXLHJPbD2
	zq6ftQYnjf0Ft0+/fSxNiaU4I9FQi7moOBEAoCBM4wEEAAA=
X-CMS-MailID: 20240515055724eucas1p1c502dbded4dc6ff929c7aff570de80c2
X-Msg-Generator: CA
X-RootMTR: 20240515055724eucas1p1c502dbded4dc6ff929c7aff570de80c2
X-EPHeader: CA
CMS-TYPE: 201P
X-CMS-RootMailID: 20240515055724eucas1p1c502dbded4dc6ff929c7aff570de80c2
References: <20240515055719.32577-1-da.gomez@samsung.com>
	<CGME20240515055724eucas1p1c502dbded4dc6ff929c7aff570de80c2@eucas1p1.samsung.com>

From: Pankaj Raghav <p.raghav@samsung.com>

When a large folio is alloced, splice will zero out the whole folio even
if only a small part of it is written, and it updates the uptodate flag
of the folio.

Once the per-block uptodate tracking is implemented for tmpfs,
pipe_buf_confirm() only needs to check the range it needs to splice to
be uptodate and not the whole folio as we don't set uptodate flag for
partial writes.

Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
---
 fs/splice.c | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/fs/splice.c b/fs/splice.c
index 218e24b1ac40..e6ac57795590 100644
--- a/fs/splice.c
+++ b/fs/splice.c
@@ -120,7 +120,9 @@ static int page_cache_pipe_buf_confirm(struct pipe_inod=
e_info *pipe,
 				       struct pipe_buffer *buf)
 {
 	struct folio *folio =3D page_folio(buf->page);
+	const struct address_space_operations *ops;
 	int err;
+	off_t off =3D folio_page_idx(folio, buf->page) * PAGE_SIZE + buf->offset;
=20
 	if (!folio_test_uptodate(folio)) {
 		folio_lock(folio);
@@ -134,12 +136,21 @@ static int page_cache_pipe_buf_confirm(struct pipe_in=
ode_info *pipe,
 			goto error;
 		}
=20
+		ops =3D folio->mapping->a_ops;
 		/*
 		 * Uh oh, read-error from disk.
 		 */
-		if (!folio_test_uptodate(folio)) {
-			err =3D -EIO;
-			goto error;
+		if (!ops->is_partially_uptodate) {
+			if (!folio_test_uptodate(folio)) {
+				err =3D -EIO;
+				goto error;
+			}
+		} else {
+			if (!ops->is_partially_uptodate(folio, off,
+							buf->len)) {
+				err =3D -EIO;
+				goto error;
+			}
 		}
=20
 		/* Folio is ok after all, we are done */
--=20
2.43.0