Received-SPF: pass (google.com: domain of linux-kernel+bounces-179508-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Daniel Gomez <da.gomez@samsung.com>
To: "hughd@google.com" <hughd@google.com>, "akpm@linux-foundation.org"
	<akpm@linux-foundation.org>, "willy@infradead.org" <willy@infradead.org>,
	"jack@suse.cz" <jack@suse.cz>, "mcgrof@kernel.org" <mcgrof@kernel.org>
CC: "linux-mm@kvack.org" <linux-mm@kvack.org>, "linux-xfs@vger.kernel.org"
	<linux-xfs@vger.kernel.org>, "djwong@kernel.org" <djwong@kernel.org>,
	"Pankaj Raghav" <p.raghav@samsung.com>, "dagmcr@gmail.com"
	<dagmcr@gmail.com>, "yosryahmed@google.com" <yosryahmed@google.com>,
	"baolin.wang@linux.alibaba.com" <baolin.wang@linux.alibaba.com>,
	"ritesh.list@gmail.com" <ritesh.list@gmail.com>,
	"lsf-pc@lists.linux-foundation.org" <lsf-pc@lists.linux-foundation.org>,
	"david@redhat.com" <david@redhat.com>, "chandan.babu@oracle.com"
	<chandan.babu@oracle.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "brauner@kernel.org" <brauner@kernel.org>,
	Daniel Gomez <da.gomez@samsung.com>
Subject: [PATCH 03/12] shmem: move folio zero operation to write_begin()
Thread-Topic: [PATCH 03/12] shmem: move folio zero operation to
	write_begin()
Thread-Index: AQHapozDwSlh4G2vDEmdcsveZO13yA==
Date: Wed, 15 May 2024 05:57:25 +0000
Message-ID: <20240515055719.32577-4-da.gomez@samsung.com>
In-Reply-To: <20240515055719.32577-1-da.gomez@samsung.com>
Accept-Language: en-US, en-GB
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEKsWRmVeSWpSXmKPExsWy7djP87rH/VzSDOZeUrGYs34Nm8X/vccY
	LV4f/sRocemonMXZvt9sFl/X/2K2uPyEz+Lppz4Wi9nTm5ksLu+aw2Zxb81/Votdf3awW+x7
	vZfZ4saEp4wWB091sFv8/gGU3b4r0kHQY+esu+weCzaVemxeoeWxaVUnm8emT5PYPU7M+M3i
	sfOhpcfkG8sZPT4+vcXi8X7fVTaPMwuOsHt83iQXwBPFZZOSmpNZllqkb5fAlXHrzD+mgueC
	FZt/LWNsYLzP18XIySEhYCLxYsNC5i5GLg4hgRWMEjPaFrGBJIQEvjBK9J2QhEh8ZpR4N+U0
	M0zH8uYLUEXLGSV+n+KCK5r7azMjhHOGUWLOoh9QzkpGiXtvbrCCtLAJaErsO7mJHSQhInCb
	UeLpqTNgDrPASVaJP5t3soBUCQt4SKz79gKsQ0TAX2LHs1dMELaexJELC8GWswioSkxd9wfs
	KF4BS4kPi/8zgticAlYSd+d/BathFJCVeLTyFzuIzSwgLnHryXwmiCcEJRbN3gP1kJjEv10P
	2SBsHYmz158wQtgGEluX7mOBsJUl1r9rY4KYoydxY+oUNghbW2LZwtdQNwhKnJz5hAXkGQmB
	nVwS92+3QC1zkdjway3UAmGJV8e3sEPYMhKnJ/ewTGDUnoXkvllIdsxCsmMWkh0LGFlWMYqn
	lhbnpqcWG+allusVJ+YWl+al6yXn525iBCbL0/+Of9rBOPfVR71DjEwcjIcYJTiYlUR4RdKc
	04R4UxIrq1KL8uOLSnNSiw8xSnOwKInzqqbIpwoJpCeWpGanphakFsFkmTg4pRqYmCYlvmqf
	2BX/pKslgLO6o3D+ueP/jUIWslu7zrafwJwVIyN3+5Xdwo3MzForZyTs1PqUvzrn0Vr9uTrq
	Xr2zzJScuravuZKjYJPMZtBx8tBRj6ZamfW3pj070K5R93kWB4+AXtIza7WnsY6Pzit5BDG8
	mJxxZfqLKlfPCAmvaUa7Z6+IfXxmW3DNDtUJ3+989vwSbCk//37y2n034uOZHZRqXTZsN8yb
	/ForqPfdnG95fk0v/2Y25m45cJAnsXr1OoVlb84Kd54uOPElTm3PkY/X1bu4Vh67vKPN9dTB
	vTHvi1rao/k7/A0Z7Ot4g92P1AizfOrZfzGmsKBFa/PGlk2H7wS4qS1+W6+ya91eJZbijERD
	Leai4kQA+VA/VwUEAAA=
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPKsWRmVeSWpSXmKPExsVy+t/xe7rH/VzSDF4e4rSYs34Nm8X/vccY
	LV4f/sRocemonMXZvt9sFl/X/2K2uPyEz+Lppz4Wi9nTm5ksLu+aw2Zxb81/Votdf3awW+x7
	vZfZ4saEp4wWB091sFv8/gGU3b4r0kHQY+esu+weCzaVemxeoeWxaVUnm8emT5PYPU7M+M3i
	sfOhpcfkG8sZPT4+vcXi8X7fVTaPMwuOsHt83iQXwBOlZ1OUX1qSqpCRX1xiqxRtaGGkZ2hp
	oWdkYqlnaGwea2VkqqRvZ5OSmpNZllqkb5egl3HrzD+mgueCFZt/LWNsYLzP18XIySEhYCKx
	vPkCWxcjF4eQwFJGid72uUwQCRmJjV+uskLYwhJ/rnVBFX1klHj1eyIzhHOGUeLPpkZWCGcl
	o8Tpno9sIC1sApoS+05uYgdJiAjcZpR4euoMmMMscJJV4sDpz+wgVcICHhLrvr0AWyIi4Cux
	cstfFghbT+LIhYVgk1gEVCWmrvvDDGLzClhKfFj8nxHEFgKyL73aDmZzClhJ3J3/FayeUUBW
	4tHKX2DzmQXEJW49mQ/1kIDEkj3nmSFsUYmXj/9BPacjcfb6E0YI20Bi69J9LBC2ssT6d21M
	EHP0JG5MncIGYWtLLFv4GuoeQYmTM5+wTGCUnoVk3SwkLbOQtMxC0rKAkWUVo0hqaXFuem6x
	kV5xYm5xaV66XnJ+7iZGYMrbduznlh2MK1991DvEyMTBeIhRgoNZSYRXJM05TYg3JbGyKrUo
	P76oNCe1+BCjKTCMJjJLiSbnA5NuXkm8oZmBqaGJmaWBqaWZsZI4r2dBR6KQQHpiSWp2ampB
	ahFMHxMHp1QDU7DFr4ynt03ZQ3pmz/l8xSdR4nEwv8OhrRldjYnsFks9VMR7Hk6Tnrt5kuTy
	v/wd/51LljyQmLDNyX6lY+KDpPiq3fx/nc9N8bMP4LitsN2qvfzDPF4RVpWaG1P6tzziVI10
	eyT/R5DzT8oPXdEj0zZwMR14JndEe6Hw+RcbJrqWzWDyu3TJ6MW0Po3MeI/G2mSNC5FuUhtO
	NK7lWZ0nnPnwfkco55RkbUau8OKNkRm9mxfafH8SkX0vYAVX/3TuujN3V0Q+f/n1M//Nizlx
	uw6cqV0sGN8dLJjAMmWxPqdXvAvf77AdzSuVFhn/Tp5xq2JLq1GlQ4iPQvRDnb/VShvXRztM
	Xy48YU+l0b56JZbijERDLeai4kQAdnZNzAIEAAA=
X-CMS-MailID: 20240515055727eucas1p2413c65b8b227ac0c6007b4600574abd8
X-Msg-Generator: CA
X-RootMTR: 20240515055727eucas1p2413c65b8b227ac0c6007b4600574abd8
X-EPHeader: CA
CMS-TYPE: 201P
X-CMS-RootMailID: 20240515055727eucas1p2413c65b8b227ac0c6007b4600574abd8
References: <20240515055719.32577-1-da.gomez@samsung.com>
	<CGME20240515055727eucas1p2413c65b8b227ac0c6007b4600574abd8@eucas1p2.samsung.com>

Simplify zero out operation by moving it from write_end() to the
write_begin(). If a large folio does not have any block uptodate when we
first get it, zero it out entirely.

Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
---
 mm/shmem.c | 27 ++++++++++++++++++++-------
 1 file changed, 20 insertions(+), 7 deletions(-)

diff --git a/mm/shmem.c b/mm/shmem.c
index 4818f9fbd328..86ad539b6a0f 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -149,6 +149,14 @@ static inline bool sfs_is_fully_uptodate(struct folio =
*folio)
 	return bitmap_full(sfs->state, i_blocks_per_folio(inode, folio));
 }
=20
+static inline bool sfs_is_any_uptodate(struct folio *folio)
+{
+	struct inode *inode =3D folio->mapping->host;
+	struct shmem_folio_state *sfs =3D folio->private;
+
+	return !bitmap_empty(sfs->state, i_blocks_per_folio(inode, folio));
+}
+
 static inline bool sfs_is_block_uptodate(struct shmem_folio_state *sfs,
 					 unsigned int block)
 {
@@ -239,6 +247,15 @@ static void sfs_free(struct folio *folio, bool force)
 	kfree(folio_detach_private(folio));
 }
=20
+static inline bool shmem_is_any_uptodate(struct folio *folio)
+{
+	struct shmem_folio_state *sfs =3D folio->private;
+
+	if (folio_test_large(folio) && sfs)
+		return sfs_is_any_uptodate(folio);
+	return folio_test_uptodate(folio);
+}
+
 static void shmem_set_range_uptodate(struct folio *folio, size_t off,
 				     size_t len)
 {
@@ -2872,6 +2889,9 @@ shmem_write_begin(struct file *file, struct address_s=
pace *mapping,
 	if (ret)
 		return ret;
=20
+	if (!shmem_is_any_uptodate(folio))
+		folio_zero_range(folio, 0, folio_size(folio));
+
 	*pagep =3D folio_file_page(folio, index);
 	if (PageHWPoison(*pagep)) {
 		folio_unlock(folio);
@@ -2894,13 +2914,6 @@ shmem_write_end(struct file *file, struct address_sp=
ace *mapping,
 	if (pos + copied > inode->i_size)
 		i_size_write(inode, pos + copied);
=20
-	if (!folio_test_uptodate(folio)) {
-		if (copied < folio_size(folio)) {
-			size_t from =3D offset_in_folio(folio, pos);
-			folio_zero_segments(folio, 0, from,
-					from + copied, folio_size(folio));
-		}
-	}
 	shmem_set_range_uptodate(folio, 0, folio_size(folio));
 	folio_mark_dirty(folio);
 	folio_unlock(folio);
--=20
2.43.0