Received-SPF: pass (google.com: domain of linux-kernel+bounces-179546-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 15 May 2024 09:09:04 +0200
From: Lukasz Majewski <lukma@denx.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org, Paolo Abeni
 <pabeni@redhat.com>, Eric Dumazet <edumazet@google.com>, Vladimir Oltean
 <olteanv@gmail.com>, "David S. Miller" <davem@davemloft.net>, Oleksij
 Rempel <o.rempel@pengutronix.de>, Tristram.Ha@microchip.com, Ravi
 Gunasekaran <r-gunasekaran@ti.com>, Simon Horman <horms@kernel.org>, Nikita
 Zhandarovich <n.zhandarovich@fintech.ru>, Murali Karicheri
 <m-karicheri2@ti.com>, Arvid Brodin <Arvid.Brodin@xdin.com>, Dan Carpenter
 <dan.carpenter@linaro.org>, "Ricardo B. Marliere" <ricardo@marliere.net>,
 Casper Andersson <casper.casan@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: hsr: Setup and delete proxy prune timer only when
 RedBox is enabled
Message-ID: <20240515090904.477c6b5f@wsk>
In-Reply-To: <20240515064139.-B-_Hf0_@linutronix.de>
References: <20240514091306.229444-1-lukma@denx.de>
	<20240515064139.-B-_Hf0_@linutronix.de>
Organization: denx.de
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/7vQ_Gdg_fcDO5+YKl6phDUR";
 protocol="application/pgp-signature"; micalg=pgp-sha512

--Sig_/7vQ_Gdg_fcDO5+YKl6phDUR
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Sebastian,

> On 2024-05-14 11:13:06 [+0200], Lukasz Majewski wrote:
> > The timer for removing entries in the ProxyNodeTable shall be only
> > active when the HSR driver works as RedBox (HSR-SAN).
> >=20
> > Moreover, the obsolete del_timer_sync() is replaced with
> > timer_delete_sync().
> >=20
> > This patch improves fix from commit 3c668cef61ad
> > ("net: hsr: init prune_proxy_timer sooner") as the prune node
> > timer shall be setup only when HSR RedBox is supported in the node.
> > =20
>=20
> Is it problematic to init/ delete the timer in non-redbox mode? It
> looks easier and it is not a hotpath.

My concern is only with resource allocation - when RedBox is not
enabled the resources for this particular, not used timer are allocated
anyway.

If this can be omitted - then we can drop the patch.

>=20
> > Signed-off-by: Lukasz Majewski <lukma@denx.de> =20
>=20
> Sebastian


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

--Sig_/7vQ_Gdg_fcDO5+YKl6phDUR
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmZEX5AACgkQAR8vZIA0
zr1lTAgA2ENishaKFuCVLs+wjmiwd631kRvCT/CrhFlZee0BvnKzZt8kCInlqXHz
87nox73yEmt+X7K5j+IvZCWLgJlrlhkqmeJRfubl4/9p7XfAraK5z+jrCt3PlhRQ
gsNSMHRcthViR7aluoVSbWWjuYH04CjKejrW1fxIm8BHVOVFMI2WU/dnm0UCTetM
19XhJ4MK+u9+doa9jGekd1CHv39U67jx7bhkOx0FR6j1P1/ye0cg5JOUKP+CwLos
auEtJMO9taESL6ptJB0JOmNLycJXD9HROgpALwSkgBZ/VAfvfaes0Y8u4G7EIfW8
P2+Tl9nI+DLm2OjU3V7IMXrQnO6ARg==
=Dwv4
-----END PGP SIGNATURE-----

--Sig_/7vQ_Gdg_fcDO5+YKl6phDUR--