Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp3138008lqo; Wed, 15 May 2024 00:15:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUe7BetEEEmYilEvzaSAew6u9UHpr4ygoBIiOejKDDMdENNJIjXNB6JXsO1O/ffsFYPVLgEk1d5Y4K5ImgyyHWEELaQ1kquzOBz4bcdMQ== X-Google-Smtp-Source: AGHT+IFDK0cuKumfPIZbhHrX4rf1hjnx5feJBAMCsp2+CxUfd33dXexOeEBVWOx2Vdv6xhjU20Mw X-Received: by 2002:a05:6359:4c09:b0:192:4634:b1db with SMTP id e5c5f4694b2df-193bb517d7dmr1637036655d.11.1715757309160; Wed, 15 May 2024 00:15:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715757309; cv=pass; d=google.com; s=arc-20160816; b=rU2iRh4KabFoZSbIHxFPFAXxB7TF6n9F8SSshnG/o2gBGdC7E5wJOWAjY91kh4S+yP IEtFdybTcOXDyBmwd0PUARvYCT8YmEbl361bjQKz0Na4WTN4Phxk2j7lKrmE9xcxHLnx rakPApF0kiC/2/6Evn4QXm26xd2S7Sll7Vc/OuIxL76Gy5kcWNjblG7zxWK7z01R9h21 n5JEM2qp3eoo27HcztsRPsi9dxNXamsR3AmjTxuu/9npG8kliYMEQEh0ggv1t9Dcep/i xPfsg1RGE4LZ483ub5fw7WXVSc5QzkyIlct7s+J52mXa8F+EgtTJ+2EGZG7Jaw1jSOcW J3rw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:dkim-signature:dkim-signature:date; bh=OjxbuDWr0zOcw90ZsB0EVCRcP/VSMs6LQbSERYEb5HM=; fh=/jKRIImuNtwF79CK2dEugopMX+A0ug+s7dyM2lrP6kk=; b=H6FWhiq3GPe6Ke0ytOc1MTqqwgj4MCjiGH5ly3ufKQDnMOqm9n3n6bRCErmtYSppl3 X8lsHr1gnIAhxl7kfhRiAZVHqAWqxGJrBmjCo5l/4UEyc8qLR80EbrzfSNMk/4XBARsg TEd8kWtWqDFBJybKzRHzAlXz27aEogrxYR7K1540jrzTtrviBwa4oDV+gh8C+N28eY2G 5m6da1flI8J0BVoh4LR4SToRDgq/bS77Xsvu52G7wyRoQcAf/EmAWSP+dOkHBuRfbrTq tfOCZi96+oL6mxq++3A6w44b746sgIj/pvbyFomx04N4TC37/FwH6/8B8QsdslcDU1vw jNDA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Pywic27G; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-179549-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-179549-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-6340a16213esi12779330a12.164.2024.05.15.00.15.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 May 2024 00:15:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-179549-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Pywic27G; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-179549-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-179549-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 5F9FDB22377 for ; Wed, 15 May 2024 07:15:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4E74343ABE; Wed, 15 May 2024 07:14:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="Pywic27G"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="2zLTLqej" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 269F741C6D; Wed, 15 May 2024 07:14:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715757294; cv=none; b=bTqKGZoRpaWfDHtIBghfUevDGRjqpHwHNlWcKFWkVol9quW8uJzY1TSyZHlhhkGCfYTWBp/oGCiYS/gAUg017nZtqAuCFAUIRVreKCx+FNDZSlHoVAwrFI7QA+mpWtAfZXbQq2N2LR5+gJHBlx6qlXmb+pZRYEfW0YUhDgDK/sc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715757294; c=relaxed/simple; bh=fSBL+I7mlttw6laOfhj4mqwmELbbr3O5aHueDsMdMS8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GF6qtX6MbvgWP+litRDv+K+TmmHVimRi+4t8UC+jH+U6Um2VoLb3AFTpCRW4QJZXtL+0Kbz9CG8+neB1iLSG9XZ/2YLpP7igtWSvbxanXkt655j6zRJRb+VbuRWIXOTjdzp6mR0QGS0Q+5Ak9wZEP+C7R+tHr3ry0IXuaTat+hg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=Pywic27G; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=2zLTLqej; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Date: Wed, 15 May 2024 09:14:48 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1715757289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OjxbuDWr0zOcw90ZsB0EVCRcP/VSMs6LQbSERYEb5HM=; b=Pywic27G6qu/Lw3kltaLmpHlBJ8NSDpUkGLrQpH7xRcd3YGPculNrQE8UARStG1Fbp4YOk AqvgJcnM8H0efgQEl1bIJXyMPnoSKa/MB5yVj5uR/4Fr9c7pbh65aa8Fd7Wc9ExvMfJ7k9 f5WvWMTqCCriiQwqugz1oaOUL7vbk17vSJVl6REFne7o6O6c4Rg37frg0yyX8gQs9ssUmG GriN41mjcNW+kz400ugIm6gxHfYxZpouNevrPKUgBJe8KsjHvpfCHPvLi5sS3gENjCSDh4 XOpKd7Bvq8SeWukkxJ7hGRGANAHGgQ4u7GWww/lQjHaZq+mYB4WRtF6REj1BiA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1715757289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OjxbuDWr0zOcw90ZsB0EVCRcP/VSMs6LQbSERYEb5HM=; b=2zLTLqejJl0Ua9Ga9kjSrJSd2+cmRRiET9BtcLwZPEgkSF6WMtC2NL6nFsMyD+/fMvpHFz aCS2g4nSnd29RpCg== From: Sebastian Andrzej Siewior To: Lukasz Majewski Cc: Jakub Kicinski , netdev@vger.kernel.org, Paolo Abeni , Eric Dumazet , Vladimir Oltean , "David S. Miller" , Oleksij Rempel , Tristram.Ha@microchip.com, Ravi Gunasekaran , Simon Horman , Nikita Zhandarovich , Murali Karicheri , Arvid Brodin , Dan Carpenter , "Ricardo B. Marliere" , Casper Andersson , linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: hsr: Setup and delete proxy prune timer only when RedBox is enabled Message-ID: <20240515071448.Vf_t99dI@linutronix.de> References: <20240514091306.229444-1-lukma@denx.de> <20240515064139.-B-_Hf0_@linutronix.de> <20240515090904.477c6b5f@wsk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240515090904.477c6b5f@wsk> On 2024-05-15 09:09:04 [+0200], Lukasz Majewski wrote: > Hi Sebastian, Hi Lukasz, > My concern is only with resource allocation - when RedBox is not > enabled the resources for this particular, not used timer are allocated > anyway. timer_setup() does not allocate any resources. The initialisation is pure static assignment. The timer subsystem does not look at this timer until mod_timer() is invoked (or something similar). > If this can be omitted - then we can drop the patch. > > Best regards, > > Lukasz Majewski Sebastian