Received-SPF: pass (google.com: domain of linux-kernel+bounces-179576-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240509013727.648600-1-samuel.holland@sifive.com>
 <CAMj1kXFfWKh-oM8q11eEF94mPOENHxW+fdvkYLSbUDs0ZG8Sow@mail.gmail.com> <c65023fd-5f35-40f0-947d-377088919af3@sifive.com>
In-Reply-To: <c65023fd-5f35-40f0-947d-377088919af3@sifive.com>
From: Ard Biesheuvel <ardb@kernel.org>
Date: Wed, 15 May 2024 09:19:51 +0200
Message-ID: <CAMj1kXE2h9MkPtaVcgUBvpK6e1NpzMfXN5GFdUmGSe2DNmg3VQ@mail.gmail.com>
Subject: Re: [PATCH] ARM: Do not select ARCH_HAS_KERNEL_FPU_SUPPORT
To: Samuel Holland <samuel.holland@sifive.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-arm-kernel@lists.infradead.org, 
	linux-kernel@vger.kernel.org, 
	Thiago Jung Bauermann <thiago.bauermann@linaro.org>, kernel test robot <lkp@intel.com>, Andrew Davis <afd@ti.com>, 
	Arnd Bergmann <arnd@arndb.de>, =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>, 
	Eric DeVolder <eric.devolder@oracle.com>, Rob Herring <robh@kernel.org>, 
	Russell King <linux@armlinux.org.uk>, Thomas Gleixner <tglx@linutronix.de>
Content-Type: text/plain; charset="UTF-8"

On Wed, 15 May 2024 at 00:48, Samuel Holland <samuel.holland@sifive.com> wrote:
>
> Hello Ard,
>
> On 2024-05-09 2:39 AM, Ard Biesheuvel wrote:
> > On Thu, 9 May 2024 at 03:37, Samuel Holland <samuel.holland@sifive.com> wrote:
> >>
> >> On 32-bit ARM, conversions between `double` and `long long` require
> >> runtime library support. Since the kernel does not currently provide
> >> this library support, the amdgpu driver fails to build:
> >>
> >>   ERROR: modpost: "__aeabi_l2d" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> >>   ERROR: modpost: "__aeabi_d2ulz" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> >>
> >> As Arnd reports, there are likely no 32-bit ARM platforms which can use
> >> the amdgpu driver anyway, due to lack of features like 64-bit
> >> prefetchable BARs. Since amdgpu is currently the only real user of
> >> ARCH_HAS_KERNEL_FPU_SUPPORT, drop support for this option instead of
> >> bothering to implement the library functions.
> >>
> >> Fixes: 12624fe2d707 ("ARM: implement ARCH_HAS_KERNEL_FPU_SUPPORT")
> >
> > This commit is not in mainline yet. Could we just drop the original
> > patch instead?
>
> No, like I mentioned in the original thread, later patches in the series (for
> example bbce5cac4f5a ("lib/raid6: use CC_FLAGS_FPU for NEON CFLAGS")) depend on
> CC_FLAGS_FPU being defined for both arm and arm64.
>
> arm can't select ARCH_HAS_KERNEL_FPU_SUPPORT because the contract of that option
> is not fully implemented, but in my opinion it doesn't hurt to keep the part
> that is implemented.
>

Fair enough. But that still doesn't mean we have to add the 'select
ARCH_HAS_KERNEL_FPU_SUPPORT' only to back it out again.