Received-SPF: pass (google.com: domain of linux-kernel+bounces-179577-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>, Jason Gunthorpe <jgg@ziepe.ca>,
	"Joerg Roedel" <joro@8bytes.org>, Will Deacon <will@kernel.org>, Robin Murphy
	<robin.murphy@arm.com>, Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Nicolin Chen <nicolinc@nvidia.com>, "Liu, Yi L" <yi.l.liu@intel.com>, "Jacob
 Pan" <jacob.jun.pan@linux.intel.com>, Joel Granados <j.granados@samsung.com>
CC: "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v5 2/9] iommu: Replace sva_iommu with iommu_attach_handle
Thread-Topic: [PATCH v5 2/9] iommu: Replace sva_iommu with iommu_attach_handle
Thread-Index: AQHamw8ANEvMzn0R2UW8NGE5Cyn6fbGX+hRA
Date: Wed, 15 May 2024 07:21:23 +0000
Message-ID: <BN9PR11MB527615219EEF0EF3EACCF38D8CEC2@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240430145710.68112-1-baolu.lu@linux.intel.com>
 <20240430145710.68112-3-baolu.lu@linux.intel.com>
In-Reply-To: <20240430145710.68112-3-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4HnZ8Y5iCyUpQpWY/zA/rzTZtyGapHAUWALnMTSaLtjvh7GPyGtG1r0LDO6s?=
 =?us-ascii?Q?C7ArNtmDcWJw6FtNtRh7uizI0Uaog6bodhpsUvIL8uEIFHxq4VrEVcPphi3y?=
 =?us-ascii?Q?cDWp+qYjVRlykql+EFsR+JK97i/eMOV5Zdpg/xLKsx6dbX3mzpqXpY+y0K8s?=
 =?us-ascii?Q?4I5Dq2jZgNlHvADLWIKiJHlourlKyWWwcRvbSdYgELLXDNByX4k8Ivkbu1Gl?=
 =?us-ascii?Q?ZdXWkrYq/vSXZurVZCyNcxMa0Qsb9ojv7esSUnlZFCr1tox3BF5gV9IYsYov?=
 =?us-ascii?Q?kwQHNjiV7sz4x8DV6NTMSecDSUTfNui4sGw6GxPnDpBMtnHzAIx5HG86mltV?=
 =?us-ascii?Q?rnt+XXBsbo0V7BCH58TPUd8cpWDw1H0fHDyRnBRpGhThxF82VBFk+2LNYX3+?=
 =?us-ascii?Q?h3DOW+6SJBx1BuM0NnDF6latXk6Ur/TrRg2PC5IIDKtvXnZ4t7EDeQo8sDh3?=
 =?us-ascii?Q?wVJNF1BsKNqhaJ7MUK8EcZJq3RdBG5t1mem2gN5SFAHwNHPg10Odg+4zmBcE?=
 =?us-ascii?Q?YCBy3SGiyRaDFFLAqyfxSWgSOplNKoGBIITdrl9OpXvIREbtXQGtxsSicJnQ?=
 =?us-ascii?Q?mrdkupkbDRMg3b8giKxTZW5u5gFyb7+poto64p6X+jN33GfWqhr+jzkRN6BG?=
 =?us-ascii?Q?oThgTCpkvN3Ctl+tR0Uz1bd3t17NSnb6OmYZ0cmFAE2HqifVws0EdmUy6lPI?=
 =?us-ascii?Q?OeF8VN0EhNmDpKhf9VkBFaQlY7Ixpfg666blYN1dT8CN3UhwcUJ1C/pHOYp4?=
 =?us-ascii?Q?4YkdNVc7Tgm2U06I5yx5V+Z4Wds+qwBJjw8O0jFO4VsJaBveAyk/uwhvTEtQ?=
 =?us-ascii?Q?fjRO66BgOaUgh7tg9zwAuMOpU6gSC1wrgNpjQKQyGl0rWH7psI1/A2IW3UhM?=
 =?us-ascii?Q?XvCN5FuoNTCkO6alQQrXrXt7NkCIdc3Mut/h176PZ4YvNiJGhc3Lgq//pYlQ?=
 =?us-ascii?Q?jzOqr/JSzyEWBxKWgC9i+qXCC5QxulExYY9OE147Z2xlA7gtKV56M5aUxDRN?=
 =?us-ascii?Q?aRXu9W3l9Z6iYujWwJ+iSVn0WWAropOd1ihdY8XuV/++gyve4JPAMSiz3qDV?=
 =?us-ascii?Q?EQUnS86Y3RLrDuHWBdv8mVD1JpvKdVfPG61X9RVB+P72ddErLW750JuOWBgA?=
 =?us-ascii?Q?WTQt2NVuoXo/31Pn0VZARzKO4LhP2zYOy+VvHCiOZIFcBhNHL43If7KScp8a?=
 =?us-ascii?Q?n52CQCBj3mEukDphd1p9HfKfQFS7z45nrQJVdj1CjCRSh6zCZBvPoUC2zrgP?=
 =?us-ascii?Q?o/p2EFLQQpwW02Tpe7fQ56WQNGO/LQEigVL6BAs59ARkKc2woMO+88WQBbX+?=
 =?us-ascii?Q?5UGCIVPLawFvQRakXxEVXEJN7ptVDcdNs2Gd0tFYr9+plzQpBTzbrAkm3Dud?=
 =?us-ascii?Q?v5NHtWq0y2lJnNuhKtHaW7z0d0ZtWFxdinS2Nxkn+WvsdFyr/oCZY8nHVxDm?=
 =?us-ascii?Q?4D0OJWQ7thMItkcc0jnqSkYtysw2r4SBdJv/o1bReIZg82WtQpG/fKHBtGXu?=
 =?us-ascii?Q?OWlw4mDwUWMAFzUpnz4Y+Eu6bVATROMP7lsSMXk3Ey46acUbTTfoBzHS0YwQ?=
 =?us-ascii?Q?p++5dt/JEu4rTr0yqq6Gmv92+Q/5Wj7dw6ijN3DA?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a430c7a0-bedc-4b70-2753-08dc74afa061
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2024 07:21:23.8222
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pN2L3MOF5Yiiz9RrwJm8MGYZ8GhEKyJzJSM5PrGGcjhVbWE+f+kI8jICrap04zzE7XjUH6dIRrE9GfAWEzelQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5223
X-OriginatorOrg: intel.com

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Tuesday, April 30, 2024 10:57 PM
>=20
>  #else
> -static inline struct iommu_sva *
> +static inline struct iommu_attach_handle *
>  iommu_sva_bind_device(struct device *dev, struct mm_struct *mm)
>  {
> -	return NULL;
> +	return ERR_PTR(-ENODEV);
>  }
>=20

this should be a separate fix.

existing drivers (idxd and uacce) only check IS_ERR() on the return
value. A Null pointer may lead to an error reported at a later point.