Received-SPF: pass (google.com: domain of linux-kernel+bounces-179583-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Jason Gunthorpe <jgg@ziepe.ca>, Baolu Lu <baolu.lu@linux.intel.com>
CC: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>, "Robin
 Murphy" <robin.murphy@arm.com>, Jean-Philippe Brucker
	<jean-philippe@linaro.org>, Nicolin Chen <nicolinc@nvidia.com>, "Liu, Yi L"
	<yi.l.liu@intel.com>, Jacob Pan <jacob.jun.pan@linux.intel.com>, "Joel
 Granados" <j.granados@samsung.com>, "iommu@lists.linux.dev"
	<iommu@lists.linux.dev>, "virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v5 3/9] iommu: Add attachment handle to struct iopf_group
Thread-Topic: [PATCH v5 3/9] iommu: Add attachment handle to struct iopf_group
Thread-Index: AQHamw8FRMPPYVB/4U+b9NV7aZfqhrGMgJcAgANZlwCAAK5cAIAADncAgAAhLQCAB0MjIA==
Date: Wed, 15 May 2024 07:28:12 +0000
Message-ID: <BN9PR11MB5276793FD24A0FA45B527F518CEC2@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240430145710.68112-1-baolu.lu@linux.intel.com>
 <20240430145710.68112-4-baolu.lu@linux.intel.com>
 <20240508000454.GM4718@ziepe.ca>
 <21ffbcc7-1103-4481-af14-5ee8856b9625@linux.intel.com>
 <20240510133824.GW4718@ziepe.ca>
 <0de7c71f-571a-4800-8f2b-9eda0c6b75de@linux.intel.com>
 <20240510162854.GY4718@ziepe.ca>
In-Reply-To: <20240510162854.GY4718@ziepe.ca>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OQ0EG6uSIeDhICxdw9v7OpNmOjVYx2dJxXFsVUwKd8Z6BXDtsxgaBeha5fiO?=
 =?us-ascii?Q?yNc/wewWgp1dXpfx+8H5v4nQgJzR5tB0dICKeYrh4D+UxS9Z9XB4whqCmZWu?=
 =?us-ascii?Q?W3iWdaMzVK5oJNWs4WPlsLV+3YGm0IweYlArVylRWN0cD70TtfTopMwPgU18?=
 =?us-ascii?Q?VbPK7C+et4goHKAB8h6ztSBP3+mNmuQI51hxMzaPZ0kMVSjsMoEKpF7zMiq5?=
 =?us-ascii?Q?Ap8S1SHO2bx0ecY63Ea7vAN6mSloZyjKWGX97Hstlbm7Wn4zgS+lSHZYbITA?=
 =?us-ascii?Q?CfDUVFnhX7+vmE0yxuzVpSyV5BpspcYF04TdedNRV1fT04r4q6KzzEsMgN0T?=
 =?us-ascii?Q?k8DTUWr0pmNsStgG1BLPTgc6bdHdpwxS8LZkvsBPPE0S4ctDytIEc6HF3aX3?=
 =?us-ascii?Q?Ra5Uvyo/lBgIevBfiiXIed2j8gdc6Lc4nHmR/RMEVZ6ZKJTlVvry+IIN0apv?=
 =?us-ascii?Q?tC34zPf4NcyNtH4psYzBdWI9VxNxFb1T41YJC0XWRpDo6PY9Di9zW2bQiJxS?=
 =?us-ascii?Q?WOQTfmyjqyiZaR4GUxfKcZty81v3e9kICAtall2XdurR+X1YI1RdYGNZKIIq?=
 =?us-ascii?Q?CBQauKZm3/WgHDkQpu780PJiAJtsyjlOG7FwMxtFsAZPVi3GgxB5pSiH5tMW?=
 =?us-ascii?Q?+w1BYT+DzCmXk5bAcju/iVyvkwKh48o/Qf7HZ3LEK5Evc4xazch1bHDFHAUl?=
 =?us-ascii?Q?zDmePiF9iDmZnzs7QXHqSwfmmxMMbSFNhYxG8x+Pg16zTFIoMW1VqgrwtRH0?=
 =?us-ascii?Q?+Vf3ZpKPFBKpUxfNzuiLLNJVtYorsCe9iuh0wm1g/XA8KukrdyTtAcEuTtnL?=
 =?us-ascii?Q?4b4E4CpXOWzmjf+V4hYs3T97mSDVvmci1Z0Dne+ETCmtZpdj8fapLWHfCP+3?=
 =?us-ascii?Q?2xAY6ox2U6DgetOXcNsgzG/NEDj46nVdm0gHrPBU2pIzVY7/uPcqasWQnLNQ?=
 =?us-ascii?Q?B1yFFADxRtj66s98pnVbUcotMmY7mtszeZuxiKPb+UYYIhBmzCpA5HAybL2B?=
 =?us-ascii?Q?SRpQzG4P3FlbUNWTrEelFhu6QGE9Tmp0xhaYkAg98zpxkZdRzquPZaSl8wIl?=
 =?us-ascii?Q?PgxiZ/QX2iVSPiPBHvLbq9QwJKymo34fJIfPLGMq1UD7XjyqV9w6nqWmzO6b?=
 =?us-ascii?Q?+g+7a69tLIkZaqOPKb6HzcTicbX3qwh9UdNRYEggjwuOqRR4/dr4T7HQb7+z?=
 =?us-ascii?Q?fpJILhOAqcSzOBuMwxEN7ybvVkwK6NYaB4irjjveFjWJ1z0znzzFbBdbDK/8?=
 =?us-ascii?Q?+66cwQzwZRSULc7SSBDt2TjoIqAk3R/qLBgXczBCboTX/ZFCfiueYodcjr3U?=
 =?us-ascii?Q?jQcZXp6HX2CfADi8RqvTRkLNSTdR8Jb5EACzrqQYbq9zucHaXsUE6ICn8ZTx?=
 =?us-ascii?Q?E50U4klIIXFIDVfiDxwMuG7dBUl5F1Q0dwi/j3y/4iws44v6wK90IbavaMxN?=
 =?us-ascii?Q?ogqgUa24SKyHUmHvmvd53Y5dMHvUhlzQKeF711IqBn+qIsYAblo5WgWjtkXr?=
 =?us-ascii?Q?Su+RmRZRXrYzn+60ekAPfQpgCJaTEVM8keV5BchzOSAKQ6wM7IwFDoF7Sq9w?=
 =?us-ascii?Q?37x37+l7c1wGoLMN7nNQRUgcaCXpTYyEzGKDZrua?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ba231cb-cd91-4605-e067-08dc74b093b0
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2024 07:28:12.0663
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Mmz+ivEzzyNqLcdSua3oPHpWjM0Tf7s++6g2OnoMSnSL4yUiOJJPeBJSExubXgfzFWBKqRSygZLocSxuumyUzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6615
X-OriginatorOrg: intel.com

> From: Jason Gunthorpe <jgg@ziepe.ca>
> Sent: Saturday, May 11, 2024 12:29 AM
>=20
> On Fri, May 10, 2024 at 10:30:10PM +0800, Baolu Lu wrote:
>=20
> > diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> > index 35ae9a6f73d3..09b4e671dcee 100644
> > --- a/include/linux/iommu.h
> > +++ b/include/linux/iommu.h
> > @@ -173,6 +173,8 @@ struct iommu_domain_geometry {
> >
> >  #define __IOMMU_DOMAIN_NESTED  (1U << 6)  /* User-managed address
> space
> > nested
> >                                               on a stage-2 translation
> > */
> > +#define __IOMMU_DOMAIN_PASID   (1U << 7)  /* User-managed domain
> for a
> > +                                             specific PASID*/
> >
> >  #define IOMMU_DOMAIN_ALLOC_FLAGS ~__IOMMU_DOMAIN_DMA_FQ
> >  /*
> > @@ -204,6 +206,9 @@ struct iommu_domain_geometry {
> >  #define IOMMU_DOMAIN_SVA       (__IOMMU_DOMAIN_SVA)
> >  #define IOMMU_DOMAIN_PLATFORM  (__IOMMU_DOMAIN_PLATFORM)
> >  #define IOMMU_DOMAIN_NESTED    (__IOMMU_DOMAIN_NESTED)
> > +#define IOMMU_DOMAIN_NESTED_PASID                              \
> > +                               (__IOMMU_DOMAIN_NESTED |        \
> > +                                __IOMMU_DOMAIN_PASID)
>=20
> Yeah, something like that, I don't know about naming though..
>=20
> How about
>=20
> DOMAIN_NESTED =3D Attachment to RID or PASID
> DOMAIN_NESTED_PASID_TABLE =3D RID and the entire PASID space
>=20

this sounds clearer