Received-SPF: pass (google.com: domain of linux-kernel+bounces-179585-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>, Jason Gunthorpe <jgg@ziepe.ca>, Joerg
 Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>, Robin Murphy
	<robin.murphy@arm.com>, Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Nicolin Chen <nicolinc@nvidia.com>, "Liu, Yi L" <yi.l.liu@intel.com>, "Jacob
 Pan" <jacob.jun.pan@linux.intel.com>, Joel Granados <j.granados@samsung.com>
CC: "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v5 3/9] iommu: Add attachment handle to struct iopf_group
Thread-Topic: [PATCH v5 3/9] iommu: Add attachment handle to struct iopf_group
Thread-Index: AQHamw8FRMPPYVB/4U+b9NV7aZfqhrGX+wIw
Date: Wed, 15 May 2024 07:31:12 +0000
Message-ID: <BN9PR11MB52762A339B6E103369C22F068CEC2@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240430145710.68112-1-baolu.lu@linux.intel.com>
 <20240430145710.68112-4-baolu.lu@linux.intel.com>
In-Reply-To: <20240430145710.68112-4-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TlD9t+Y6748B/gJKfF5MNB1ZgNKezl8xfi4NegRVodBAxke4fRXfbhPddOB3?=
 =?us-ascii?Q?ybYsvI2IxLywcThxQvzGlEnKba+6Kk6H1EtvhZ68KK4FLYYUaTkVoBlpCQUZ?=
 =?us-ascii?Q?dtn6dvlXHdls6vQAKLpCKAVAIi2sSwVF11/HB/MwVa2oUd5tJ9Q6Bs1WRKnG?=
 =?us-ascii?Q?N4otcDW42J8YI57Ge3R/8SmSd5d5KzOTRxujI4ZwStFcGdI/5/rNTvFk0uLw?=
 =?us-ascii?Q?qmzMuO1BBkR2QQDAquN67VzaOth4BiD9vqePovC7GCKtcsoZO1wJmgBBM9tS?=
 =?us-ascii?Q?GkS8EmEHynfB4uKa8FAgBfdEjxfw229VCocVSw9UlszR96Qv5QzutzHcffg+?=
 =?us-ascii?Q?9HdX1e/blV0Rq2BYz3rD2IVajq10CVwTUqT8b8QDoBYp2y/Wp4urjpfQptPY?=
 =?us-ascii?Q?W376IvF/6RSgy3QeS9WL5/wMIOM4WgVeZQ8LZ0m0t3DqfI1qJ3+wE8+GUtPf?=
 =?us-ascii?Q?avJRzfgPFmIjuO0v3GXl0k7vu3PdVZEEqPKzXwMK64TzJBHOSfgG1rWsVxGF?=
 =?us-ascii?Q?yWAlX4BcAvEBHVMqKwfdg/CUm4Hv+dzroTRTVLnAABCxP5C81CZg0Y4kLkMA?=
 =?us-ascii?Q?I2Q3Nwfl+AQRvZpAxS52sHXV1efXeDWXeUH3WERYGSkvDrPT5PEn7RYe3WE4?=
 =?us-ascii?Q?6RF5nlHtrftv7uzxMbbJ9yQG3J7Tin5fcpuWVjTtjPmHtWAmWKDMsGhnNTLG?=
 =?us-ascii?Q?pBiTgTiT7ctFeQleJyJdMX2RMG5UC7GnWrMCpUzZCecSdhpaIKhDGT2qaPUo?=
 =?us-ascii?Q?V+NovRfrfZGJB9pbulDxd6NPhvDGl1cxtPtifaMuYKcJT9ud0A2918EW1DCL?=
 =?us-ascii?Q?VH6HquujjPFbhL1cWc5+7Mbs3gCs7SMikxDUpaZngTtZfATF6uL8yY+ZSvwA?=
 =?us-ascii?Q?sG3U6uWr3uUTIqiDkn2121oeWQjWi8H9cTiuvugvEDxx57w97feTda85i9Gv?=
 =?us-ascii?Q?4JwNDYo5sUjEk910pCuxAdSWnSWpbgfVtbi0W/LC9iKDGrfyxTh9bfZLqo1R?=
 =?us-ascii?Q?bBj1FxMG9rcRyfJa7wobbejiXWrlGSysHbStRAldyMbLKGiLeC32yUx+uYpH?=
 =?us-ascii?Q?6aDMnfr6JNon1zCmzlfJtyTf8KITSZzjkRXNtQyfsi17Hmb4DJ3pN/4Gho1r?=
 =?us-ascii?Q?BeJo62aWUfkg3sAgULpMZ6EWIs9mpESr/M8TN7P23qHzZWLeL+XRb3P1qtHc?=
 =?us-ascii?Q?OtFMeczlDNWGAwhvVs9wqX+R6t4Jvu49GNGDg8YkaB5mPbLlfbduIgHVM0VN?=
 =?us-ascii?Q?kBr823gQrrwz06doQlv8dVmDIn3HepBiQLOtav4Jfr9p6D9q+cz3LsfV/LCY?=
 =?us-ascii?Q?gdDwRtFZbt3mHuTTPnGTy9fZ6InGnRzWauRSGyHfWSPf7J3mGbTQuJR5ua7q?=
 =?us-ascii?Q?1MB4iKH7lt9+vq1oZPUKk0tBrK9pu0c8laTUe17TPUEOZKDv8YMQK6ARqi/u?=
 =?us-ascii?Q?W5JDEzIydQ3SqpvOqa0Ryk4tRJoPbTIt4YKyYe32jOggFidmIfaaY3/qECka?=
 =?us-ascii?Q?Yeys15EksHRpebQKDZskxxn8Wruk12f+WGQzRf2lgwfCdu7iA9Wv7kcWMHsE?=
 =?us-ascii?Q?S6l2UNGcivgLDkNyjJssMhjiRcoaqOPhCZytUMk7?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 960a5b75-1997-498c-83e8-08dc74b0ff68
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2024 07:31:12.7808
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mVjoaS8HaxdQIcYKvTYnj2etIIMZCDZH5vpTMJ7C8IIYykfxd7oAg4mpmYbNEvzoqv427WhU3Oqcihi7OAwfCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6615
X-OriginatorOrg: intel.com

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Tuesday, April 30, 2024 10:57 PM
>=20
> Previously, the domain that a page fault targets is stored in an
> iopf_group, which represents a minimal set of page faults. With the
> introduction of attachment handle, replace the domain with the handle

It's better to use 'attach handle' as the code does.

> +	handle =3D iommu_attach_handle_get(dev->iommu_group, pasid, 0);
> +	if (IS_ERR(handle))
> +		return PTR_ERR(handle);
>=20
> -	if (!domain || !domain->iopf_handler) {
> -		dev_warn_ratelimited(dev,
> -			"iopf (pasid %d) without domain attached or handler
> installed\n",
> -			 fault->prm.pasid);
> +	group->attach_handle =3D handle;
> +	group->domain =3D handle->domain;

this change also removes the warning message. Is it desired?