Received-SPF: pass (google.com: domain of linux-kernel+bounces-179613-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 15 May 2024 09:55:05 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Martin Faltesek <mfaltesek@google.com>
Cc: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
	stable@vger.kernel.org, patches@lists.linux.dev,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org,
	patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de,
	jonathanh@nvidia.com, f.fainelli@gmail.com,
	sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de,
	conor@kernel.org, allen.lkml@gmail.com, broonie@kernel.org,
	Vegard Nossum <vegard.nossum@oracle.com>,
	Darren Kenny <darren.kenny@oracle.com>
Subject: Re: [PATCH 5.15 000/168] 5.15.159-rc1 review
Message-ID: <2024051551-turret-distance-49d6@gregkh>
References: <20240514101006.678521560@linuxfoundation.org>
 <5beea8ed-b92b-4bee-b77b-4a3d57a5c001@oracle.com>
 <CAOiWkA8SNRbCPZ_gHQRczZovokZbFSJXQc1vUmtD0quZV9tp0Q@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOiWkA8SNRbCPZ_gHQRczZovokZbFSJXQc1vUmtD0quZV9tp0Q@mail.gmail.com>

On Tue, May 14, 2024 at 07:36:24PM -0500, Martin Faltesek wrote:
> Build failure on arm:
> 
> In file included from drivers/iommu/mtk_iommu_v1.c:22:
> drivers/iommu/mtk_iommu_v1.c:579:25: error: 'mtk_iommu_v1_of_ids'
> undeclared here (not in a function); did you mean 'mtk_iommu_of_ids'?
>   579 | MODULE_DEVICE_TABLE(of, mtk_iommu_v1_of_ids);
>       |                         ^~~~~~~~~~~~~~~~~~~
> ./include/linux/module.h:244:15: note: in definition of macro
> 'MODULE_DEVICE_TABLE'
>   244 | extern typeof(name) __mod_##type##__##name##_device_table
>          \
>       |               ^~~~
> ./include/linux/module.h:244:21: error:
> '__mod_of__mtk_iommu_v1_of_ids_device_table' aliased to undefined
> symbol 'mtk_iommu_v1_of_ids'
>   244 | extern typeof(name) __mod_##type##__##name##_device_table
>          \
>       |                     ^~~~~~
> drivers/iommu/mtk_iommu_v1.c:579:1: note: in expansion of macro
> 'MODULE_DEVICE_TABLE'
>   579 | MODULE_DEVICE_TABLE(of, mtk_iommu_v1_of_ids);
>       | ^~~~~~~~~~~~~~~~~~~
> make[2]: *** [scripts/Makefile.build:289: drivers/iommu/mtk_iommu_v1.o] Error 1
> make[1]: *** [scripts/Makefile.build:552: drivers/iommu] Error 2
> 
> This is from patch:
> 
> bce893a92324  krzk@kernel.org           2024-05-14  iommu: mtk: fix
> module autoloading
> 
> +MODULE_DEVICE_TABLE(of, mtk_iommu_v1_of_ids);
> 
> should be, I think:
> 
> +MODULE_DEVICE_TABLE(of, mtk_iommu_of_ids);
> 

Good catch, now fixed up.  I'll push out a -rc2 with this in it.

greg k-h