Received-SPF: pass (google.com: domain of linux-kernel+bounces-179631-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date: Wed, 15 May 2024 10:09:56 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	the arch/x86 maintainers <x86@kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [GIT PULL] x86/boot changes for v6.10
Message-ID: <ZkRt1IpAdtBBk0e4@gmail.com>
References: <ZkG4cMe1TFI5w7sc@gmail.com>
 <CAHk-=wgf=jwo1HZjQN7UeFw7iYPtQ_i0ri7JNOci+7Rn5-pDcg@mail.gmail.com>
 <CAMj1kXHm_tmBPNTvnvn3r6myeRo5x1fX3_J73UA1j4bVBo_PSg@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMj1kXHm_tmBPNTvnvn3r6myeRo5x1fX3_J73UA1j4bVBo_PSg@mail.gmail.com>


* Ard Biesheuvel <ardb@kernel.org> wrote:

> On Tue, 14 May 2024 at 03:03, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > On Sun, 12 May 2024 at 23:51, Ingo Molnar <mingo@kernel.org> wrote:
> > >
> > >  - Re-introduce a bootloader quirk wrt. CR4 handling
> >
> > I've pulled this, but shouldn't the compressed boot also just stop
> > setting the G flag that it didn't understand?
> >
> 
> I agree. But not setting CR4 to a known value is what caused the
> regression, and that could cause other problems down the road, so
> fixing it was arguably more important.
> 
> More than happy to send another patch to clear the G bit from the page
> table entries created by the decompressor, but at this point, it
> shouldn't make a difference.

Please - we shouldn't be creating page table entries with random G bits set 
in them. The boot code should at least pretend to maintain the illusion 
that it knows what it's doing. ;-)

Thanks,

	Ingo