Received-SPF: pass (google.com: domain of linux-kernel+bounces-179643-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Wu Bo <bo.wu@vivo.com>
To: chao@kernel.org
Cc: jaegeuk@kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] f2fs: fix to avoid racing in between read and OPU dio write
Date: Wed, 15 May 2024 02:32:19 -0600
Message-Id: <20240515083219.1601289-1-bo.wu@vivo.com>
In-Reply-To: <20240510023906.281700-1-chao@kernel.org>
References: <20240510023906.281700-1-chao@kernel.org>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?7Fpy1A5edgFvgx/7NkzNUhsBP/IBM+wtUCTsql+nYFnPulJf56A6ZpebgGV7?=
 =?us-ascii?Q?asWMBgPbHhyLdTitivVyEs1L7nphATsMNnHV7ihm8ZcfNbdLhFnQSqAE7ETm?=
 =?us-ascii?Q?dtQX4fsuShM0qRleYzUbtTdjr11aoABswjs3JWNxQmoeB8ntabBL89eSHbhz?=
 =?us-ascii?Q?yFkA1+tNAP3z/D/aB5nMu0OAnRwpDzKQBrC+Ap2kTquyL2IP26cojSycJoO+?=
 =?us-ascii?Q?Qob1jYOWgdGAJqT4U9tf8od8t2ZqIjN8YITtypS8ZMK3N/0iTsFPpC0iYfnh?=
 =?us-ascii?Q?TN4+LfTKNSUyG8Y94CmFTBCUbvUdVMdSR1B2Yz8q93IF8Fz9N9rcA672K5v+?=
 =?us-ascii?Q?U+W9ZIYytJt1+5+2/bXmH2Zuz+q23u041rOaufRDVcgg6qcykRcODI3wzx9j?=
 =?us-ascii?Q?3kyZDc5GrCIl/EtGTR1pkqMe6+HZmW0KpZM3jUvvyyNAawARH7m9yaH2G9QY?=
 =?us-ascii?Q?gZuj9gr/0pf+HFh2SeUgMWPjk3dfKpQw12t1uZAEJ78xS3yj0amWxwneES8/?=
 =?us-ascii?Q?2AMN8ZdjMNwSSK9tLRJS0JDeAJODZlCzRcev7mBVvrWdIxSrkMBrlSDQ1RQi?=
 =?us-ascii?Q?axmdy/2REX1YF6PMc+eve0r2dR9Yn5bRwvYyBBBp0zdKIV5rkXFzayYyiUpi?=
 =?us-ascii?Q?lp2EionLKrpoiF8uf+cvEJ7mc3aBL+wYLdkEPv55mVOOi/L/ugxUB4CDyZhP?=
 =?us-ascii?Q?MqMuXcmwLmN2xTPP14ktpter8kkURFO5w7EMEw/Gi/i2C56ocQRmI60TqPBE?=
 =?us-ascii?Q?xTDuITiu7cM+dK19/kEGdD96B6BxckFMZ15NtjNpABSwcjGGv4V4nXxIFsXe?=
 =?us-ascii?Q?btNflT7NSne2B1B+oKDwMklTO8KKJ8cD5TBLVla83G7EUmCftcGEqURD+wZH?=
 =?us-ascii?Q?bZOVWlWjZ/m3E8kW/yJ06MiyegYGWcP4dFBfrB55qYNi7BPl0DU2iUCDqPGh?=
 =?us-ascii?Q?OBOX/4GBU9EO5jnHsvuTGfaL9gZ6FrPwfw3botb2E9achv1yVOJwE5MKXvP4?=
 =?us-ascii?Q?Dekdn3admifRuUMFOfiFHLF16ajqaGo8GzoKU4ERtA/85qRHmSmcdZhJ+aZ+?=
 =?us-ascii?Q?3GICh4k5tGZjWVupxQ+U1PTskwNfCT+2Hge6YjZ+yrJZPVM6wIY7fYEGyO45?=
 =?us-ascii?Q?QEQBvRq/KMO7zHX9JXTx8HMR7ZjybNCmUGvA95cikw0ns4Av0hwqZa7IDXoN?=
 =?us-ascii?Q?v7UiW7OgpZuCwtUK5fknRT8Ja9yfMuxp3TgMNC8cDQUYUhEjdKNqwE1BvUS6?=
 =?us-ascii?Q?Zm4RJHZ25GCKZFYD7uCrsD9MplDJ0PHmEtSOcV/2AFBYP4/609oJspt7y/Cz?=
 =?us-ascii?Q?1nW1rseSZIciEhbw+B6Ijj9qYk2ohJjRrvlJ5kLdkEFMXhPS7HWIVgr48rk/?=
 =?us-ascii?Q?bKjH1eX0INNSGPfxGPYIJbuzCQpxpp1saMjWWwVsT2ilRLmCehEi6YM+7m5w?=
 =?us-ascii?Q?UzwGDDaS06eHajVeobomeqRxiPM7g2I7Oq9IKtioxY4pSeKMbdLSKKXNqwDk?=
 =?us-ascii?Q?BVJx+5GS6CD4xh5lxxoIf4iWPcfMQ/hYb3Mm+vMkFmp0HMhHs9NwMZPJ/HJi?=
 =?us-ascii?Q?f9Xuhy+gjs+gks4aMdx724T260y6PGy5VmXgmGeW?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c39aba8d-0796-4560-0434-08dc74b7ab21
X-MS-Exchange-CrossTenant-AuthSource: PSAPR06MB4486.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2024 08:18:58.2302
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ABc+2a7k5c3oupb8qj/foDiIhE5Db9XzLCW53eoy/NKR6LHBNaHJ/YAHaBf9zY1NnWqh6/GDn8aTJRH/eY84Jg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5044

On Fri, May 10, 2024 at 10:39:06AM +0800, Chao Yu wrote:
> If lfs mode is on, buffered read may race w/ OPU dio write as below,
> it may cause buffered read hits unwritten data unexpectly, and for
> dio read, the race condition exists as well.
> 
> Thread A			Thread B
> - f2fs_file_write_iter
>  - f2fs_dio_write_iter
>   - __iomap_dio_rw
>    - f2fs_iomap_begin
>     - f2fs_map_blocks
>      - __allocate_data_block
>       - allocated blkaddr #x
>        - iomap_dio_submit_bio
> 				- f2fs_file_read_iter
> 				 - filemap_read
> 				  - f2fs_read_data_folio
> 				   - f2fs_mpage_readpages
> 				    - f2fs_map_blocks
> 				     : get blkaddr #x
> 				    - f2fs_submit_read_bio
> 				IRQ
> 				- f2fs_read_end_io
> 				 : read IO on blkaddr #x complete
> IRQ
> - iomap_dio_bio_end_io
>  : direct write IO on blkaddr #x complete
> 
Looks like every COW filesystem would meet this situation. What's the solution
of other FS?
> This patch introduces a new per-inode i_opu_rwsem lock to avoid
> such race condition.
>