Received-SPF: pass (google.com: domain of linux-kernel+bounces-179646-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 15 May 2024 10:20:44 +0200
From: Manivannan Sadhasivam <mani@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Conor Dooley <conor@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@wdc.com>,
	Bart Van Assche <bvanassche@acm.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Andy Gross <agross@kernel.org>,
	cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org,
	linux-scsi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: ufs: qcom: Use 'ufshc' as the node name
 for UFS controller nodes
Message-ID: <20240515082044.GC4488@thinkpad>
References: <20240514-ufs-nodename-fix-v1-0-4c55483ac401@linaro.org>
 <20240514-ufs-nodename-fix-v1-1-4c55483ac401@linaro.org>
 <20240514-buggy-sighing-1573000e3f52@spud>
 <20240515075005.GC2445@thinkpad>
 <f6de4e1a-b3fa-457e-8819-041b2fb8739a@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f6de4e1a-b3fa-457e-8819-041b2fb8739a@linaro.org>

On Wed, May 15, 2024 at 10:03:36AM +0200, Krzysztof Kozlowski wrote:
> On 15/05/2024 09:50, Manivannan Sadhasivam wrote:
> > On Tue, May 14, 2024 at 07:50:15PM +0100, Conor Dooley wrote:
> >> On Tue, May 14, 2024 at 03:08:40PM +0200, Manivannan Sadhasivam wrote:
> >>> Devicetree binding has documented the node name for UFS controllers as
> >>> 'ufshc'. So let's use it instead of 'ufs' which is for the UFS devices.
> >>
> >> Can you point out where that's been documented?
> > 
> > Typo here. s/Devicetree binding/Devicetree spec
> > 
> > https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter2-devicetree-basics.rst#generic-names-recommendation
> 
> I read your explanation in DT spec commit:
> 
> "In a lot of places, 'ufs' is used as the node name to identify the host
>     controller, but it is wrong since 'ufs' denotes 'UFS device'."
> 
> but isn't this the same as with MMC? We do not call the nodes "mmchc" or
> "mmch", even though all of them are hosts, because "mmc" is the card.
> The same for most of other storage devices. Or USB. The term
> "controller" appears only for few cases like clocks, resets and power.
> 

The compatible for UFS HC is '*-ufshc', so it makes sense to use 'ufshc' as the
node name. But for other bus controllers like MMC, compatible just mentions
'mmc'.

And there were already nodes using both 'ufshc' and 'ufs', so I wanted to avoid
the confusion and just use 'ufshc'.

- Mani

-- 
மணிவண்ணன் சதாசிவம்