Received-SPF: pass (google.com: domain of linux-kernel+bounces-179664-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>, Jason Gunthorpe <jgg@ziepe.ca>,
	"Joerg Roedel" <joro@8bytes.org>, Will Deacon <will@kernel.org>, Robin Murphy
	<robin.murphy@arm.com>, Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Nicolin Chen <nicolinc@nvidia.com>, "Liu, Yi L" <yi.l.liu@intel.com>, "Jacob
 Pan" <jacob.jun.pan@linux.intel.com>, Joel Granados <j.granados@samsung.com>
CC: "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v5 6/9] iommufd: Fault-capable hwpt attach/detach/replace
Thread-Topic: [PATCH v5 6/9] iommufd: Fault-capable hwpt attach/detach/replace
Thread-Index: AQHamw8ICEBQlwyqhUGpWVI9yv+BvbGYEXTg
Date: Wed, 15 May 2024 08:43:53 +0000
Message-ID: <BN9PR11MB5276D582749AD8B619B11B688CEC2@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240430145710.68112-1-baolu.lu@linux.intel.com>
 <20240430145710.68112-7-baolu.lu@linux.intel.com>
In-Reply-To: <20240430145710.68112-7-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7qrcR6Jio2my2dRAHlxIy0GIEv7XhnmIN/B3q8C1NlFJJbcFnyVpsSIfeu5T?=
 =?us-ascii?Q?ax8Q8Q3vKnCk1s0h+VdvCdhUbG+5wdIuHQVPlyNIHKPUB5S7F3miT5N6WrNs?=
 =?us-ascii?Q?dXBmNOV2UJLV69gwI8JVuP4Z4NABORF1u4FqopvNAEw8lCuyC1gTKow1mIA5?=
 =?us-ascii?Q?DvuocCki9zzQ02q2Yv3AOehe/+ntv9mIcx5onxRasMNOG3ZCTETP0vwi6DEA?=
 =?us-ascii?Q?cmSzFyigQMhO6YVPQrJ0ydbTvhcNabVEyR0fO38JQOTGFehYjhQJS3wHTQrc?=
 =?us-ascii?Q?Js25EsiIdU4TVVY+14+9E3sOUonmTIdTRvDvcEkXm7gQ+yQDUFZJPlxgCadf?=
 =?us-ascii?Q?Vo7QTj/RKQ6+xi3m+8mQ43YQjcj4y0T1bL+JjgJQzvu+Pzqy5uiqo2JJf9j7?=
 =?us-ascii?Q?asBtCgFAWLm4S0t3g6bGq4FmdiBfftA4oYO4AdQ02TNl6CjAZ5qnrYmuP4UL?=
 =?us-ascii?Q?JmXLwHwd3YbPfEEVzX+KKowByRpaw9OeAXjPMihqB3wXM9Y1jmObahIlvFzm?=
 =?us-ascii?Q?DJ/YAZ43++xbeTq1YY9IXA1K8MhSimCKEXVaeenVBEG07KzzYiJcCGPA3Z6n?=
 =?us-ascii?Q?C5blWGFviGj4zgMxaJ2C/cKWU14pIXCzH/pn0RMeSg8dT5cvmEHfGb7Glv2c?=
 =?us-ascii?Q?oK7A2OoYUYaMC9RAhPeYwkawA/LSQ0LJtK8r1jFcH7XlPEvHKhBFDa8Ad4J+?=
 =?us-ascii?Q?USUuKiEa2c5Vcxrq6LJXFPorlvWjy/3dRJuGdESd2r9VQcTKz/6S0VcpKFgd?=
 =?us-ascii?Q?5tc9391COsyy74SIzTZ8kScYezc7B3ILXqrRgUz51z1NOEKNDFVYdcbkg8JG?=
 =?us-ascii?Q?M8V56nK92jN33uPddJUD7g2TGEr1rYOBEXUEvVRxEcDvWODmMAtFMV24wRzL?=
 =?us-ascii?Q?nbVZD98ZU9amAudzMB+ydvUn1FC+81mlcc0EZSn2kxNFQJa2Jja/rvpp97oC?=
 =?us-ascii?Q?ZkewAb5oVqgQoVJ0q/hf98GsKjfsCy0ZX/5j4Eaxn0iTZ7fpuuxOyVhzlcjR?=
 =?us-ascii?Q?DlvXbDvGR/QWergY0ChXe56E5IyIcKxRWOOHl13UWmXB1oyZ3jnthf8oZ2x8?=
 =?us-ascii?Q?863RjiN63Yoqtt9t2/TVa7T2Ud635dVigNiyApn4PpWoOyNMUm46jTePlaLJ?=
 =?us-ascii?Q?Npach9n5u907v2qWWYK0OmzpigUJeXVa85dq3oUKoWmu4qoAgB+AqPLyVijz?=
 =?us-ascii?Q?vW6hx4X6sFAsNilXZk/ftXHAQ6XgSOxNiE8w5CaWfd4GbVMy3Z6k8Dmt01y+?=
 =?us-ascii?Q?zsPs3V+hp34s3tuXbPf2l+j+fkdwJYW8N4JzVvo7a390M/TIpytMWmxPyrsh?=
 =?us-ascii?Q?T1qDSBj2cjpIdflIqZ25IyXa6Bdbu3mzRwy50paVXEIW+5KJazfsFUiTHXoD?=
 =?us-ascii?Q?NDpiI1e4mhflekiDLaWHOyeyVuaTgPksfhEexU3UPRbz8YI0rCKrZp90GKNM?=
 =?us-ascii?Q?C5cg6mIaGMaw78AKWMWegYDSnhVglBZy3WYNIZvEJEAUgO4qeWN6XEoyhAv1?=
 =?us-ascii?Q?ajlAHEUATG6HM2ikq5mAPAxYYR5Xq1ekmtMFdX6WyfaRAn55OecyaoXupbqz?=
 =?us-ascii?Q?cuHHZ61iAZ0ekCWszFQL0WKkLO6hP56ACZwCuiTz?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ea139bdd-a58a-4e20-10b8-08dc74bb26bb
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2024 08:43:53.6867
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 89dl3FD5L+nWCBQaGWmYwHMoOfW8aYDLyza3+lrlZDXZhSiGK6Vmd9geBUbZzArQWotolmRiH81n+GO0aYwJeg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6918
X-OriginatorOrg: intel.com

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Tuesday, April 30, 2024 10:57 PM
> +
> +int iommufd_fault_domain_replace_dev(struct iommufd_device *idev,
> +				     struct iommufd_hw_pagetable *hwpt,
> +				     struct iommufd_hw_pagetable *old)
> +{
> +	struct iommu_attach_handle *handle;
> +	int ret;
> +
> +	if (hwpt->fault)
> +		ret =3D iommufd_fault_iopf_enable(idev);
> +	else
> +		iommufd_fault_iopf_disable(idev);
> +
> +	ret =3D iommu_group_replace_domain(idev->igroup->group, hwpt-
> >domain);
> +	if (ret)
> +		goto out_cleanup;
> +
> +	iommufd_auto_response_faults(old, idev);
> +	handle =3D iommu_attach_handle_get(idev->igroup->group,
> IOMMU_NO_PASID, 0);
> +	handle->idev =3D idev;

why is auto response required in replace? new requests can come
after the auto response anyway...

The user should prepare for faults delivered to the old or new hwpt
in the transition window.