Received-SPF: pass (google.com: domain of linux-kernel+bounces-179666-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>, Jason Gunthorpe <jgg@ziepe.ca>,
	"Joerg Roedel" <joro@8bytes.org>, Will Deacon <will@kernel.org>, Robin Murphy
	<robin.murphy@arm.com>, Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Nicolin Chen <nicolinc@nvidia.com>, "Liu, Yi L" <yi.l.liu@intel.com>, "Jacob
 Pan" <jacob.jun.pan@linux.intel.com>, Joel Granados <j.granados@samsung.com>
CC: "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v5 7/9] iommufd: Associate fault object with
 iommufd_hw_pgtable
Thread-Topic: [PATCH v5 7/9] iommufd: Associate fault object with
 iommufd_hw_pgtable
Thread-Index: AQHamw8P/6/4oit4lU2Ra006NwpZoLGYE2jA
Date: Wed, 15 May 2024 08:50:56 +0000
Message-ID: <BN9PR11MB5276A8E898983310B83C399E8CEC2@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240430145710.68112-1-baolu.lu@linux.intel.com>
 <20240430145710.68112-8-baolu.lu@linux.intel.com>
In-Reply-To: <20240430145710.68112-8-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?U/hWFJBFr+aiRc/Ne2eOby2twHY0RmIQn2YVM7I0SPqhXfrlXrEPS5lj1kg9?=
 =?us-ascii?Q?j/hOnRAefhdGUqzq7A8oG4cNb1a+tgx+nx0ndR4UOHOFENoln8qUZwMxGp//?=
 =?us-ascii?Q?PfFiMI77f5UD5B9hHKIwzXtj6XUT/R8I6Wujj0OpYHVEcyte6QEihggwtVSF?=
 =?us-ascii?Q?bvj7n4d+hb26Z1M10qm9CFxcOp1/t3mFlEBjKJoTMCRLFhdw5khxURqTKilL?=
 =?us-ascii?Q?yqVlJ+HVYlSR7QgTKjEBFj17aF3JXTLs8i30kUkdfSoRb0b3Xlia3RX4YFsK?=
 =?us-ascii?Q?eBexVPPm7kOEOuk8r39o2yeCwy7x6ZmYyIN6md/I9Eufk8zZpflZhf80hzL5?=
 =?us-ascii?Q?nJCbUj7p7EaGEmkXO0H2dfdPl20cwU+eiDUaWveg+fmNNt44gQFwVXCUYfhS?=
 =?us-ascii?Q?nEWR0f8TfwP823KZ0p3UqkP5han+MIoC+Gr04I8YruWdRGEqhnYLy5wCb66/?=
 =?us-ascii?Q?wzYcYyIiOJCrar3GJ81XpDCo99vZWN4dk2EgcooLMqqZnJhdfIBkKsm1Wgmg?=
 =?us-ascii?Q?u/7is3HAUXFRZPHF4kb98hG9JjMixHvLCNh+/R6ETdeRhx6/7nGhBzdf7TSE?=
 =?us-ascii?Q?ZUhWbr+z1MLj92BRL1ggrGYMKf3f+Cdwn7SVGeAPE7U0p3GDBGI6yRO5CVRd?=
 =?us-ascii?Q?uUEePqPyn5FnJYgtOqq9iTIfoXU6LkbSKJ3eKoHg7LCBACskwkg6YTIlgXny?=
 =?us-ascii?Q?yoqZkO2HPRN/A8YfEVJNl6mhACTI1Aj6wrTMvUiKFG+oyICNbyZ0xeUvXBn9?=
 =?us-ascii?Q?jpdKYtsmMGtnUQ5F5KmgrTnO0SGawz6adTejX6qS24Ul6EODHCqC/T+jQZ2s?=
 =?us-ascii?Q?rPaKrxBuBxbXCYrzD6lRJQxlR/YCluuFQDswkNfi/ILa398J4N32PxNB7e7B?=
 =?us-ascii?Q?CNIs7M5nRpO90Yl4xqczH8SDU8TBIT+5KjGUOARz6kn5F6S7T6PCJ+t9ALdv?=
 =?us-ascii?Q?hqownZQ1N+pmNMFe3tcJ3ajkVOWVkS2Mm4IkWr0L1w2WN10wXhmAI4QI3FRb?=
 =?us-ascii?Q?IFn1W9+0RUMCEUZNVwhKshvPcyrLFdVONDY1D/n8w+1Rwoa9uMCmUXEuZUiH?=
 =?us-ascii?Q?nf0yReb0bL7Fe8tHT7LwhzOfgThWbRMD52EVNB1ULEZ3ApmuNzcZBg9iNYsu?=
 =?us-ascii?Q?q1LTL7PfXGzEzsA64e6g9oDj2h/iJx1goRxR/MP29FO5YCxv9fwC8te47yBF?=
 =?us-ascii?Q?WlnTqPp3kAu/JzcDXYCyU9sK+IqIGmj1PaYWOz3Cz0TPdPvfp2htIvKennw0?=
 =?us-ascii?Q?JlK0CFx36qgidQJqsrs/NLZDIR7uxqqYkITZcHy5o0ny2W3yIttda/l2ZMHG?=
 =?us-ascii?Q?kQ6wz9Ar8Gk4nkVniF5Ep5zFcgYa1ClBrnKWiRCRw8TDTOE06hldyYP5CYsJ?=
 =?us-ascii?Q?iML+L4xo3SGqYN9bVfsGhtwPJFmjZMOdRtVxVszDxM5YQbG6ATLOANbFIDyY?=
 =?us-ascii?Q?MEUPuJ8JKmTBzsyyyMd3Fd4xLuPV4XEgax7StKXmq5yXfSNFFUpr/2JTDmtn?=
 =?us-ascii?Q?qZRoXu+1Coaw4KApxbH3XJl9svZ6ga3vHgOC74rLzQHxXbKbT7v8BtzHV370?=
 =?us-ascii?Q?EcFUN1ljCK52mrqt0PiqrHOhQHHih5gwZg+xBHtw?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 87179ae2-d4da-4fbe-2314-08dc74bc2300
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2024 08:50:56.9554
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Lxme8ERbAZQgiZN+kIpnF4FyydbaKFx1JgspRrNhAiwTuhWso6dFTk+fIulUCq9yNGxM8uruW9GRWoopl1PE6A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6918
X-OriginatorOrg: intel.com

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Tuesday, April 30, 2024 10:57 PM
>
> @@ -227,7 +233,7 @@ iommufd_hwpt_nested_alloc(struct iommufd_ctx
> *ictx,
>  	refcount_inc(&parent->common.obj.users);
>  	hwpt_nested->parent =3D parent;
>=20
> -	hwpt->domain =3D ops->domain_alloc_user(idev->dev, flags,
> +	hwpt->domain =3D ops->domain_alloc_user(idev->dev, 0,
>  					      parent->common.domain,
> user_data);

it reads slightly better to clear the fault bit and still pass in flags.

> @@ -308,6 +314,19 @@ int iommufd_hwpt_alloc(struct iommufd_ucmd
> *ucmd)
>  		goto out_put_pt;
>  	}
>=20
> +	if (cmd->flags & IOMMU_HWPT_FAULT_ID_VALID) {
> +		struct iommufd_fault *fault;
> +
> +		fault =3D iommufd_get_fault(ucmd, cmd->fault_id);
> +		if (IS_ERR(fault)) {
> +			rc =3D PTR_ERR(fault);
> +			goto out_hwpt;
> +		}
> +		hwpt->fault =3D fault;
> +		hwpt->domain->iopf_handler =3D iommufd_fault_iopf_handler;
> +		hwpt->domain->fault_data =3D hwpt;
> +	}

this is nesting specific. why not moving it to the nested_alloc()?