Received-SPF: pass (google.com: domain of linux-kernel+bounces-179707-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <6d994163-abc3-4519-becd-b3813a43bf49@intel.com>
Date: Wed, 15 May 2024 11:31:18 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net] idpf: don't skip over ethtool tcp-data-split setting
To: Michal Schmidt <mschmidt@redhat.com>
CC: Jesse Brandeburg <jesse.brandeburg@intel.com>, Tony Nguyen
	<anthony.l.nguyen@intel.com>, "David S. Miller" <davem@davemloft.net>, "Eric
 Dumazet" <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, Przemek Kitszel <przemyslaw.kitszel@intel.com>, "Michal
 Kubiak" <michal.kubiak@intel.com>, Xu Du <xudu@redhat.com>,
	<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
References: <20240515092414.158079-1-mschmidt@redhat.com>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Language: en-US
In-Reply-To: <20240515092414.158079-1-mschmidt@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUh1WGhwb2RGMFhkVjFLYVB4ZzhlVkdwb2ZGdHFsblVkenpEWVQvemduQm91?=
 =?utf-8?B?M2VDcWRNcUtXL0hwRHdQaTdlVDZZNVV3Rk12czh4UUFHTTk3Q3JMZGp2Nlha?=
 =?utf-8?B?NEQ1WHR1ejVhclhDZmRkRVJKdkpKWk9paTdWOVg2cSs1TFNscUdIeHhTNXds?=
 =?utf-8?B?Wm5uY0ZaY0tzVFpoU3RaVUNzamxVeTNaRWIwVGc0dmFzN3IrRUsyT2FOcGl1?=
 =?utf-8?B?MnZMVUMyZ3RQUVY0a1h2NEx1TjlBQkZscDFwN0FndFZUMUV2TlJnRk9sZE5M?=
 =?utf-8?B?TXZZR0FVTjJxSlgyMmZQZmpRRkc2UWNzN3NpdGxMd1pSczNsbHhBTjVIZ2pR?=
 =?utf-8?B?UzkzRjB0aDFHR1ErbmZvSHY4UkVEK1FEak5SZGVQZklsN3RadnJxa0VkZjRJ?=
 =?utf-8?B?Vk9ySXA2TkUwUWlZdjU2aTZsTjJxWUhOa2R1djNadmkybEljdm9pWGVyM2Er?=
 =?utf-8?B?aVJvVTNpWWdMTGk4UXNoby8rNDZhWUswRU5KNkFBUG9kYmIwN29vUGNDeDRK?=
 =?utf-8?B?SlhDWWxWdUs5bWFPK2lYUVRRazFkR0Fwa0xQZU03bGsyM3djRXlLNEtnTW9O?=
 =?utf-8?B?R3RVV0ZKWTFpQnNEdVRVYzRROU9xdC9BQXFiV3piUDZmOXk5c2FpdDMzWTVO?=
 =?utf-8?B?czVDRWM4Zm41cXc1Y1FVSFdwMmQreGhTWnh6RTJxZlg4WWpzRGpWZ1JtMnNW?=
 =?utf-8?B?RkgvdTkzMUFmL1liYndIakZjcnN4M2JyRzAxZmRnWHJ1ZXYyQzNRSDJKTkJG?=
 =?utf-8?B?cGt2YS9lUEJlL2RyUFlZN0tPYVo3QWN0SE12RFN2K0M5YVRkNmgzZFIwdVVW?=
 =?utf-8?B?czNBeWRIRW9kYXN4UFdCRi92Qmc3dkJCZnVoZXF1TnpKckNpbXVkbEFveE5o?=
 =?utf-8?B?ZjVZMXdpblY3N0IwYjdDMXBOYUVZY2VFbGhaK2MrSkFHTHJlZnVDSitscndR?=
 =?utf-8?B?Wm9zV0JDODJsRTNlRGVtUmNNUWJvLzF0aklTT2hVREdKaHRsbWkyMUlOdlp6?=
 =?utf-8?B?SjcwZjdGQTZ0c3paeUZ5UVM3bEZjS2ppc2NzMWg0bnF5cmZtUEhZOU9rMm15?=
 =?utf-8?B?enliREpXS0s1RTZUUzR1TVBVaithTU9Ub3pNWEZjcXRZRnptV0tTZ0xqRS9u?=
 =?utf-8?B?TWVydXQvRGNrYmVvNDh4VzVmNzR4NnRobURiRjkvY21oYktreVlTUldJMUZl?=
 =?utf-8?B?bzIwUzgvK3FrSFI4YnY5cWNtancyN2lHWEtDQmgwSFdnd0hDbEgzVTc1aW1s?=
 =?utf-8?B?V2g0MmRpR0xLNEpaenp2dldWRm9aOTRDQk5NMlZqc0l3Tjd1b0hxZERqeEgv?=
 =?utf-8?B?ZWdFVUFhWTZ3T2FzUVhTZjlPMmMxeFNtOVpzSEdyRjhXekI3dlNZbXp2SHRu?=
 =?utf-8?B?MEZ5N2lkU1p5T2Zxa2xRNjJFaVVwdEt6WW43RUxEbW93bzN3NnBZbkl2Mmxh?=
 =?utf-8?B?djVHcE1ucDFFNnZhajZEa0xOaDY5ZFR2K2dSMkx3dHd4TWlFSnpJVTVTVUgx?=
 =?utf-8?B?NUVJb0x5TVM0Q1gvVTFOSFRIbEZuOWF4L0ZzQzRWOWtzWWtVbUpjcjVpK0Q2?=
 =?utf-8?B?K21JQjZwSEpsV2g3cFJNK2JraHYvVGFaREVKdTJYRGc2N1VveWllbTRURDlU?=
 =?utf-8?B?Tk5rUm50SDV3dVowNFRreHB6Z251VFFWcEVIVld2VVhVdGVwSFFodkI2UVBW?=
 =?utf-8?B?c2ptK1NiQXl6UWs5MzZ4OHpPTnZ1REREcFlNTE9yYVNJYzJONHRPQUxkQXZ6?=
 =?utf-8?B?U3NzOU13QVRCeFhsQzZ0WFlGa1lyYUJnYlhCTzhHY3d1aVM1bnpLcnA3bW5Y?=
 =?utf-8?B?WUZFTERkZjVEMWtScE14T0N2RjUwU1VHRm9KREZ1dHNJMmJ5NllacGJ1allO?=
 =?utf-8?B?SittYlIreFFLZXVLTTlUV3VzTlAzbmkzdVpVTlBjSnZVdUpqN2RicGlIRUw1?=
 =?utf-8?B?UkpkTTJEcEVQcnZPMVlyVXBJN3VUWlluSUowYUZwdlVCQ0JiamlaY3N1cWpy?=
 =?utf-8?B?d3BYMzdhYnlVMHlRM1dUanNrSEFQNGZxaUF1ZVJLeDZOQWg0L1EycUhiK09F?=
 =?utf-8?B?RkkxN0ZCTnczNVh0THpjL0RTbW1OM2NYQUxjaWxMbU5YSHBTdzhORUNlZGxh?=
 =?utf-8?B?cnNsL1hNMDVXbFFxTElVWU01RWo4bDM5Qm1weXNVR3Q5TnJYZ245bDlFYWFV?=
 =?utf-8?B?ckE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f2fb8d20-9ca9-4720-1245-08dc74c1f606
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2024 09:32:38.7075
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QYqMr/mck0NvZglFB6p9d4DxxYFmeLB9WaLHSsjV/JEw9qhLC+lNHUrMk6vxZDR2KJVR/aok+yzRBp8pFkHRKAJmjVZ7eILBoquiBWkVlTg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR11MB8368
X-OriginatorOrg: intel.com

From: Michal Schmidt <mschmidt@redhat.com>
Date: Wed, 15 May 2024 11:24:14 +0200

> Disabling tcp-data-split on idpf silently fails:
>   # ethtool -G $NETDEV tcp-data-split off
>   # ethtool -g $NETDEV | grep 'TCP data split'
>   TCP data split:        on
> 
> But it works if you also change 'tx' or 'rx':
>   # ethtool -G $NETDEV tcp-data-split off tx 256
>   # ethtool -g $NETDEV | grep 'TCP data split'
>   TCP data split:        off

Oh crap >_< I'm sorry, thanks for the fix!

> 
> The bug is in idpf_set_ringparam, where it takes a shortcut out if the
> TX and RX sizes are not changing. Fix it by checking also if the
> tcp-data-split setting remains unchanged. Only then can the soft reset
> be skipped.
> 
> Fixes: 9b1aa3ef2328 ("idpf: add get/set for Ethtool's header split ringparam")
> Reported-by: Xu Du <xudu@redhat.com>
> Closes: https://issues.redhat.com/browse/RHEL-36182
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>

> ---
>  drivers/net/ethernet/intel/idpf/idpf_ethtool.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
> index 986d429d1175..6972d728431c 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
> @@ -376,7 +376,8 @@ static int idpf_set_ringparam(struct net_device *netdev,
>  			    new_tx_count);
>  
>  	if (new_tx_count == vport->txq_desc_count &&
> -	    new_rx_count == vport->rxq_desc_count)
> +	    new_rx_count == vport->rxq_desc_count &&
> +	    kring->tcp_data_split == idpf_vport_get_hsplit(vport))
>  		goto unlock_mutex;
>  
>  	if (!idpf_vport_set_hsplit(vport, kring->tcp_data_split)) {

Olek