Received-SPF: pass (google.com: domain of linux-kernel+bounces-179684-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 15 May 2024 10:57:55 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Yabin Cui <yabinc@google.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	bpf@vger.kernel.org
Subject: Re: [PATCH v4 1/3] perf/core: Save raw sample data conditionally
 based on sample type
Message-ID: <20240515085755.GC40213@noisy.programming.kicks-ass.net>
References: <20240510191423.2297538-1-yabinc@google.com>
 <20240510191423.2297538-2-yabinc@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240510191423.2297538-2-yabinc@google.com>

On Fri, May 10, 2024 at 12:14:21PM -0700, Yabin Cui wrote:

> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index d2a15c0c6f8a..9fc55193ff99 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -1240,12 +1240,16 @@ static inline void perf_sample_save_callchain(struct perf_sample_data *data,
>  }
>  
>  static inline void perf_sample_save_raw_data(struct perf_sample_data *data,
> +					     struct perf_event *event,
>  					     struct perf_raw_record *raw)
>  {
>  	struct perf_raw_frag *frag = &raw->frag;
>  	u32 sum = 0;
>  	int size;
>  
> +	if (!(event->attr.sample_type & PERF_SAMPLE_RAW))
> +		return;
> +

Should we add something like:

	if (WARN_ON_ONCE(data->sample_flags & PERF_SAMPLE_RAW))
		return;

? And I suppose the same for all these other patches.

>  	do {
>  		sum += frag->size;
>  		if (perf_raw_frag_last(frag))