Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp3269900lqo; Wed, 15 May 2024 05:06:27 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXbpQymjOe7xMP0QCxNDwkMbso2wNBGZgzanB3NhAE4xXuziKN1lVx6KjkT2ApTvlen70JsQpJN7IBAJHVspCacZzyxenVQAIKXQ0dbiQ== X-Google-Smtp-Source: AGHT+IF+18E9/6Xp5qkqzQuej20bEuQ2Wdr5BZ7oGB2HmnD9vlgNHnrjlr5qbXLhSgAyTnnZd5HM X-Received: by 2002:a05:6214:488e:b0:6a0:7d91:1adf with SMTP id 6a1803df08f44-6a1681b9566mr200881376d6.35.1715774787117; Wed, 15 May 2024 05:06:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715774787; cv=pass; d=google.com; s=arc-20160816; b=AdtSlWURk1CnpdSNGvkKInxv6URegaINSgmF/Fud6gfuGaxpThcvMz0i71Mp8xb5v1 XGoklTJ0YcbZPVKhKNc7oz2/xL+UwoPgzZonTtmkATuzoahfv9DoajOUyQfJ5L1fJnzs DfxxNbaCZQjL18e7OQg6jRe+T0rMEGvKVhSIeKkUdCaEsJxaouP+uOCvRQRD1IkthqlQ H9dA7AFjgPUgNa0CKpc77MRKPBkyNvM9Xpnn3NQXG3yLZ8x5sOHFhTUVkCbNcMN0Kz4X PlSpy9nWHcdmTFgmeQXbgWC7dVYSmm0519ajnWvIPdTUgkdYiHtorwlIg70/dwrUCNMl AW+Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=rJYF6H91YS9YSoXm+Tl9JERoBMf7eBC9ZSy+O3IfVoo=; fh=ikuGIGnEw8MNR939KzINN7GDyXC8nzVFFlYluoNFp9o=; b=aBLjlNvU7lNhL4aWQgO/eDlPh8pk8SvndWpZ+o681jXIXsJx19auwdFMzQ/CM79u6L h8hNMwdWQ4vATGCaOdbynQcYS+hB0RuVM0d5YQR1w7KcYH9tILxcACarDf6vKk8FbVMP zJzImIbPmfDIZGF1vGPWzDUzRwhDUPG+I8Iw7XKhO9KXHkGFifBjE+T6h9J5ZALWc+BE bolj4Ah/mig8btRJY/bWZKZxOY4hDDm9BEdlfYTLacchC1gihOMPDkD3UiVGyVvzvmQ6 nKLU7ss3CnGqVFtJ2qMK/tiKWHzkcY9WU2usroahHnPCn4Q8q5GFEzTo9XsMCnHTahGY QRYw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@layalina-io.20230601.gappssmtp.com header.s=20230601 header.b=u6H+7BQb; arc=pass (i=1 spf=pass spfdomain=layalina.io dkim=pass dkdomain=layalina-io.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-179827-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-179827-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 6a1803df08f44-6a15f20a06dsi135793146d6.179.2024.05.15.05.06.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 May 2024 05:06:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-179827-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@layalina-io.20230601.gappssmtp.com header.s=20230601 header.b=u6H+7BQb; arc=pass (i=1 spf=pass spfdomain=layalina.io dkim=pass dkdomain=layalina-io.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-179827-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-179827-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CA22A1C21CCE for ; Wed, 15 May 2024 12:06:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F345374432; Wed, 15 May 2024 12:06:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=layalina-io.20230601.gappssmtp.com header.i=@layalina-io.20230601.gappssmtp.com header.b="u6H+7BQb" Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8540F2CCD0 for ; Wed, 15 May 2024 12:06:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715774778; cv=none; b=RNwpc5QegBZR7Y3k410+hzDTyP4mXvH1AF93765ZFGMxkFW9/7UdD5gOUrJNRSZmY4PmWafFSTSJvn4sxqHJMLQcWjfTLTARz2NHO9p2kQeo6BgDIfKw9GMOWk4HluK/JgNpGEPUd5RjGr69d8Yxid7eaUR+3b5iRewvAs33pvY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715774778; c=relaxed/simple; bh=Wf4PtMcK4TWbBm/o2EnpN3Y26qLxkxka0G6bwrOg3aA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YKH0e/q7YZ6Nsg9WBprWzP51xOGDdeDbFReD4hdKqUt/UjaKGSXxXZcdebg0syq6XXMRWhe0ieYSIBZWHbZuPdXvxLatlaaY6yPkq2XfSQlw6ykMgMQ12sbSdRPpDHHJZLIyGBzo0E0PgesQ7lSsMPVzZ4WC79CKvKieFqFX8Bg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=layalina.io; spf=pass smtp.mailfrom=layalina.io; dkim=pass (2048-bit key) header.d=layalina-io.20230601.gappssmtp.com header.i=@layalina-io.20230601.gappssmtp.com header.b=u6H+7BQb; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=layalina.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=layalina.io Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-41fd5dc0508so45556045e9.0 for ; Wed, 15 May 2024 05:06:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=layalina-io.20230601.gappssmtp.com; s=20230601; t=1715774775; x=1716379575; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rJYF6H91YS9YSoXm+Tl9JERoBMf7eBC9ZSy+O3IfVoo=; b=u6H+7BQb9llJ+GoUyqhx9nL12eq1QZTpEYwVKf4L6Kk8pxybMMa6wGPamt1Bg1ep4d C/lsdKjdJeZdXwMLWp5fxgO6nHcC9zVgGTXn9zymZ6xqiiOGQW4rrxGI9jgMEd1nbgYA 3zZ5OzYV1RLUm4QAEl4pAqnDflIDLagY3fotksWvN5G5S8JQRnwavg71k78sQdNQSyGG eNyDwXYPYfDTTtrAth6G5gdKHPHtbfOX2QJbdr59n1S9no5Kz15fhFmCr3jnxK5+YEqu ve6MqQrYhJPoB6C1CRuR5F1dkin6pAE07+u2g+nP8Yhoa3ZGe855d6flwjmZT/e1NoCt ZGUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715774775; x=1716379575; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rJYF6H91YS9YSoXm+Tl9JERoBMf7eBC9ZSy+O3IfVoo=; b=sIutzkaz718BQv40C6I8N9fQN1xfkvGpJwbW6lqltLr5ESel5MKP01pW1tIbHgR4az Zd9iKLxQUpi+PGiMyV5xbWuWLY+mW/nsTiCa0H8n6C7w55qPkUsyIZSXY1tBGgo6Wm/p uONnIiu0+TMPRKtV1szLUDmToP03JXBfHCzifVDB8tCTZoqOTfcOxUJpobkFEmPBeWRP U6Ly1awKSPd/VsqSTqj61klu9faA/xQfj//hSHG0RzJrtjKjUTKBSgMvS9tTF9nbmyo5 nhTX11mtJepnEffN/C8DEYtpx//VLib6EYqxY7SFdimopMNukDgpYbI1QHnNYCPeKEhW dGqg== X-Forwarded-Encrypted: i=1; AJvYcCVM6a2KYcal0fyuEiSkwLJ9tqmEo62vHt3/16UeAvWITVAjOS2BMjP3r1hZMWcWH26Ypytt07jCO28FfriPu5L95Mo+LGuSJ6dmgy6I X-Gm-Message-State: AOJu0YyXt5p3DC08P0kCEg4g9pZhCnxQOhRU8SR11f4AUID9+fQuuIeF 8T2GtDtF1ugisykjAnzw7cpm0Ib8d7s3Inxk6M7QihmBL+F8k0J8bj2+RK1hyqs= X-Received: by 2002:a05:600c:2187:b0:419:ec38:f34b with SMTP id 5b1f17b1804b1-41feaa439d6mr115391895e9.20.1715774774868; Wed, 15 May 2024 05:06:14 -0700 (PDT) Received: from airbuntu (host81-157-90-255.range81-157.btcentralplus.com. [81.157.90.255]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-41f87d20488sm266011555e9.25.2024.05.15.05.06.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 May 2024 05:06:14 -0700 (PDT) Date: Wed, 15 May 2024 13:06:13 +0100 From: Qais Yousef To: Phil Auld Cc: Peter Zijlstra , Ingo Molnar , Juri Lelli , Steven Rostedt , Vincent Guittot , Daniel Bristot de Oliveira , Thomas Gleixner , Sebastian Andrzej Siewior , Alexander Viro , Christian Brauner , Andrew Morton , Jens Axboe , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] sched/rt: Clean up usage of rt_task() Message-ID: <20240515120613.m6ajyxyyxhat7eb5@airbuntu> References: <20240514234112.792989-1-qyousef@layalina.io> <20240514235851.GA6845@lorien.usersys.redhat.com> <20240515083238.GA40213@noisy.programming.kicks-ass.net> <20240515112050.GA25724@lorien.usersys.redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240515112050.GA25724@lorien.usersys.redhat.com> On 05/15/24 07:20, Phil Auld wrote: > On Wed, May 15, 2024 at 10:32:38AM +0200 Peter Zijlstra wrote: > > On Tue, May 14, 2024 at 07:58:51PM -0400, Phil Auld wrote: > > > > > > Hi Qais, > > > > > > On Wed, May 15, 2024 at 12:41:12AM +0100 Qais Yousef wrote: > > > > rt_task() checks if a task has RT priority. But depends on your > > > > dictionary, this could mean it belongs to RT class, or is a 'realtime' > > > > task, which includes RT and DL classes. > > > > > > > > Since this has caused some confusion already on discussion [1], it > > > > seemed a clean up is due. > > > > > > > > I define the usage of rt_task() to be tasks that belong to RT class. > > > > Make sure that it returns true only for RT class and audit the users and > > > > replace them with the new realtime_task() which returns true for RT and > > > > DL classes - the old behavior. Introduce similar realtime_prio() to > > > > create similar distinction to rt_prio() and update the users. > > > > > > I think making the difference clear is good. However, I think rt_task() is > > > a better name. We have dl_task() still. And rt tasks are things managed > > > by rt.c, basically. Not realtime.c :) I know that doesn't work for deadline.c > > > and dl_ but this change would be the reverse of that pattern. > > > > It's going to be a mess either way around, but I think rt_task() and > > dl_task() being distinct is more sensible than the current overlap. > > > > Yes, indeed. > > My point was just to call it rt_task() still. It is called rt_task() still. I just added a new realtime_task() to return true for RT and DL. rt_task() will return true only for RT now. How do you see this should be done instead? I'm not seeing the problem.