Date: Thu, 31 Jan 2008 13:18:23 +0100
From: Ingo Molnar <mingo@elte.hu>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
       Thomas Gleixner <tglx@linutronix.de>, Andi Kleen <ak@suse.de>,
       linux-kernel@vger.kernel.org, Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH 5/5] x86: EFI memory mapping changes according to
	changes to ioremap and c_p_a
Message-ID: <20080131121823.GF12571@elte.hu>
References: <1201764968.12950.26.camel@caritas-dev.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1201764968.12950.26.camel@caritas-dev.intel.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1105
Lines: 30


* Huang, Ying <ying.huang@intel.com> wrote:

> +			/* Assume pages are mapped as WB */
> +			if (mode == IOR_MODE_UNCACHED)
> +				set_memory_uc(md->virt_addr, md->num_pages);
> +			/* Assume pages are mapped as unexecutable */
> +			if ((__supported_pte_mask & _PAGE_NX) &&
> +			    xmode == IOR_XMODE_EXEC)
> +				set_memory_x(md->virt_addr, md->num_pages);

hm, why is the check for __supported_pte_mask needed? That is already 
listened to in set_memory_x(). [if not then it's an ioremap bug that we 
want to fix.]

> -static int ioremap_change_attr(unsigned long paddr, unsigned long size,
> -			       enum ioremap_mode mode,
> -			       enum ioremap_xmode xmode)
> +int ioremap_change_attr(unsigned long paddr, unsigned long size,
> +			enum ioremap_mode mode,
> +			enum ioremap_xmode xmode)

hm, there should be no need to use this raw API.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/