Received-SPF: pass (google.com: domain of linux-kernel+bounces-179869-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: "Wang, Wendy" <wendy.wang@intel.com>
To: Zhenyu Wang <zhenyuw@linux.intel.com>, "peterz@infradead.org"
	<peterz@infradead.org>
CC: "kan.liang@linux.intel.com" <kan.liang@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>, "Zhang, Rui" <rui.zhang@intel.com>,
	"Bityutskiy, Artem" <artem.bityutskiy@intel.com>, "Wang, Wendy"
	<wendy.wang@intel.com>
Subject: RE: [PATCH RESEND] perf/x86/intel/cstate: Add pkg C2 residency
 counter for Sierra Forest
Thread-Topic: [PATCH RESEND] perf/x86/intel/cstate: Add pkg C2 residency
 counter for Sierra Forest
Thread-Index: AQHapnXYp7BVl2jRbkOSt3m7I3nZC7GYP3rg
Date: Wed, 15 May 2024 13:01:36 +0000
Message-ID: <SA1PR11MB84900A6023E6F9856A928A779FEC2@SA1PR11MB8490.namprd11.prod.outlook.com>
References: <20240506084806.495816-1-zhenyuw@linux.intel.com>
 <20240515032158.12845-1-zhenyuw@linux.intel.com>
In-Reply-To: <20240515032158.12845-1-zhenyuw@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VR+Zs1sy9JTd099m7/LtQ0q2RmhfHPF+gvm1h9z8kydcyO1ANZ8ls1OZzaDC?=
 =?us-ascii?Q?c2u6XNzaqJshw4hXQtAoo+fRqO6nQUeKYyGeOjvzAU26hBsmDriKT66IpcsL?=
 =?us-ascii?Q?iHeTTC+96dmfM3LwB0VOTX05bqNrrbwPZgiJPrQvdaFGK6w0tRXf/A7BJDQA?=
 =?us-ascii?Q?96aUWhwQ9haAba4fS5pdKHWdCXuhBVHVPmmD6Ju0E/BgjMQTlYn2JXaafMch?=
 =?us-ascii?Q?+4AYo9WmF7OgNYOm58BH2mr2Hjqmvh0KtDAL6ZcX1O2xGIvmj0OF52NoTUJn?=
 =?us-ascii?Q?+aOKbvaw28s+E0KwPeA8+Bkj+qbKBWJysNg5uaQl//uTn0iRHZLTk77FfBjQ?=
 =?us-ascii?Q?nWTfCIbCp92MDKgJF2OZvCvTepkC5iScPE/cN059uK+TV3+SgycTQi2eC45K?=
 =?us-ascii?Q?gMhqYZ9j6liG2wdt/0Lz7QcwB+W523+wvY45tlIBN2cx+y9IsHIJFbgEkXkW?=
 =?us-ascii?Q?9iGPwcYRzVXaLXAKl7OGSkUvfyBEDQLHTkf8A54zjQZs/O98FOLU+Uj5L1Zv?=
 =?us-ascii?Q?Ecz7R37uRyY+VOVyVf2qnw/P17XgTHfB5mZQ+kWF54vVdBmhMdQZ0bWGJMmm?=
 =?us-ascii?Q?jVILtI4KYkDb7CSU1u/DXY5F8lXXBSaWYZ5V/GRDvku5NDsymTFBsrs+0v2/?=
 =?us-ascii?Q?LVsgB4FJnuiXwB8JGnORK16cAxzvaS/23YBNhDf3e17PkFkUyhtrS+OMZ3DE?=
 =?us-ascii?Q?4UNSrj1cb3goeoQ2QY+Io5NLArdOaWd4wBxrVAX8LNknQFeHhEIL4ZNNPcim?=
 =?us-ascii?Q?ghMewDl54QWtLfj1pavNon4hY+gGej27qnIZTrTecYwvbP2Admo67Vgqhr/l?=
 =?us-ascii?Q?Ex9OgIDhw/spvO+be5CiubNBd3+YqXkytXTaC6pTusJT2gVigozQIkdukaKn?=
 =?us-ascii?Q?5fFUjOFCojGLWC8A+ayeVDHAwxuAQw81m68Y/+Xmu/y9yU/m8Nvgc8zTSPPH?=
 =?us-ascii?Q?vomvzuHbQj/9OTdFHG2GJw1RjCKupSJxmc5l4vlBljVvduNN6p9vfRf08vAK?=
 =?us-ascii?Q?3Bgfe+Gr8MfBiSGbcOhXvm6Rs48UNYefHfAebTsDRIt8706TEG07EoOIqEnn?=
 =?us-ascii?Q?dAtue9V9NMl/hQ888wUWrhhcQIga1M9csgiiDS7M3EJxBBnIrThpU4x/wqbB?=
 =?us-ascii?Q?MsQ4ukAnNaiB92EbS8z93x0tHf3bWxmI0fsKW+mNAif3+MOa9dcgA/lqhQGy?=
 =?us-ascii?Q?+M8BCFBPWNM+tAm7t+LZzQ0ZUNP7AireuRggsSFsstm5go8Kup4U8iIYNiG2?=
 =?us-ascii?Q?Nug1zcbs31Qrwz3Cv4jzQOLkgpO24bJUDNe5VxPWn76YesFBYhTi7UHM9ri6?=
 =?us-ascii?Q?2oHy5Omt907x8TM1ISw/mIWjgJrFsa0vJEPBjbu81oYQ0WmECv2otG743AVd?=
 =?us-ascii?Q?cgb3cSknM6F103GGCi4GtM0qPS6skTr1PZ2CzT7SXiH0ZtI1acGIOxoz31ot?=
 =?us-ascii?Q?EdBriJdeJCtXSecnwI3VELBiAVD3jkcbS6DFTCvJoELfM+161dRah6En/4ra?=
 =?us-ascii?Q?VHz+Qr8mkVZTEaby/aKbFjMn/CNOK0Laey6MwJsgsS4PZE4HoyQe7vcOMuH7?=
 =?us-ascii?Q?dFhgaIny+Lg35R834sSRBWuiFUO0Pnjc+bfxBWmN?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB8490.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b65203aa-00ff-4b15-99bb-08dc74df2735
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2024 13:01:36.3897
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YU0MbBtICJkCAT5yyneTbvAROo//y0tbr78pwO83lp+pULbg1BhbHKMC0/q5BjrgIZ/iWjj6sU0gCIJi3PmW7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7539
X-OriginatorOrg: intel.com

Verified on SRF-SP, the Perf PC2 counter is updated:

[root@p-srf07 ~]# perf stat --per-socket  -e cstate_pkg/c2-residency/ sleep=
 20

 Performance counter stats for 'system wide':

S0        1      9,589,297,024      cstate_pkg/c2-residency/
S1        1     10,204,349,952      cstate_pkg/c2-residency/

      20.003533150 seconds time elapsed

[root@p-srf07 ~]# perf stat --per-socket  -e cstate_pkg/c2-residency/ sleep=
 20

 Performance counter stats for 'system wide':

S0        1      9,309,806,784      cstate_pkg/c2-residency/
S1        1     10,897,684,928      cstate_pkg/c2-residency/

      20.004747926 seconds time elapsed

Tested-by: Wendy Wang <wendy.wang@intel.com>


-----Original Message-----
From: Zhenyu Wang <zhenyuw@linux.intel.com>=20
Sent: Wednesday, May 15, 2024 11:22 AM
To: peterz@infradead.org
Cc: kan.liang@linux.intel.com; linux-kernel@vger.kernel.org; linux-perf-use=
rs@vger.kernel.org; x86@kernel.org; Zhang, Rui <rui.zhang@intel.com>; Bityu=
tskiy, Artem <artem.bityutskiy@intel.com>; Wang, Wendy <wendy.wang@intel.co=
m>
Subject: [PATCH RESEND] perf/x86/intel/cstate: Add pkg C2 residency counter=
 for Sierra Forest

Package C2 residency counter is also available on Sierra Forest.
So add it support in srf_cstates.

Cc: Rui Zhang <rui.zhang@intel.com>
Cc: Artem Bityutskiy <artem.bityutskiy@intel.com>
Cc: Wendy Wang <wendy.wang@intel.com>
Fixes: 3877d55a0db2 ("perf/x86/intel/cstate: Add Sierra Forest support")
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
---
 arch/x86/events/intel/cstate.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/x86/events/intel/cstate.c b/arch/x86/events/intel/cstate.=
c index e64eaa8dda5a..4cd36848cfff 100644
--- a/arch/x86/events/intel/cstate.c
+++ b/arch/x86/events/intel/cstate.c
@@ -64,7 +64,7 @@
  *			       perf code: 0x00
  *			       Available model: SNB,IVB,HSW,BDW,SKL,KNL,GLM,CNL,
  *						KBL,CML,ICL,ICX,TGL,TNT,RKL,ADL,
- *						RPL,SPR,MTL
+ *						RPL,SPR,MTL,SRF
  *			       Scope: Package (physical package)
  *	MSR_PKG_C3_RESIDENCY:  Package C3 Residency Counter.
  *			       perf code: 0x01
@@ -683,7 +683,8 @@ static const struct cstate_model srf_cstates __initcons=
t =3D {
 	.core_events		=3D BIT(PERF_CSTATE_CORE_C1_RES) |
 				  BIT(PERF_CSTATE_CORE_C6_RES),
=20
-	.pkg_events		=3D BIT(PERF_CSTATE_PKG_C6_RES),
+	.pkg_events		=3D BIT(PERF_CSTATE_PKG_C2_RES) |
+				  BIT(PERF_CSTATE_PKG_C6_RES),
=20
 	.module_events		=3D BIT(PERF_CSTATE_MODULE_C6_RES),
 };
--
2.43.0