Date: Thu, 31 Jan 2008 13:35:03 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PATCH] x86_64: fix comments in vmlinux_64.lds
Message-ID: <20080131123503.GG12571@elte.hu>
References: <200801302348.37990.yinghai.lu@sun.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200801302348.37990.yinghai.lu@sun.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 804
Lines: 31


* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:

>  ENTRY(startup_64)
>  SECTIONS
>  {
> -	/* Be careful parts of head_64.S assume startup_64 is at
> +	/* Be careful parts of head_64.S assume startup_32 is at
>  	 * address 0.
>  	 */
>  	. = 0;

but this linker script rule is about startup_64, not about startup_32.

startup_32 does exist on 64-bit too (and is 32-bit code), but it's 
linked to a different address that is not 0:

 ffffffff806c23c0 r startup_32

startup_64 is at offset 0:

 ffffffff80200000 T startup_64

So your patch looks wrong to me.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/