Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933628AbYAaMhy (ORCPT ); Thu, 31 Jan 2008 07:37:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764617AbYAaMho (ORCPT ); Thu, 31 Jan 2008 07:37:44 -0500 Received: from mx2.suse.de ([195.135.220.15]:60617 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbYAaMho (ORCPT ); Thu, 31 Jan 2008 07:37:44 -0500 Date: Thu, 31 Jan 2008 13:37:41 +0100 From: Nick Piggin To: Ingo Molnar Cc: Martin Schwidefsky , Adrian Bunk , Linus Torvalds , linux-kernel@vger.kernel.org, Andrew Morton , Thomas Gleixner , "H. Peter Anvin" , heiko.carstens@de.ibm.com, linux390@de.ibm.com Subject: Re: x86 arch updates also broke s390 Message-ID: <20080131123741.GA10469@wotan.suse.de> References: <20080130011550.GA31853@elte.hu> <20080131003310.GW29368@does.not.exist> <1201772094.18221.32.camel@localhost> <20080131102454.GB27157@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080131102454.GB27157@elte.hu> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1267 Lines: 32 On Thu, Jan 31, 2008 at 11:24:54AM +0100, Ingo Molnar wrote: > > * Martin Schwidefsky wrote: > > > On Thu, 2008-01-31 at 02:33 +0200, Adrian Bunk wrote: > > > <-- snip --> > > > > > > ... > > > CC arch/s390/kernel/asm-offsets.s > > > In file included from > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/s390/kernel/asm-offsets.c:7: > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/sched.h: In > > > function 'spin_needbreak': > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/sched.h:1931: > > > error: implicit declaration of function '__raw_spin_is_contended' > > > make[2]: *** [arch/s390/kernel/asm-offsets.s] Error 1 > > > > > > <-- snip --> > > > > Defining GENERIC_LOCKBREAK in arch/s390/Kconfig takes care of it. I'll > > cook up a patch and queue it in git390. > > thanks! Yeah thanks, don't know what happened with this, sorry. I thought I had defined it for all SMP capable ones, so maybe it was a quilt error or something on my part. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/