Received: by 2002:ab2:7a09:0:b0:1f8:46dc:890e with SMTP id k9csp27247lqo; Wed, 15 May 2024 06:54:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVcGMb51lDfgFnmUk6qPUhHoAW2G0L/ez3SFcMG643vFkzS8nKanfJQ5mjojjyEl0Ng/yeQO8V/K30EwwcYKXFhAMewk61fe0ZAeU/tAQ== X-Google-Smtp-Source: AGHT+IEsmY4EFisinb2EFmu8s7Xi66ZzpkszLf2CYYGWOEPV2UJFPOzu4/twY/7gwN8YjtA7m1Uv X-Received: by 2002:a17:90b:1d05:b0:2b8:e75c:c7e3 with SMTP id 98e67ed59e1d1-2b8e75cc8abmr8056077a91.6.1715781248625; Wed, 15 May 2024 06:54:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715781248; cv=pass; d=google.com; s=arc-20160816; b=nk0CmculGmvdDuroXom3o88JlHsoZiD90wjY38cmQIj+aUux3XLgpBgw0XMRfcB0Wj t/yw4798PXFz38jU4OSTnoKDLwIxCG29bHIK117rRRajqX/yfPR+AY9owbhEHrzvsaku ydW8ThL0HaZXyxxdUwr7I5o/tqgx8388kYHe2i9scvk25oCgOC2ErqP93tQv6GIC6OtZ NRe/1cn4nM8RG027qUVkuxbGdySXg/Xagqcu3+TK8HucAv/ml/ya5HSond9OyzU0YzhY /fwO/LeWtdYT7MqEfCH41rLmaVmCrAzqNc5oaE+eqDDuRPGoMhL9D+uNn2OaQEcl1yY0 Fcsg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=OzyJYYDUTFYPJP+U2wM9vIqZdFdU1WOLTqpltJGlaG8=; fh=bZ5QxROYri8XTks0xbNQG0D8neUQ7/y5piDNnDYi0pw=; b=A7OSLqDnDpCHkMSChnPW77U4fygP8u+2JJJvyStrnyH168pJSIzKjQKeooGFrYaKjN VomzCOkfr2KylZgmvzaEABENTOfZ66o69Sedgtcn2ESP5PW4elZDeKQbFnSaXKusYe3q g+NMJi7fcIueab2iyPwnYG3L04coUIEcqco3rghuDEkGb7top5agBjYvQsnqe8ebHdxK nMxrWMHXKGVwgBpS0VFHLbh3kY5fwFpnlHmPXf1UvYMr8WsuYzx58PhtWbePpWxwBuZE iVmTBl90/Onn8Tha1u5q0b11zNzisJe2YCBBzV0ywUITo79LSJ9//hFI+aUvG7MaCmXw VzPg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=IKOuEdxE; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-179942-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-179942-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2b670f59301si13881840a91.72.2024.05.15.06.54.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 May 2024 06:54:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-179942-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=IKOuEdxE; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-179942-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-179942-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 5A31DB2224A for ; Wed, 15 May 2024 13:53:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A46B713F427; Wed, 15 May 2024 13:53:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="IKOuEdxE" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBBFE13F00C; Wed, 15 May 2024 13:53:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715781200; cv=none; b=D4yQBwNGYA9inoEplpGOpdbVOV1QKLCF4kmRcnrRALhKjxt6dyThQT9Mzaz9u49LFjKX26D2yglsd6a5h9S1Av8JTRfFx5mWHMGfsPexyHup/hFz7xridYc6pWTZ9NctapaAnXzp/pS+4Mu/FKXtwgG0V13sGS/KMvjie6Zxw0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715781200; c=relaxed/simple; bh=OzyJYYDUTFYPJP+U2wM9vIqZdFdU1WOLTqpltJGlaG8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SdSAvHY4L4ZKoFdtwl2eXeoaCme0WLD1NmsewD08S1GHuAZyyIEsY/yYreEti7xl6agqdcAeoxNLqIvMmirkVsXmFiRRxejkicbpm3MWv1TsoeCL0JtH7ok9kZmwL/5BWJD5Ti1piCKOBUxZO+NsGrrZ/HjCxQIgaanGWSKcfg8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=IKOuEdxE; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715781199; x=1747317199; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=OzyJYYDUTFYPJP+U2wM9vIqZdFdU1WOLTqpltJGlaG8=; b=IKOuEdxEboR38Fyo4wC3s3nuSF9kVA0HMQE5+/APuIX/rNfGhddir0HS 4yhHyZGIM7E6kdohnm4hQPe3idOWB9Q/u1ZzVA8dB3yTKoy/VM1GQrHpJ 2SGJoEtetQNZ5ysClowA0n84ZRjqHzCAWZW1csLCVbovKWKil5coVnJWY 55X2PFFr/DXmAmQ4b95QHQpgLzx5YQVzRuPssoCjKyKuusmYhsxgk5ykc K0hW7IUzsnySi5+XabvQqnuwFOF+ZvxlBGlZNZbBVoHCYDIaEmy3zCJ9r 4VCezRIuYGDJgPzEw7rgy8EH9/BfGMp/lK9UIuP6GYsrSXgee4OkZIhxU w==; X-CSE-ConnectionGUID: LjDY8bznR/aKnFkaZuCeSQ== X-CSE-MsgGUID: r5TMSMfqSfaLO8rzM5sCwA== X-IronPort-AV: E=McAfee;i="6600,9927,11074"; a="11702573" X-IronPort-AV: E=Sophos;i="6.08,162,1712646000"; d="scan'208";a="11702573" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2024 06:53:18 -0700 X-CSE-ConnectionGUID: HZfLupOxQPCAFxRwZ/vXIA== X-CSE-MsgGUID: TPBqrF1ETkiAJSWm4OmrWQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,162,1712646000"; d="scan'208";a="31191179" Received: from anujpati-mobl.amr.corp.intel.com (HELO [10.212.146.62]) ([10.212.146.62]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2024 06:53:18 -0700 Message-ID: Date: Wed, 15 May 2024 06:53:17 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv4 3/4] x86/tdx: Dynamically disable SEPT violations from causing #VEs To: "Kirill A. Shutemov" , Nikolay Borisov Cc: Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20240512122154.2655269-1-kirill.shutemov@linux.intel.com> <20240512122154.2655269-4-kirill.shutemov@linux.intel.com> <4019eff6-18a9-49b2-9567-096cdb498fb0@suse.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/15/24 02:30, Kirill A. Shutemov wrote: >> nit: Perhaps this function can be put in the first patch and the description >> there be made more generic, something along the lines of "introduce >> functions for tdg_rd/tdg_wr" ? > A static function without an user will generate a build warning. I don't > think it is good idea. OK, so stick a __maybe_unused on it when you define it and remove it on first use.