Date: Thu, 31 Jan 2008 13:38:45 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <ak@suse.de>
cc: "Huang, Ying" <ying.huang@intel.com>, Ingo Molnar <mingo@redhat.com>,
       "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] x86: change_page_attr_clear fix
In-Reply-To: <200801310843.46831.ak@suse.de>
Message-ID: <alpine.LFD.1.00.0801311333170.9204@apollo.tec.linutronix.de>
References: <1201764959.12950.22.camel@caritas-dev.intel.com> <200801310843.46831.ak@suse.de>
User-Agent: Alpine 1.00 (LFD 882 2007-12-20)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 777
Lines: 22

On Thu, 31 Jan 2008, Andi Kleen wrote:

> On Thursday 31 January 2008 08:35:59 Huang, Ying wrote:
> > This patch replaces __change_page_attr_set_clr() with
> > change_page_attr_set_clr() in change_page_attr_clear() to flush the
> > TLB/cache properly.
> 
> Good catch :-) It actually only needs to flush TLBs not caches in this 
> case.

That's one of the items on our optimizations todo list already. There
are more low hanging fruits, but we need to make sure that the non
optimized version is bullet proof first.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/