From: Andi Kleen <ak@suse.de>
Organization: SUSE Linux Products GmbH, Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
To: Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/5] x86: change_page_attr_clear fix
Date: Thu, 31 Jan 2008 13:53:16 +0100
User-Agent: KMail/1.9.6
Cc: "Huang, Ying" <ying.huang@intel.com>, Ingo Molnar <mingo@redhat.com>,
       "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org
References: <1201764959.12950.22.camel@caritas-dev.intel.com> <200801310843.46831.ak@suse.de> <alpine.LFD.1.00.0801311333170.9204@apollo.tec.linutronix.de>
In-Reply-To: <alpine.LFD.1.00.0801311333170.9204@apollo.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200801311353.16633.ak@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 971
Lines: 24

On Thursday 31 January 2008 13:38:45 Thomas Gleixner wrote:
> On Thu, 31 Jan 2008, Andi Kleen wrote:
> 
> > On Thursday 31 January 2008 08:35:59 Huang, Ying wrote:
> > > This patch replaces __change_page_attr_set_clr() with
> > > change_page_attr_set_clr() in change_page_attr_clear() to flush the
> > > TLB/cache properly.
> > 
> > Good catch :-) It actually only needs to flush TLBs not caches in this 
> > case.
> 
> That's one of the items on our optimizations todo list already. There
> are more low hanging fruits, but we need to make sure that the non
> optimized version is bullet proof first.

I actually ported it already forward from my old patchkit (together
with some other improvements). Will post later.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/