Received-SPF: pass (google.com: domain of linux-kernel+bounces-180057-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Jiasheng Jiang <jiashengjiangcool@outlook.com>
To: viro@zeniv.linux.org.uk,
	brauner@kernel.org,
	jack@suse.cz,
	arnd@arndb.de,
	gregkh@suse.de
Cc: linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Jiasheng Jiang <jiashengjiangcool@outlook.com>
Subject: [PATCH] libfs: fix implicitly cast in simple_attr_write_xsigned()
Date: Wed, 15 May 2024 15:17:25 +0000
Message-ID:
 <BYAPR03MB41685A92DCDD499A2B1369F0ADEC2@BYAPR03MB4168.namprd03.prod.outlook.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BYAPR03MB4168:EE_|CO3PR03MB6759:EE_
X-MS-Office365-Filtering-Correlation-Id: 4bc6d8b2-6bcf-4519-0cfa-08dc74f225a1
X-Microsoft-Antispam:
	BCL:0;ARA:14566002|461199019|3420499023|3430499023|3412199016|440099019|1710799017;
X-Microsoft-Antispam-Message-Info:
	J5Dg0c0bQlhy3f/ZvBTA6qJLvZ3e9VnxRP1sE2SXXweGb9AEN546vlpVTBeb3qYxevyC+kVkMiP93WoVCGBs3rXTRzAsiW3pOgFaNWE87zFlb6E8m3TKTAb65i7LqcXwgYMyYbX9p46JS9U83DXjvBreLrQpozm0JucWlRCR0S/jeRFv2q6a21yMzqLq8FxMywwlg7M7GhjJnDXPtv6esM+9xcljzBIBHqrfqW6w5FADsX6ykQtBACahqK/b/NuFrXQCYy5+oFs0TdznBO8BTPKn5tal2KeiLMKY33dxZ0Lqrjw7cbNCg36oMydXHevJjPxnBF1bH7hRYH1hDXtOLCLUAIesrXN5FTarmtCyl6j2neUMPEuDNqJ2gXLTOdH01sE7YHNk9fZ1Pg5o3Dj3Gki62tkoop/Jacl36PVeNR6kEAoVsMECj2lu1yyEgGSYeL8Q5ngE0Zd4+/wrRnC+2x7S5aJztEbwnYopg3B4dnj1WnnZUUIPcoMizKNZhn4vNMMcoJEBGQTh1h0+B+XQkGzcwZZF6RPeP9qWeGu56WwEzUz1lXHLbw4BGd74vj7GyDXsctmyLSmxsJWToKAWlkQUQvPOam68u69mgCDmLIdTmycIN2orGdaWdj81dpzk
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?2Tty6Qj5aNC69UGlTzYkMZkER63lFagneIoEvk5lh8fVCEkzuwpq9kEOweE0?=
 =?us-ascii?Q?XpOCEkpaY7tvJ5/1RUiLHZPEdWzBuueFMHccrHzQmNWzRud2CreaHQe9KzZU?=
 =?us-ascii?Q?las+3YMNRQlqnLzcv+A0i6SVt9e/6XsrybWwsTIONgYTonh3BWPboXhyqGe4?=
 =?us-ascii?Q?w+5JTS6cLH56J+qSHUOsJ34C/jBWSCA+uBFWMMfAfGnHZE+oH5LgcW3TUqR2?=
 =?us-ascii?Q?fsTpqBNWs0dz//RjlwUFjAHagoeRQD6nGt/a3jfX5/jPt2YCLCmCAxuSNGcC?=
 =?us-ascii?Q?HRsSXY21Zufsz1VZUy9qLmjzuZ5W8A0L1QUwhqA2smbOYjroZmARlTlBXwsw?=
 =?us-ascii?Q?owcDvM8GbYbnI4FvJADYOhOcBWvhqLSO3jOr5aFZ9HnZ44DdnLWyLwb2Ar8h?=
 =?us-ascii?Q?3qx7dz6lsX60CoSieNpeICc1t/GfObJ69tq1nOcUWED/8EV+FgJdvJMzDJTL?=
 =?us-ascii?Q?ZEN/y1+XA9QoPLL7imDsYcqqkWjgpyr0ZVpf4nTCWcEw4BvBqT9EFRBMR+z+?=
 =?us-ascii?Q?UfM+Spd/EEzy0uGaX3IQq5I7BD+iy40PpKZM9LL2skSKowKsJUHaw/mIHUNU?=
 =?us-ascii?Q?myUGY2KkSU+bD1LVqqMe7QGtKf0HefoL8u26TBdM3AeLk400rYHcxcgxIEhJ?=
 =?us-ascii?Q?YT1HdGV3VLWE6295XZwthv4w6BzEm0yQb1LT8YXwnfp6zd0f/tocgYZ9aY5Q?=
 =?us-ascii?Q?ddtQ08Sg4Uv+t1OEFsIuCb/g3RKigNf9Cd7DqgfYgIG6mYxuOg42GstIFybL?=
 =?us-ascii?Q?EuU701hkNtl6PwQMQG5mTpjDDzJgIJgzdlIISt04Nx8R4KK2tuDo5Wbl7d3W?=
 =?us-ascii?Q?+qA3l9CsiLhaPPTgdcHScJW1iB5M5Z6ZfV9ociPdX/sSxeIJrIvgHK2VpGpQ?=
 =?us-ascii?Q?DSMVLlxGvG/RmKgVu803F2AOIO6UihecbVHGqfM9IExMVVQ89U3JIhdMaRDm?=
 =?us-ascii?Q?3JWW4Z4BpxB/BI1bG0cpBZYsoHek7F7BwBvmzHevD7gVEUFx3r9Uet/F+JTt?=
 =?us-ascii?Q?6AvcdL01hWlF52dDkTv1l/LVk2TNyj4O0OVwgsMYeDDvRhUjo+m1kHFJ76UG?=
 =?us-ascii?Q?bDfxAe1l6FjwtcRo4co3VF3IHT2qDQNmyZg8stVwCDX5nAAp1ZQa+QLsPM0t?=
 =?us-ascii?Q?OhHP48w6gdApc4Tzn7rxmooYBZfKd65BKhnBgD+0v2XG3RftONiFV/IshMGw?=
 =?us-ascii?Q?9/i7hY5VrijX398YplhrAjuQeQvGfORHNaTa5TiBhYvQYoTCH5wO08XZw9IY?=
 =?us-ascii?Q?b9tbjEy3H5hSU/VtPz01?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bc6d8b2-6bcf-4519-0cfa-08dc74f225a1
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB4168.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2024 15:17:35.8252
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6759

Return 0 to indicate failure and return "len" to indicate success.
It was hard to distinguish success or failure if "len" equals the error
code after the implicit cast.
Moreover, eliminating implicit cast is a better practice.

Fixes: acaefc25d21f ("[PATCH] libfs: add simple attribute files")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@outlook.com>
---
 fs/libfs.c | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/fs/libfs.c b/fs/libfs.c
index b635ee5adbcc..637451f0d53e 100644
--- a/fs/libfs.c
+++ b/fs/libfs.c
@@ -1348,24 +1348,27 @@ static ssize_t simple_attr_write_xsigned(struct file *file, const char __user *b
 
 	attr = file->private_data;
 	if (!attr->set)
-		return -EACCES;
+		return 0;
 
 	ret = mutex_lock_interruptible(&attr->mutex);
 	if (ret)
-		return ret;
+		return 0;
 
-	ret = -EFAULT;
 	size = min(sizeof(attr->set_buf) - 1, len);
-	if (copy_from_user(attr->set_buf, buf, size))
+	if (copy_from_user(attr->set_buf, buf, size)) {
+		ret = 0;
 		goto out;
+	}
 
 	attr->set_buf[size] = '\0';
 	if (is_signed)
-		ret = kstrtoll(attr->set_buf, 0, &val);
+		ret = (size_t)kstrtoll(attr->set_buf, 0, &val);
 	else
-		ret = kstrtoull(attr->set_buf, 0, &val);
-	if (ret)
+		ret = (size_t)kstrtoull(attr->set_buf, 0, &val);
+	if (ret) {
+		ret = 0;
 		goto out;
+	}
 	ret = attr->set(attr->data, val);
 	if (ret == 0)
 		ret = len; /* on success, claim we got the whole input */
-- 
2.25.1