Received-SPF: pass (google.com: domain of linux-kernel+bounces-180066-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
References: <20240515033051.2693390-1-nichen@iscas.ac.cn>
User-agent: mu4e 1.10.8; emacs 28.2
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Chen Ni <nichen@iscas.ac.cn>
Cc: jikos@kernel.org, bentiss@kernel.org, linux-input@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: nvidia-shield: Add missing check for
 input_ff_create_memless
Date: Wed, 15 May 2024 07:59:33 -0700
In-reply-to: <20240515033051.2693390-1-nichen@iscas.ac.cn>
Message-ID: <87jzjvgkn1.fsf@nvidia.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?mauHoofitJLDcQyH6eE7xxBdbsRwHpToQOCS5AeesNRKjOnYalX3GK3XEmhd?=
 =?us-ascii?Q?Ey6WGDf9ojVovwdE/gR7KmsjXyEZr540bkDGFEK1JDeo5vNnoMIE/esPMfyA?=
 =?us-ascii?Q?AT3FNF+yMy8xjuKSdpHE0Z50ZZj1PCjhm6C5qEFuwXXFebDpJ8ysTVJ0MG4C?=
 =?us-ascii?Q?RaN73ZPw45FGzKSc3sWagPGlUzZilx9WY7VxBaMQo1YAcOyUjPF0TlQ/XAuW?=
 =?us-ascii?Q?qjfB7W9eVNCaKfv6jAsZV82Cgu6Jw9wwpILA4Dclb+SN4dOmZq7pJ9FAeB2X?=
 =?us-ascii?Q?b+2T4wt/bckHmrc8TR8ufRVXpWaFl32BigeIdEEdQw7J/ZsbueakgoGUfgRG?=
 =?us-ascii?Q?b+LxJDZSNZuRc2ag9NWWZXNVhgjjpw65IQJdfVHa5xR4BinDvV1RSrWTpWma?=
 =?us-ascii?Q?wuc7vZzjdorIVb6Snkgvof0+W7Cm2agnqJHyxvDlqtPcxeh4wgE4hqOr65PD?=
 =?us-ascii?Q?OeHoPfrdTGXp6/tVAGI3dHhiWboRLDidNdsGHYB/GJ5m0FDa301yz87uFc73?=
 =?us-ascii?Q?6tJtgjIr7k0fQesiyENN9W29Ba3l1gp9uo4yKQ3ySQK7wHkQFFAAtMdNerhJ?=
 =?us-ascii?Q?bKjAQzLBHKixCF5WuoB97c4MiC0phwS/aUmlntp8pg0KdvDQD4fUOd4hoUAj?=
 =?us-ascii?Q?1U6X1e+UcXfPY4Rf4acwqVkszB/HPecMPWaHlE6Ztz//LcAYpk7dbpuYyGhJ?=
 =?us-ascii?Q?3MqaJLnldjvyxCUQIEuFyeIENASUxWGXuTX71vpS/JwbI24+cF2HPR0SE+Lw?=
 =?us-ascii?Q?8K9EkwNw0CO5srYlvDgFWqn4AdLTww0z92pJ+UR49akCqqamgnrN0Kqd/9EH?=
 =?us-ascii?Q?kGyr38HkAzxbsKExMIdH+zw2jPsAbkdCb6NZtQtEdZa7lcm0DczDboiKVe7i?=
 =?us-ascii?Q?WbLIcGcoQ9ZM9OBsTRvhbJDDZw+YT+b8HbWbMEzdrIpK1pD2MwuEKt9Oa836?=
 =?us-ascii?Q?2IALFu0mi+InOjTb9ZzQ3OVzBxc1mnoH7Uy3Qvhdm3fX5YMY6DZEkUtb7IRF?=
 =?us-ascii?Q?SYsrQr1SE028ktaKl3GtYrxyrMscSanzO7LDAlGt19gHsdMtZcTTqGyvtC6Y?=
 =?us-ascii?Q?lV3gMEUb4PGT0szRd30JkcPcVWI5B49spl0NKzX38+8j9O3mlKXF0RHXO047?=
 =?us-ascii?Q?EdMSTycml/4jXlQerUPSz67Eg7RMuFGm1sgyRAbkeHiM2Z/SOOwZUsX8A+Pb?=
 =?us-ascii?Q?jOTKIx2ZxcvMOYIYQU+70DDSm58i1lCbXXKV9bfp2oxf3tjPG1crfQatzY8v?=
 =?us-ascii?Q?sSZ45WahMut1fFZt0nYt7VuxK8ZO+TzxvQLRLRQBg2cV8gHSdEBl4lmlF1Gu?=
 =?us-ascii?Q?au1cF1dXpYLkzHxQXXgkvSyWcdQrt8Iep2chqROULP9Xl4VXacB/vJf7nWYj?=
 =?us-ascii?Q?36v8A58jJDYjQ1+AfgZ8xIrMKa4eakna9s+yJP3RXRVsT1WUI0zfcC0E+4IB?=
 =?us-ascii?Q?w6YUUzda/kIq/4PRkHJJhR7Fw+8Hp13q/TC+372pvjRYf0VZ7K71yQr3bXlU?=
 =?us-ascii?Q?JzVWZeN8b1ZYJDGY5EMHo5L+4JbkCgNFNuHfxaVHujxxMoNSM06K00HUlp2X?=
 =?us-ascii?Q?NJXr4vQDZMcwjftHOQoZsVFxMj6d/TOV8YMMZbqw5XbmveksH5opcrB6qmai?=
 =?us-ascii?Q?t4/ZoMUL71DdkvsFu5HqjC3EzJ/lUeg6IZyCG0onPF23DbTkwpgHn8k9J3Ei?=
 =?us-ascii?Q?+sT9ww=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a405587-e770-41f7-8605-08dc74f39cca
X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB8775.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2024 15:28:03.7560
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mK4uNbGsiC9mmHnuXSV0nFWx6X50rnjr+kGPeRmtvo35yWZoXy7JZ6HO+tW7L7ajYfHnHamFqyFtkoQbHh/dvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7992


On Wed, 15 May, 2024 11:30:51 +0800 Chen Ni <nichen@iscas.ac.cn> wrote:
> Add check for the return value of input_ff_create_memless() and return
> the error if it fails in order to catch the error.
>

You will need a Fixes: tag here.

Fixes: 09308562d4af ("HID: nvidia-shield: Initial driver implementation with Thunderstrike support")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/hid/hid-nvidia-shield.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-nvidia-shield.c b/drivers/hid/hid-nvidia-shield.c
> index 58b15750dbb0..ff9078ad1961 100644
> --- a/drivers/hid/hid-nvidia-shield.c
> +++ b/drivers/hid/hid-nvidia-shield.c
> @@ -283,7 +283,9 @@ static struct input_dev *shield_haptics_create(
>  		return haptics;
>  
>  	input_set_capability(haptics, EV_FF, FF_RUMBLE);
> -	input_ff_create_memless(haptics, NULL, play_effect);
> +	ret = input_ff_create_memless(haptics, NULL, play_effect);
> +	if (ret)
> +		goto err;
>  
>  	ret = input_register_device(haptics);
>  	if (ret)

I applied and tested the patch locally, and it looked good. If Jiri or
Benjamin can apply the patch with the updated trailer, then you can add
my Reviewed-by: trailer.

Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>