Received-SPF: pass (google.com: domain of linux-kernel+bounces-180069-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <171405653305.2527744.3813895380659072690.robh@kernel.org>
 <20240426142442.7769-1-quic_vvalluru@quicinc.com> <jr3ble6sxr5mr6cvm6ldvpyk5j4rucj3xy6vbha6ttoecte3d7@llu6qf6oasuc>
 <171517823376.1753082.4070659246393696781.robh@kernel.org> <20240515150459.GA32547@hu-vvalluru-hyd.qualcomm.com>
In-Reply-To: <20240515150459.GA32547@hu-vvalluru-hyd.qualcomm.com>
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Date: Wed, 15 May 2024 17:28:24 +0200
Message-ID: <CAA8EJpo=Q4_=JU83-9ooSqiSr=xUeHh2awDhzq9q3Xd56h83zw@mail.gmail.com>
Subject: Re: [PATCH v2] arm64: dts: qcom: qcs6490-rb3gen2: enable hdmi bridge
To: Prahlad Valluru <quic_vvalluru@quicinc.com>
Cc: "Rob Herring (Arm)" <robh@kernel.org>, Bjorn Andersson <andersson@kernel.org>, linux-kernel@vger.kernel.org, 
	quic_nankam@quicinc.com, linux-arm-msm@vger.kernel.org, 
	quic_abhinavk@quicinc.com, konrad.dybcio@linaro.org, conor+dt@kernel.org, 
	krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Wed, 15 May 2024 at 17:05, Prahlad Valluru <quic_vvalluru@quicinc.com> wrote:
>
> On Wed, May 08, 2024 at 09:31:24AM -0500, Rob Herring (Arm) wrote:
> >
> > On Mon, 06 May 2024 18:14:10 -0500, Bjorn Andersson wrote:
> > > On Fri, Apr 26, 2024 at 07:54:42PM GMT, Prahlad Valluru wrote:
> > > > From: Venkata Prahlad Valluru <quic_vvalluru@quicinc.com>
> > > >
> > >
> > > Please don't thread new versions off existing version. b4 helps you with
> > > getting these things right, please check go/upstream for more details.
> > >
> > > > Enable lt9611uxc bridge for qcs6490 rb3 gen2 platform.
> > > >
> > >
> > > Even if it's clear what this is, I would prefer if you described the
> > > hardware a little bit in your commit message.
> > > "Rb3Gen2 has a HDMI connector, connected to DSI via a LT on i2cX.... reset and
> > > irq pins comes from x and y. Describe this."
> > >
> > > > Signed-off-by: Prahlad Valluru <quic_vvalluru@quicinc.com>
> > > > ---
> > > > v2: Addressed dtschema errors
> > > >   - Fixed lt9611-irq
> > > >   - vdd-supply error to be ignored, as it is connected to
> > > >     input supply directly, on rb3gen2
> >
> > The choice is either fix the dts or fix the binding.
>
> vdd-supply is mandatory for lt9611. Only in case of rb3gen2, we are seeing this
> error, since it is connected to supply directly. Will add dummy vreg to address this.

s/add dummy vreg/describe fixed hardware register/


-- 
With best wishes
Dmitry