Date: Thu, 31 Jan 2008 14:24:38 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: Andi Kleen <ak@suse.de>, Christoph Lameter <clameter@sgi.com>,
       Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
       Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 4/4] x86_64: increse MAX_EARLY_RES for NODE_DATA and
	bootmap
Message-ID: <20080131132438.GC8499@elte.hu>
References: <200801291113.35974.yinghai.lu@sun.com> <200801291116.31729.yinghai.lu@sun.com> <200801300357.54924.ak@suse.de> <200801291925.53726.yinghai.lu@sun.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200801291925.53726.yinghai.lu@sun.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 975
Lines: 33


* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:

> ok, discard 3, and 4.
> 
> how about 2 v2?

i'm leaning towards v4, but the more fundamental breakage is in the 
early_node_mem() ad-hoc allocator that got butchered into this code a 
year ago:

  commit a8062231d80239cf3405982858c02aea21a6066a
  Author: Andi Kleen <ak@suse.de>
  Date:   Fri Apr 7 19:49:21 2006 +0200

      [PATCH] x86_64: Handle empty PXMs that only contain hotplug memory

  ...
  +static void * __init
  +early_node_mem(int nodeid, unsigned long start, unsigned long end,
  +             unsigned long size)

and we are now suffering the side-effects of that hack.

what i suspect we need instead is a proper early-allocator that works in 
the e820 space.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/