Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933900AbYAaNab (ORCPT ); Thu, 31 Jan 2008 08:30:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932174AbYAaNaX (ORCPT ); Thu, 31 Jan 2008 08:30:23 -0500 Received: from wx-out-0506.google.com ([66.249.82.239]:17340 "EHLO wx-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1765905AbYAaNaV (ORCPT ); Thu, 31 Jan 2008 08:30:21 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=APYNKdCnLYLuaNYlEB0/F8xQA13kMpghy61a2MddqQ4ro56PKAUV1KiDqn6r+2hkYcQKEXz+SXiTRec7NiXRU0HrDvk03Twe3eQJ/NQ2Df6ESu5SL91M3wsPUxisc5sRgbo1eGdoekdHFNtVBcimozQXtnteONt3sStUQ7qUiPo= Message-ID: <851fc09e0801310530p5f5839aat141ae9fcb6713b25@mail.gmail.com> Date: Thu, 31 Jan 2008 21:30:19 +0800 From: "huang ying" To: "Ingo Molnar" Subject: Re: [PATCH 5/5] x86: EFI memory mapping changes according to changes to ioremap and c_p_a Cc: "Huang, Ying" , "Ingo Molnar" , "H. Peter Anvin" , "Thomas Gleixner" , "Andi Kleen" , linux-kernel@vger.kernel.org, "Arjan van de Ven" In-Reply-To: <20080131121823.GF12571@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1201764968.12950.26.camel@caritas-dev.intel.com> <20080131121823.GF12571@elte.hu> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1600 Lines: 38 Jan 31, 2008 8:18 PM, Ingo Molnar wrote: > > * Huang, Ying wrote: > > > + /* Assume pages are mapped as WB */ > > + if (mode == IOR_MODE_UNCACHED) > > + set_memory_uc(md->virt_addr, md->num_pages); > > + /* Assume pages are mapped as unexecutable */ > > + if ((__supported_pte_mask & _PAGE_NX) && > > + xmode == IOR_XMODE_EXEC) > > + set_memory_x(md->virt_addr, md->num_pages); > > hm, why is the check for __supported_pte_mask needed? That is already > listened to in set_memory_x(). [if not then it's an ioremap bug that we > want to fix.] OK, I will check it. > > -static int ioremap_change_attr(unsigned long paddr, unsigned long size, > > - enum ioremap_mode mode, > > - enum ioremap_xmode xmode) > > +int ioremap_change_attr(unsigned long paddr, unsigned long size, > > + enum ioremap_mode mode, > > + enum ioremap_xmode xmode) > > hm, there should be no need to use this raw API. Oh, you are right. __efi_ioremap() is only used when there is no identity map. So ioremap_change_attr() need not to be called in __efi_ioremap(). Best Regards, Huang Ying -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/